From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AB24CA6011 for ; Thu, 8 Oct 2026 17:14:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=PdWOqQogo+o5df/NaWtv2hf18phD7ugzD+AieGRRw4Y=; b=kS4peCK/TGBe5Xizb5xDtoP60W 22fKRRFCWtt54aexisK9OZx1EWSKZPXzPhc0fM2qH6KFDTuwSRvxBTTwptnOPFSYCt9G1cOLbW7ko b3X8W4eq+gVWj8VQacqzz8M/TtiVjVDbLorQd7/9R5hHKocGNj0MYngPJNnEVkmh1e9cl97fawss7 IEZhs97VL5Z7moCSAwNyYs2Mhg5RM3+iqvzmCia9qhhLOHC2GwMo5yC+CPv0jHNui2+2d8EDQtTkU Rv3skMtICd0AH+G6KScROsiJTe92sD8FLJZq9AjXwkPau5oVakrtxJ+Y7QAdAH8w2bZmRba6OIbk1 Qpx07BAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xErhD-00000004lLd-10lD; Thu, 08 Oct 2026 17:14:19 +0000 Received: from smtp81.cstnet.cn ([159.226.251.81] helo=cstnet.cn) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xErh9-00000004lKt-3hN1 for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2026 17:14:17 +0000 Received: from fc87d0ffb700.home.arpa (unknown [36.110.52.2]) by APP-03 (Coremail) with SMTP id rQCowABnbjxfz8dqR+cOCg--.12118S2; Fri, 09 Oct 2026 01:14:08 +0800 (CST) From: Haotian Zhang To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King , Arnd Bergmann , Jason Cooper Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: mvebu: mvebu-soc-id: fix missing clk_put() on error path Date: Fri, 9 Oct 2026 01:14:10 +0800 Message-Id: <20261008171410.2717704-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: rQCowABnbjxfz8dqR+cOCg--.12118S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw4rurWUWF4UtrWUGr4xtFb_yoWDZwbEkF 1Sg3sFyryfWFs5u347W3W3uanIkr1xZrWUZFyxAr4FkFW5Xr47urW8tw15Kr1aqrsrKry3 Gry8Ca15Ww13JjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcxYjsxI4VWkKwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26F4j6r4UJwA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxkF7I0En4kS14v26r126r1D MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JV WxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAI cVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU5-txPUUUUU== X-Originating-IP: [36.110.52.2] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAMOA2rHpfVfIgABsD X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_101416_298000_B746C57B X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org get_soc_id_by_pci() takes a reference on the PCIe clock with of_clk_get_by_name(), but when clk_prepare_enable() fails it jumps to the clk_err label, which only drops the device node references and never calls clk_put(). The struct clk and the clock core reference it holds are leaked on that error path. Release the clock reference before jumping to clk_err. Fixes: af8d1c63afcb ("ARM: mvebu: Add support to get the ID and the revision of a SoC") Assisted-by: DeepSeek-V4.1-Flash Signed-off-by: Haotian Zhang --- arch/arm/mach-mvebu/mvebu-soc-id.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-mvebu/mvebu-soc-id.c b/arch/arm/mach-mvebu/mvebu-soc-id.c index 850ed3ea3cc4..84831798357e 100644 --- a/arch/arm/mach-mvebu/mvebu-soc-id.c +++ b/arch/arm/mach-mvebu/mvebu-soc-id.c @@ -85,6 +85,7 @@ static int __init get_soc_id_by_pci(void) ret = clk_prepare_enable(clk); if (ret) { pr_err("cannot enable clock\n"); + clk_put(clk); goto clk_err; } -- 2.25.1