From: Joey Lu <a0987203069@gmail.com>
To: sboyd@kernel.org
Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com,
arnd@arndb.de, bmasney+clk@redhat.com, jbrunet+clk@baylibre.com,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, Joey Lu <a0987203069@gmail.com>
Subject: [PATCH 0/3] clk: nuvoton: ma35d1: fix parent lookup and use the generic ADC divider
Date: Mon, 12 Oct 2026 14:30:17 +0800 [thread overview]
Message-ID: <20261012063020.3331443-1-a0987203069@gmail.com> (raw)
The parent tables of the MA35D1 clock controller were converted to
struct clk_parent_data with only .fw_name set, but the controller node
has no clock-names, so the firmware lookup can never succeed and the clk
core only falls back to a global name lookup when .name is set. As a
result sysclk1_mux and everything below it (hclk*, pclk*, and the
peripheral dividers and gates) are orphans with a rate of 0 Hz, and
clk_set_rate() on their consumers returns early without programming the
hardware. This was found while testing the ADC clock, whose divider
register was never written.
Patch 1 fixes the parent lookup. Patches 2 and 3 replace the dedicated
ADC divider driver with the generic clk divider, as suggested in review
of the earlier "use direct formula instead of divider table" series,
which is dropped in favour of this one.
The earlier series:
https://lore.kernel.org/r/20261008064307.2757324-1-a0987203069@gmail.com
Joey Lu (3):
clk: nuvoton: ma35d1: fix parent lookup for clk_parent_data entries
clk: nuvoton: ma35d1: use the generic divider for the ADC clock
clk: nuvoton: ma35d1: remove the unused ADC divider driver
drivers/clk/nuvoton/Makefile | 1 -
drivers/clk/nuvoton/clk-ma35d1-divider.c | 133 -----------
drivers/clk/nuvoton/clk-ma35d1.c | 269 ++++++++++++-----------
drivers/clk/nuvoton/clk-ma35d1.h | 5 -
4 files changed, 135 insertions(+), 273 deletions(-)
delete mode 100644 drivers/clk/nuvoton/clk-ma35d1-divider.c
--
2.43.0
next reply other threads:[~2026-10-12 6:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 6:30 Joey Lu [this message]
2026-10-12 6:30 ` [PATCH 1/3] clk: nuvoton: ma35d1: fix parent lookup for clk_parent_data entries Joey Lu
2026-10-12 6:30 ` [PATCH 2/3] clk: nuvoton: ma35d1: use the generic divider for the ADC clock Joey Lu
2026-10-12 6:30 ` [PATCH 3/3] clk: nuvoton: ma35d1: remove the unused ADC divider driver Joey Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012063020.3331443-1-a0987203069@gmail.com \
--to=a0987203069@gmail.com \
--cc=arnd@arndb.de \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=yclu4@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox