From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7807CC6B16 for ; Tue, 13 Oct 2026 15:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S8YZz6YHs+YnhWOB98iSQEya+TM/J9HiEFdEjzFss5E=; b=Pp0oZXnQNxjQ6ZqIwojq8ruo8A t+6tZtSFqmzPNnU8BLk4XEJpqxpA+f/eUYmi54T4ncDfIuuxUcQ0qDe54YyrlmHDpLBWzQQw2uC3I 5+gWT9l7iufP0+X/KzySTvFY5awknm1Su75TNonLJl+PZ50jxHP/8TQGaWRUQ08WYcHVtAEyzYXaN UfjHBDomW0pcDlZm9BipDQ8DOnTwZ+38ZOS+P/e2g9t3Rb2/nu8RdA953t5un6R58qNC2REwcD3/L 7MK+rNIILqnohr8gA5sf9sPiaufgX8Ec4x5SdwCrxA/ut+XKgeh948AprYc9Eg3tW8XyCyHX3H5+C fv/9HPfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGeJN-0000000DIOQ-0HxK; Tue, 13 Oct 2026 15:21:05 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGeIk-0000000DHzb-2eM5 for linux-arm-kernel@lists.infradead.org; Tue, 13 Oct 2026 15:20:31 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-8897e83332fso2176504b3a.1 for ; Tue, 13 Oct 2026 08:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791904826; x=1792509626; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S8YZz6YHs+YnhWOB98iSQEya+TM/J9HiEFdEjzFss5E=; b=o4+Lzkm80nyyl2WUXBAeB39uhSUJLbOpwD6LUXuav/5kQvWbz/1Te6Lf0m1VeGva8s QkAezYK7VgpPR7mMRB601+W05KSbd9iRTXEYUacuB6qYAkCNp7/OLysCzgicNXkj1544 JUkyppd6wWYXkUXIGQxm+EQjNYkt7+pbZ2HkEZzGZoYZ5jmYrrpLc4wMmE8C+5IxJKSj GlYb4/nMGdZWOXr/cHgcuWFMX0q7mgs45odFztjU1+yubeUd7mz7cWbg60aZPLRRS747 9yY1CHm5VL8idowD2TL62Hqc4YLiHOnutNtcOFqPx784MYukIE+aDoliAH93jLQ/GK0J bLTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904826; x=1792509626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=S8YZz6YHs+YnhWOB98iSQEya+TM/J9HiEFdEjzFss5E=; b=AfscaiJ4e7IFSeSvlxB2V7HsUBXWBOgqjMYNjluQHwqaytpcApQkHbNnqB4RqTn6ut F9ZZbe2bxv/gUG2UbTlmQ5pHSAUe2Ze1URUkptY6RSANa0VhkuNPzoXSCyeB6qH2voUy yPA40EqbKrmgJK9LcBw52nVtqH41yNQO1A0sklUfY7NViqo94Br9JjYlSeZjg52WIaYp 8XpKi326QJCVOhvzEXLe6sNptFQoRiarmtpFgeYL6jWCFr9yWRDHwmEaBVWKZq88nGJI iD9PfuKECD3YbXEzJhBncD0D/9Dkv2nBYYIPi9NS4eLFBO2BwYMp5eM1kI4D0+9vuO5Y vduQ== X-Forwarded-Encrypted: i=1; AKwUvBwP9f/JiF1V1wvvQ8h8fkwotPKcGxi8xQdd32ioFBMaawj1eeVC8ahHNPgrlxOoq3KnFrbJcgTSoVbmzPQgO023@lists.infradead.org X-Gm-Message-State: AFq9FYI6WfFla3lIb/wh8FKLVcifbYE3K9weJQyS3qnEKjp6+5sZk7F0 VMdRre0kcpZDDc0sAhj7dARgIk/jHbJ8+yFjIYAb1zXPaJVtWJNgNqLR X-Gm-Gg: AYBFou0cFt4JolqEub6hv+D+G7HPl2Tcw91znma978OkEDO4AB6yNOvGqqCD9cNf3MS Pa091m7nnxNMq37Kl8lBYpqlNvS0uVBs9CdSy/XjnkokPpzflQzxcchz5WUElpCHCLud8EeWde4 Wg5UIVMFstD1wq6ErONxNA+Nv17qQWrLJgIwzLfQiFMDFpgF6Tk+1xlyQ8lZcbO/fipo8bIshGh LPZ6Tje3uG3tYDF/FdJppHFnWCGopZvRJRIU57sN7BsF+ylBxI4DLaN77/YwToK9GB2+AGh5wQ+ Zi3x2AmiLEq7k/Xt07lAtgkZa8po9lLOYMXtp1yxvs4CjI35APd5adDwE9yeIYHgRMsBPawFGgC WZLjD0U/1PWA/Z+MDpy4fTXzetAOo92rMUj+fFBONMEXywlKTeCBQtj93t02QgH2Tx+mAGQh6i2 fUYw/hL/Iy+58//W+En8e3YuBo2mHLBOjraLc+ngNbYjk5cTDIZkhNDQZPQFVfEGBx3dHNzqvIs NyvFDd215jaDlHFg6UwBkPfeXxDIFcT9Y+rHdA= X-Received: by 2002:a05:6a21:4ea5:b0:3e0:c2ce:3f71 with SMTP id adf61e73a8af0-3e16be71fe1mr9198126637.37.1791904825086; Tue, 13 Oct 2026 08:20:25 -0700 (PDT) Received: from buffalo-ssd.taila54753.ts.net ([240b:253:4760:f400:1ebf:ceff:fe7f:5e0b]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3da04596dsm5759888a12.29.2026.10.13.08.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:20:24 -0700 (PDT) From: Akari Tsuyukusa To: Brian Masney , Jerome Brunet , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Chen-Yu Tsai , Bartosz Golaszewski , Kees Cook , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Danilo Krummrich , Nicolas Frattaroli , Bjorn Helgaas , Takashi Sakamoto , Haotian Zhang , Miles Chen , Sam Shih , Daniel Golle , Chun-Jie Chen , Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), Akari Tsuyukusa Subject: [PATCH v2 25/35] clk: mediatek: mt7988-apmixed: Switch to common probe/remove helpers Date: Wed, 14 Oct 2026 00:17:24 +0900 Message-ID: <20261013151734.3177690-26-akkun11.open@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013151734.3177690-1-akkun11.open@gmail.com> References: <20261013151734.3177690-1-akkun11.open@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261013_082028_023889_D751F615 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The MT7988 apmixedsys driver used a custom probe to register PLLs but had no remove callback. With PLL registration and unregistration handled by the common helpers, the driver can use mtk_clk_simple_probe() and mtk_clk_simple_remove(). Switch to module_platform_driver() to support module unloading and ensure that registered clocks are unregistered on removal. Signed-off-by: Akari Tsuyukusa --- Changes in v2: - Improvement of commit messages --- drivers/clk/mediatek/clk-mt7988-apmixed.c | 39 ++++++----------------- 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt7988-apmixed.c b/drivers/clk/mediatek/clk-mt7988-apmixed.c index 24f4e7b87a31..f7bb00e7d17a 100644 --- a/drivers/clk/mediatek/clk-mt7988-apmixed.c +++ b/drivers/clk/mediatek/clk-mt7988-apmixed.c @@ -71,47 +71,26 @@ static const struct mtk_pll_data plls[] = { 0, 0x0318, 0, 0x0314), }; +static const struct mtk_clk_desc apmixed_desc = { + .plls = plls, + .num_plls = ARRAY_SIZE(plls), +}; + static const struct of_device_id of_match_clk_mt7988_apmixed[] = { - { .compatible = "mediatek,mt7988-apmixedsys" }, + { .compatible = "mediatek,mt7988-apmixedsys", .data = &apmixed_desc }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, of_match_clk_mt7988_apmixed); -static int clk_mt7988_apmixed_probe(struct platform_device *pdev) -{ - struct clk_hw_onecell_data *clk_data; - struct device_node *node = pdev->dev.of_node; - int r; - - clk_data = mtk_alloc_clk_data(ARRAY_SIZE(plls)); - if (!clk_data) - return -ENOMEM; - - r = mtk_clk_register_plls(&pdev->dev, plls, ARRAY_SIZE(plls), clk_data); - if (r) - goto free_apmixed_data; - - r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data); - if (r) - goto unregister_plls; - - return r; - -unregister_plls: - mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); -free_apmixed_data: - mtk_free_clk_data(clk_data); - return r; -} - static struct platform_driver clk_mt7988_apmixed_drv = { - .probe = clk_mt7988_apmixed_probe, + .probe = mtk_clk_simple_probe, + .remove = mtk_clk_simple_remove, .driver = { .name = "clk-mt7988-apmixed", .of_match_table = of_match_clk_mt7988_apmixed, }, }; -builtin_platform_driver(clk_mt7988_apmixed_drv); +module_platform_driver(clk_mt7988_apmixed_drv); MODULE_DESCRIPTION("MediaTek MT7988 apmixedsys clocks driver"); MODULE_LICENSE("GPL"); -- 2.56.0