From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0357ACC6B1F for ; Tue, 13 Oct 2026 15:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AUYTFLfF8KyYjB9jrAOG5HypNcpJe9ONDAWrxzRVXzY=; b=h62HCsSM8j4orrNr4JPJEBjvkD uYDyS4AsNpr04f6GZ3x6wQ9Lx+pYz69Cfb8QJAAp4G+AQEj73Bg5P0ejP8LGW6CzA9CuG6/nw74xW 4y8ff+Tw7jAvwdfUmQpOrdoZ81HDvdwXWNQ4moiR4OOzF7tySInDlhUwyZaigEp7A3UCB5WsXl69W 1h0UShxbsKApyNZfig7KP3lbkZ7LHg/jHApbh41AewHHCoOiMKdlL6riqqjGmRdj8AxnmCMljAwHx k2DGRezR5FfbBURFk2eIRx6vN27v/LLg7heaDi1005JMxodiiiUr3NLM+Ulhi5aST/96OmQOlRJIp pjApv/fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGeGu-0000000DG7M-17MN; Tue, 13 Oct 2026 15:18:32 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGeGn-0000000DG1K-3dRz for linux-arm-kernel@lists.infradead.org; Tue, 13 Oct 2026 15:18:27 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-8897e83332fso2174817b3a.1 for ; Tue, 13 Oct 2026 08:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791904705; x=1792509505; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AUYTFLfF8KyYjB9jrAOG5HypNcpJe9ONDAWrxzRVXzY=; b=l/rGENL15a4H5lV6Rvo0dUt/5ni26bT5t/Of8FNvVw2bG1IXVIPxCZL6Vzjkm/g6J3 1MDFr4cPcS56P7awPWNIWFwjFNcJFGTGcuQF+PcI6LHHS/yvW91xIrPckZeDXieLurUE bxQlsHIc+JGzfNyuHw+SKodyubqGXGKuWXaw6+W3hYPqXGbZrABkkRoNAZhGFH2c/FDe 862SApTi5pWEE8GjPA1km5Bwe7iMTNkABoekLiiWphJxqSO2zwGNy7cLyML4cM55oP1E CrGAhRosWzMvWbgDgHFzCy1a5cXmPVTYIbRJaA+TXR/2y656D2hPpVW4r1hDqLPhBxXz o0fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904705; x=1792509505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AUYTFLfF8KyYjB9jrAOG5HypNcpJe9ONDAWrxzRVXzY=; b=2xbzmSDsaVu5X3Z+Pok+80z5tl+CCKecxhGag6HLwok0nuHnnIE7G91tsflvQ5cALK DgVHekUoAqSFNKUH2c099+KnXkT5br4h9zlg1aT++YDgNKQ6LK/xzmDs/zYPXYfVuIDx ZlccvidLe0N39PloC0eOHQpDVRH2KqV1UjkMchXBNm643qP0PtgqOnIz1/M9xU2SW21G cbQbE727ebMRMVmAfgl489kA1J1YQtdV0Z+jzBPOFF3SIn48PV1Fji/FRfr3MioMl43H 6aUE4l0wEztwg9I4qSiAqC8W4bDpDi6Hhi9mkHrkZlW5efiWyT2o4iVB7EH4eAKG++d6 TvGg== X-Forwarded-Encrypted: i=1; AKwUvBzs5UA5XqDbpJKCuteVaRR9ZEh2BH+KfQdS/ZGkmx2NHG9gg0jNPGrdvAsu+1YQAFtsTOLFIJytJ4IbAkmEC6nB@lists.infradead.org X-Gm-Message-State: AFq9FYLzAXTqwXlwdMWZ9iDTzUnqoSuvHzBmav/im34q4Exbx9iEQpNE PrS54HpnehXtPYjMJlxHgq/brV+GoUohWcIYKuHFFu8tue+GU6OzL+z2 X-Gm-Gg: AYBFou35epmcTL65bNg283dyRPnfZEQuwmAy5cXAKCDO11bsbEP6vdUyeHqMe/PdMYQ 4bOTtx6vqJsUXzeKdVo9Dtgow34npBUnrgHseovl9EbA4u2sKFTzWmahc1/5gFI1tRgOQzx5bgU AruTH4B86BBjUGH4rWcXoX7LkTluj3+EKfSMq8Wqt/DqNg2ss1io7V60fneBwo5I55ibPgZQ8/n mdWX44WBvzgLTiLgkPuXP+uQ2afycTIeI6LtHliDjreMW8ggPQaXosrofPbeQMx8D61N7mkhy4q cwYkfuVZQ2rnLpSZvopXPg8UwgE164bq7mGbXkO0PaA2nuqLyx+0D07zW4nbeAkSY/400weH3mo KHGNKXofWEGyglBY+p4CyNJoat8KjjZdmdo3rXDelUotZ8Jw2QaTVoWMaurfYDQiCHwU3seRlpV /1xYElkBhYZaAGBeQ9HLj3vRwl7KXjHG8ux+HBDpVD9y1+XWcBr46T6MaHpqtIWaQYOsukxY/oA YQC656smd9Zkod7D7mTwS+0kCxu X-Received: by 2002:a05:6372:a80b:b0:3de:ab1e:a63e with SMTP id adf61e73a8af0-3e165032ef1mr7892032637.39.1791904704905; Tue, 13 Oct 2026 08:18:24 -0700 (PDT) Received: from buffalo-ssd.taila54753.ts.net ([240b:253:4760:f400:1ebf:ceff:fe7f:5e0b]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3da04596dsm5759888a12.29.2026.10.13.08.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:18:24 -0700 (PDT) From: Akari Tsuyukusa To: Brian Masney , Jerome Brunet , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Chen-Yu Tsai , Bartosz Golaszewski , Kees Cook , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Danilo Krummrich , Nicolas Frattaroli , Bjorn Helgaas , Takashi Sakamoto , Haotian Zhang , Miles Chen , Sam Shih , Daniel Golle , Chun-Jie Chen , Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), Akari Tsuyukusa , stable@vger.kernel.org Subject: [PATCH v2 05/35] clk: mediatek: mt8173: Fix memory leak on module removal Date: Wed, 14 Oct 2026 00:17:04 +0900 Message-ID: <20261013151734.3177690-6-akkun11.open@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013151734.3177690-1-akkun11.open@gmail.com> References: <20261013151734.3177690-1-akkun11.open@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261013_081825_930127_9FD9028C X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org clk-mt8173-apmixedsys.c and clk-mt8173-infracfg.c do not call platform_set_drvdata() during their driver probe callback, but their remove callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and allow module build") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa --- Changes in v2: - Capitalize the first letter of the commit message: "fix" -> "Fix" --- drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt8173-infracfg.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c index d7d416172ab3..65dc4489a09c 100644 --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c @@ -179,6 +179,8 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) if (r) goto unregister_ref2usb; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_ref2usb: diff --git a/drivers/clk/mediatek/clk-mt8173-infracfg.c b/drivers/clk/mediatek/clk-mt8173-infracfg.c index fa2d1d557e04..9b8c35897789 100644 --- a/drivers/clk/mediatek/clk-mt8173-infracfg.c +++ b/drivers/clk/mediatek/clk-mt8173-infracfg.c @@ -128,6 +128,8 @@ static int clk_mt8173_infracfg_probe(struct platform_device *pdev) if (r) goto unregister_clk_hw; + platform_set_drvdata(pdev, infra_clk_data); + return 0; unregister_clk_hw: -- 2.56.0