From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83B19CC6B1D for ; Wed, 14 Oct 2026 11:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IZOtjHH9GCgeZqSt19reIaRDRSJJcHtWmcvSjabXJDU=; b=19XQOOg6O0SFJ+8hGAi6xswkEH GU5ufGbf9Ghy11B7SIVvcdp3v4CrhJWFBS8ZTOHGYew3oQxykodSHWbblbi/VEgjAVmM8Te8E9z1g /XpwFL+3RGxttnV2Gv/TIHKdDHoZR1MuQhnvS1s2gy3CFHT9EmMNZp7va9YjY+E52fzZubHYZkV+7 R3DQfMnnzuaqGVYSoYMtP/LGkk/zext8xWKvFDVlqYwVue4r0Km7iEVcbWWeaWvhWwGjchCDWxt0R +6tkprXcoZHOou7L4aRdGWs09on5r+5TTXfWqZ3b2iTJUF/2hzHsFILwkY2n3ntuICWeEE6Szevsh DIIbdUmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGxBC-0000000FKWv-0UM3; Wed, 14 Oct 2026 11:29:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGxAd-0000000FKBU-2MVd for linux-arm-kernel@bombadil.infradead.org; Wed, 14 Oct 2026 11:29:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=IZOtjHH9GCgeZqSt19reIaRDRSJJcHtWmcvSjabXJDU=; b=V4Fd0j5+yg/flG5h1Bs3R2JV+R ETXnQVP/6gHl/jnYNI0JRFTVJkP1M56q0iMi36amZ1yQFYYXnMheVThtFbyJYY9br8tyficCmOX5/ t3Dtd6N24OGtSxHDndzBSguMKCaDYT3anmTH2jlkNiHP5tXxrajpaUmF+5HFZnLdH6Be5lzhbu5oZ CyTv/JWeb22YIyaQMas+R8RU4Hf/2sCBjHKKtGqSsjvHSW294sKhh6DGVASvYJ9hdQ7L2qrybIJ2K /NkC60XXLn7M9L15ansMx+gqiMEVwwFaM36HA/vrb0Go4HnIoW9d+LWLRRCpEiHiAlRqa/Bxrzdsh diV5NLyg==; Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by desiato.infradead.org with esmtps (Exim 4.99.5 #2 (Red Hat Linux)) id 1xGxAY-0000000GgiW-2dDk for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2026 11:29:18 +0000 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-398a5aad413so190015a91.3 for ; Wed, 14 Oct 2026 04:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791977352; x=1792582152; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IZOtjHH9GCgeZqSt19reIaRDRSJJcHtWmcvSjabXJDU=; b=Lg+cwDhQg0xwsiZaarFkGZQCx9azucAJRloqTuwE+AiaY5haUrbtZsM/e5HcYNUJ+X U1KLATapPDFt/cwSN/tu9+gBmBiSL/oF57NikC3QLUxOR7PJ+z5myM645XRZpb8RnNbm IR2oROGdQJJODfEENt7VN/gNuBqCBnBFQ7gBizFk1pmvI7nkobqfuL/ter+kVbWfSEcn Hs5SOS65coZGrprS9MhZqss6BtfqM1RGXz4AMSbKs5IAoOOwO480Rh+97TuyToTrd8yt aYwHqmbLjI9m3d2yBj6sV56u2kxW7eRKNn3JldDEND/XpnskuA9NQ1/2Wp858xwFZgp0 DArw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791977352; x=1792582152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IZOtjHH9GCgeZqSt19reIaRDRSJJcHtWmcvSjabXJDU=; b=zEsuexcXRe9l0QJE5fEtI7s2rpOdEfNgzYvryLr2KFKsqLJvyhtqt7AK0RVRD1Ggii CZq09WO67AzeuOKCQXqMiWBeAAQ3qMsgFaZwL/4/1QWT3Mj0VYraofmw7ifqPqqw5qoF 4ebzq14DuyDAA77hteHLJBR1G+q2LL/mEzIeUiHUk5I7JFEs2ovBBL6Q4KNhcDfE7dIB NQTqj99DKiHXUDKvq3FYn+YL6o6lomO1Hqf96t9r54ejQ2wRh+9Bmlv425+1+sRvmozn zuj4NhQ4XSpW5BZe2p6AkOYIwvapaLjb0gUH8rDiugtW+PQSdZlA8akwy/ApXGHXbZ5C uTfQ== X-Forwarded-Encrypted: i=1; AKwUvBwVOEdwim1D8+7nlMqM4ShAm1ThxNWNeLmyKCnq1mf4qLBwGnXF0Oyxl4zAMZy0TOc0MtO1tvHOWMaX4nHVnt94@lists.infradead.org X-Gm-Message-State: AFq9FYLvpX/xpLZhRtlTecIDVSN4V/PI430uidmu18Wa76bsufTqzcAd 3xKPkxmgEAMVDo34AeLq5KXN2dif9gGQ3y9U870DAeOu7oOwdvRVhFUX X-Gm-Gg: AYBFou2iWth/Ms8YYLq2KuOOvEUDhtZYRhaFMtisZ4dlqwDI0Fn6GfUkN6yDjwhp5zR KbpSJ+dwhyn5d10UxXW7q4tjyKJnheGuz9J2v+kdXs0CM29JAYe3YCiEDNZNXpceT/NZ5MBqQsq 6Uvqx/WniQUY/aJ1aDglf6ItYl5vb60qGjY0nJnkZNQb4pJbbIlXtS8KNrsZJGuQzGewsgjtWK8 L227E8W5M4qJfnGgMDfgOHtk811jA+zqH75oyT3mM3ELK3anr7qiGg5D2kPfovV1vJQPCvwtFuL sQj1Dq/wm0RYiD83ogmbk2e+mHdMAlsQRz8vlajcYZc7PaUJq0y9v+Xrq9kp+eZVha4lRThkQiF YhpqB9LlWCAImWsPBcAnZbBNtBRFIG7i4yVe/MjXOaWvMyvqpxfg9R0NyuWRheEsVY3+1wpfEno ugLe05LptkJbdiDwrvFNostkQy+tOITGDeiu13i+mrmRjaRgZ+6D084pgTHM7rFRwN6bTsieeUO vnwGLFbbiZFnLW2umKiTyO+PM2oMt8Kt5srVyr2k8BLR3+Y2ulZ6D6p3j5hp9o89zEledG8Hq7I z7JntRIMEOrQTQ== X-Received: by 2002:a17:90b:4ace:b0:3a8:59d3:530f with SMTP id 98e67ed59e1d1-3ab3a97a06bmr15237233a91.57.1791977352463; Wed, 14 Oct 2026 04:29:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac61171feesm4077076a91.17.2026.10.14.04.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 04:29:12 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno , Trevor Wu , Ajay Kumar Nandam Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , cassiogabrielcontato@gmail.com, Mukesh Ojha , Liviu Dudau , Haotian Zhang , HariKrishna Sagala , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 10/16] ASoC: mediatek: mt8195: Remove redundant error message Date: Wed, 14 Oct 2026 18:27:45 +0700 Message-ID: <20261014112752.683032-11-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261014112752.683032-1-phucduc.bui@gmail.com> References: <20261014112752.683032-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261014_122914_816626_71C89734 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_warn() and dev_err_probe() call is redundant and can be removed. Reviewed-by: Ajay Kumar Nandam Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c index 19047887ee21..75d4d0578bcc 100644 --- a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c +++ b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c @@ -3090,7 +3090,7 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev) /* initial audio related clock */ ret = mt8195_afe_init_clock(afe); if (ret) - return dev_err_probe(dev, ret, "init clock error\n"); + return ret; /* reset controller to reset audio regs before regmap cache */ rstc = devm_reset_control_get_exclusive(dev, "audiosys"); @@ -3137,7 +3137,7 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq_id, mt8195_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); if (ret) - return dev_err_probe(dev, ret, "could not request_irq for asys-isr\n"); + return ret; /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); @@ -3195,10 +3195,9 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev) /* register component */ ret = devm_snd_soc_register_component(dev, &mtk_afe_pcm_platform, afe->dai_drivers, afe->num_dai_drivers); - if (ret) { - dev_warn(dev, "err_platform\n"); + if (ret) goto err_pm_put; - } + ret = regmap_multi_reg_write(afe->regmap, mt8195_afe_reg_defaults, ARRAY_SIZE(mt8195_afe_reg_defaults)); -- 2.43.0