From: Krzysztof Kozlowski <krzk@kernel.org>
To: Larisa Ileana Grigore <larisa.grigore@oss.nxp.com>
Cc: NXP S32 Linux Team <s32@nxp.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@sandisk.com>,
Bart Van Assche <bvanassche@acm.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
Ajay Neeli <ajay.neeli@amd.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
Hannes Reinicke <hare@suse.de>,
Joao Pinto <Joao.Pinto@synopsys.com>,
linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, clizzi@redhat.com,
aruizrui@redhat.com, eballetb@redhat.com, echanude@redhat.com
Subject: Re: [PATCH v8 07/12] dt-bindings: ufs: Add NXP S32N79 UFS host controller
Date: Thu, 15 Oct 2026 10:44:45 +0200 [thread overview]
Message-ID: <20261015-observant-nickel-monkey-2a38b7@quoll> (raw)
In-Reply-To: <20261015-whimsical-amorphous-squid-6166c5@quoll>
On Thu, Oct 15, 2026 at 10:33:25AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Oct 14, 2026 at 04:58:30PM +0300, Larisa Ileana Grigore wrote:
> > On 10/14/2026 2:10 PM, Krzysztof Kozlowski wrote:
> > > On Tue, Oct 13, 2026 at 12:29:58PM +0200, Larisa Grigore wrote:
> > > > + clocks:
> > > > + maxItems: 1
> > > > +
> > > > + clock-names:
> > > > + items:
> > > > + - const: core
> > >
> > > I don't get why you added the clock-names.
> > >
> > Hello Krzysztof,
> >
> > The properties, `clock-names` and `operating-points-v2`, are needed to let
> > the generic UFS platform code discover and manage the controller clock.
> >
> > `ufshcd_parse_operating_points()` uses `clock-names` to create the
>
> You have only one clock, so my point is that UFS code is just poor, but
> if that's the reason to mention its name, then just say that in commit
> msg... or probably the ufs-common should be fixed.
I see now that ufs-common already requires clock-names and it's needed
for PM opp, which cannot operate on indices, so it's fine.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-15 8:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 10:29 [PATCH v8 00/12] Add S32N79RDB UFS support Larisa Grigore
2026-10-13 10:29 ` [PATCH v8 01/12] scsi: ufs: dwc: Return a negative error if the link is down Larisa Grigore
2026-10-13 10:29 ` [PATCH v8 02/12] ufs: unipro: Move Tx/Rx FSM state definitions to unipro.h Larisa Grigore
2026-10-13 10:29 ` [PATCH v8 03/12] ufs: unipro: Add TX/RX FSM state attributes Larisa Grigore
2026-10-13 10:29 ` [PATCH v8 04/12] ufs: host: Add common Hibern8 TX FSM polling helper Larisa Grigore
2026-10-13 10:29 ` [PATCH v8 05/12] scsi: ufs: Move Versal2 M-PHY CREG access helpers into ufshcd-dwc Larisa Grigore
2026-10-13 10:29 ` [PATCH v8 06/12] scsi: ufs: dwc: Export common clock divider and link status helpers Larisa Grigore
2026-10-13 10:29 ` [PATCH v8 07/12] dt-bindings: ufs: Add NXP S32N79 UFS host controller Larisa Grigore
2026-10-13 14:26 ` Frank Li
2026-10-14 11:10 ` Krzysztof Kozlowski
2026-10-14 13:58 ` Larisa Ileana Grigore
2026-10-15 8:33 ` Krzysztof Kozlowski
2026-10-15 8:44 ` Krzysztof Kozlowski [this message]
2026-10-13 10:29 ` [PATCH v8 08/12] scsi: ufs: dwc: Sort CBCRCTRL and CBREFCLKCTRL2 by offset Larisa Grigore
2026-10-13 10:30 ` [PATCH v8 09/12] scsi: ufs: Add NXP S32N79 UFS host controller driver Larisa Grigore
2026-10-13 10:30 ` [PATCH v8 10/12] arm64: dts: freescale: s32n79: Add UFS host controller Larisa Grigore
2026-10-14 11:07 ` Krzysztof Kozlowski
2026-10-14 13:59 ` Larisa Ileana Grigore
2026-10-13 10:30 ` [PATCH v8 11/12] arm64: dts: freescale: s32n79-rdb: Enable UFS Larisa Grigore
2026-10-13 10:30 ` [PATCH v8 12/12] MAINTAINERS: Add NXP S32N7 UFS host controller entry Larisa Grigore
2026-10-13 14:28 ` Frank Li
2026-10-14 13:59 ` Larisa Ileana Grigore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015-observant-nickel-monkey-2a38b7@quoll \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Joao.Pinto@synopsys.com \
--cc=ajay.neeli@amd.com \
--cc=alim.akhtar@samsung.com \
--cc=aruizrui@redhat.com \
--cc=avri.altman@sandisk.com \
--cc=bvanassche@acm.org \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=echanude@redhat.com \
--cc=festevam@gmail.com \
--cc=hare@suse.de \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=larisa.grigore@oss.nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mkp@kernel.org \
--cc=pedrom.sousa@synopsys.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=sai.krishna.potthuri@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox