From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D60EACCF2D6 for ; Mon, 19 Oct 2026 08:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nLsz7932z7XAKnP+Q9VfpNYxFLgSWJSn220mna7ZMLI=; b=iZQoUFm8dq/xds5yEoOxygXvZK x7V4LqThuPQQadPyG8jMN7/CRPqlO5Gro2diSRY1QbqtRjFGC7jzx93vIkPSmXUBOA2NPpBG1neWc p6r1NFI4cSGQLgFw1wVTcQCKnohBGs0NeKdGKchHXA2/gbClOMsxxHVxTu2yCqid2CUtRA4FYEvTO qZmTSmSotvRLCa1PEgY/V5zXJYKeK98YchYMrnHqBXMnzLtO2P5ijDgktcHx4hAvvmd3rrIGNcM0F /l540CA/uUOXYt+rgKMbMVTCPGb8JujrkLmMlZr1i0P8H4M6S745AV9jZVXSaZHNcQ++m8w+yCoVe fiZJRAbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIjDM-00000006vV6-00xI; Mon, 19 Oct 2026 08:59:28 +0000 Received: from mail-m121163.qiye.163.com ([115.236.121.163]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIjD9-00000006vEz-0eXY; Mon, 19 Oct 2026 08:59:16 +0000 Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 5189b85d8; Mon, 19 Oct 2026 16:59:02 +0800 (GMT+08:00) From: Damon Ding To: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Heiko Stuebner Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Dmitry Baryshkov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding , Sashiko Subject: [PATCH v4 02/14] drm/bridge: analogix_dp: Check all negative return values for &analogix_dp_device.irq Date: Mon, 19 Oct 2026 16:58:24 +0800 Message-Id: <20261019085836.3065008-3-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261019085836.3065008-1-damon.ding@rock-chips.com> References: <20261019085836.3065008-1-damon.ding@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0aa15362be5603a8kunm6ee755052eabf8 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlDGRkfVk1LGR0aGkMeTRhOQlYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU JDQkpVSktLVUtZBg++ DKIM-Signature: a=rsa-sha256; b=Rgy38Rxe8sSFyv4DxSF44Xrg5Put/bFOTb3fjWhyx4t/yDf3yZ1Z0EcICad4s07iVbPq+qxwT0hWkzLwNPEXmbMADS05EMN++q/d0YMesgXwQq23s3Jz3kiQf0iUQ4/jTRGiufyD5VMPbSWM4tEwKVH1ZYvHqNvfKly7nbG5DEg=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=nLsz7932z7XAKnP+Q9VfpNYxFLgSWJSn220mna7ZMLI=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261019_015915_408713_11692A0A X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently only -ENXIO is checked for dp->irq from gpiod_to_irq(), which ignores other possible error codes like -EPROBE_DEFER, -ENOENT. Check for any negative value instead, and propagate the actual error code rather than hardcoding -ENODEV. Reported-by: Sashiko Link: https://lore.kernel.org/all/20260804083307.84ECA1F000E9@smtp.kernel.org/ Tested-by: Heiko Stuebner Signed-off-by: Damon Ding --- Changes in v4: - Add Tested-by tag. --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 079f2f01f33b..27c9a764e25f 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1480,9 +1480,9 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) irq_flags = IRQF_NO_AUTOEN; } - if (dp->irq == -ENXIO) { + if (dp->irq < 0) { dev_err(&pdev->dev, "failed to get irq\n"); - return ERR_PTR(-ENODEV); + return ERR_PTR(dp->irq); } ret = devm_request_threaded_irq(&pdev->dev, dp->irq, -- 2.34.1