From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EE536079D5D for ; Mon, 19 Oct 2026 15:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CLWDMq4e; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2XU3x6L6; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4NvBHrrM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2XU3x6L6; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4NvBHrrM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ACxUqLchSDqFg79x5G7fXNVlcAc+CFu7MScJYvXaE5o=; b=CLWDMq4eO2BEaaYbwsvkgidxzE wjYk2PYYtuTfjY4dDzhGjNXNvvpDo89Dxr26n+efB1ijfxunz0/O3Z5NKZgiZh+RPLtqRdK+SOcrK oJ5EqQYj4s1/iDPOr/2XTIwxkDHhJl4YzoAB/Fj1U68BYAII+E02c+hS6RHe1407ruvEBwM3tETt8 sbrv4gWN7J5eIxNg27eqh0Fe4IxgduvxTqGo86NM/cVkK5x8jDgtsRpZ7zXjF67DUsHRvEriFavaD r5bZ1Gjrz4RbI9HfIJh3sqpACxXOWsJG3/E4T/Z1svxrUpV19Y8+SEh56G64pjhaHoAD1HlA5IBvl RBgKHiZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIpZa-00000007sQE-3jbb; Mon, 19 Oct 2026 15:46:50 +0000 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIpZX-00000007sMp-2O6S for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2026 15:46:50 +0000 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5E3CA21CE8; Mon, 19 Oct 2026 15:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792424779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACxUqLchSDqFg79x5G7fXNVlcAc+CFu7MScJYvXaE5o=; b=2XU3x6L6wBsU9NTbPA20qzM4oAIcmU1jEnkXXLxlw4eGwebjQAmogVJ3ddUNm73wyt+rks h3AxFHBGJLiXdCnCqm78+eITs8Y3N/WaNa1ZNDuE/fGgXmVRMo9unazeLPWLE5OKFt2gY3 i8YTNDN8SdRqVVNmYrC0VYpYepfKX8c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792424779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACxUqLchSDqFg79x5G7fXNVlcAc+CFu7MScJYvXaE5o=; b=4NvBHrrMFq6p1xAns53IfLiWRU4tZ0BqyrsNX1ZJfrmAOkcHHKHkBDktCj2h/38qqdziLv l7vtaRVWuMNQIrBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792424779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACxUqLchSDqFg79x5G7fXNVlcAc+CFu7MScJYvXaE5o=; b=2XU3x6L6wBsU9NTbPA20qzM4oAIcmU1jEnkXXLxlw4eGwebjQAmogVJ3ddUNm73wyt+rks h3AxFHBGJLiXdCnCqm78+eITs8Y3N/WaNa1ZNDuE/fGgXmVRMo9unazeLPWLE5OKFt2gY3 i8YTNDN8SdRqVVNmYrC0VYpYepfKX8c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792424779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACxUqLchSDqFg79x5G7fXNVlcAc+CFu7MScJYvXaE5o=; b=4NvBHrrMFq6p1xAns53IfLiWRU4tZ0BqyrsNX1ZJfrmAOkcHHKHkBDktCj2h/38qqdziLv l7vtaRVWuMNQIrBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DBDAA137D4; Mon, 19 Oct 2026 15:46:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gYPgBkk71mrrPAAAD6G6ig:T5 (envelope-from ); Mon, 19 Oct 2026 15:46:18 +0000 From: Thomas Zimmermann To: jfalempe@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, nouveau@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, virtualization@lists.linux.dev, sashiko-reviews@lists.linux.dev, Thomas Zimmermann Subject: [PATCH 4/4] drm/pixel: Link draw helpers into drm_pixel_helper.ko Date: Mon, 19 Oct 2026 17:32:45 +0200 Message-ID: <20261019154612.777074-5-tzimmermann@suse.de> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261019154612.777074-1-tzimmermann@suse.de> References: <20261019154612.777074-1-tzimmermann@suse.de> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -6.80 X-Spam-Level: X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLqirfcw6gnbcr9a9yhi49fhi6)]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261019_084648_006217_CD22F915 X-CRM114-Status: GOOD ( 14.16 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_ZEN_BLOCKED_OPENDNS, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Move drm_draw.o from the DRM core to drm_pixel_helper.ko. Remove the Kconfig option DRM_DRAW and provide the draw helpers unconditionally. Having draw code in the DRM core is a left-over fro when panic handling was entirely located in the DRM core as well. With all the panic drawing in drm_pixel_helper.ko, the drawing helpers can go there as well. DRM's log clients also uses the drawing helpers for output. Update the Kconfig rules to select DRM_PIXEL_HELPER instead of DRM_DRAW for this client. The format and the draw helpers share the per-pixel color-format code from drm_format_internal. Putting it all into one place will hopefully help with sharing more code in the future. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 5 ----- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/clients/Kconfig | 2 +- drivers/gpu/drm/{drm_draw.c => drm_draw_helper.c} | 0 4 files changed, 2 insertions(+), 7 deletions(-) rename drivers/gpu/drm/{drm_draw.c => drm_draw_helper.c} (100%) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index bf7c59944340..1b16e6101a53 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -52,15 +52,10 @@ config DRM_KMS_HELPER config DRM_PIXEL_HELPER tristate depends on DRM - select DRM_DRAW if DRM_PANIC select FONT_SUPPORT if DRM_PANIC help Helpers for working with pixel data in DRM. -config DRM_DRAW - bool - depends on DRM - config DRM_PANIC bool "Display a user-friendly message when a kernel panic occurs" depends on DRM && PRINTK diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 18a5a5baf029..ab9eb4c21264 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -91,7 +91,6 @@ drm-$(CONFIG_DRM_PRIVACY_SCREEN) += \ drm_privacy_screen_x86.o drm-$(CONFIG_DRM_ACCEL) += ../../accel/drm_accel.o drm-$(CONFIG_DRM_PANIC) += drm_panic.o -drm-$(CONFIG_DRM_DRAW) += drm_draw.o drm-$(CONFIG_DRM_RAS) += drm_ras.o drm_ras_nl.o drm_ras_genl_family.o obj-$(CONFIG_DRM) += drm.o @@ -100,6 +99,7 @@ obj-$(CONFIG_DRM_PANEL_ORIENTATION_QUIRKS) += drm_panel_orientation_quirks.o obj-$(CONFIG_DRM_PANEL_BACKLIGHT_QUIRKS) += drm_panel_backlight_quirks.o drm_pixel_helper-y := \ + drm_draw_helper.o \ drm_format_helper.o \ drm_pixel_helper_common.o drm_pixel_helper-$(CONFIG_DRM_PANIC) += drm_panic_helper.o diff --git a/drivers/gpu/drm/clients/Kconfig b/drivers/gpu/drm/clients/Kconfig index 6096c623d9d5..8d21edc4cc5b 100644 --- a/drivers/gpu/drm/clients/Kconfig +++ b/drivers/gpu/drm/clients/Kconfig @@ -3,6 +3,7 @@ config DRM_CLIENT_LIB tristate depends on DRM + select DRM_PIXEL_HELPER if DRM_CLIENT_LOG select DRM_KMS_HELPER if DRM_FBDEV_EMULATION select FB_CORE if DRM_FBDEV_EMULATION help @@ -76,7 +77,6 @@ config DRM_CLIENT_LOG depends on DRM_CLIENT_SELECTION select DRM_CLIENT select DRM_CLIENT_SETUP - select DRM_DRAW select FONT_SUPPORT help This enable a drm logger, that will print the kernel messages to the diff --git a/drivers/gpu/drm/drm_draw.c b/drivers/gpu/drm/drm_draw_helper.c similarity index 100% rename from drivers/gpu/drm/drm_draw.c rename to drivers/gpu/drm/drm_draw_helper.c -- 2.56.0