From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B5EF606C203 for ; Tue, 20 Oct 2026 03:10:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1UZPDDjU; dkim=pass (1024-bit key, unprotected) header.d=rock-chips.com header.i=@rock-chips.com header.a=rsa-sha256 header.s=default header.b=L0GRG5h6 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PIme3hcZlC53RfvT2IEjzq2swieDeYbsRW7Jr3b/EnY=; b=1UZPDDjU3rsQYwRCr79O/waQD1 UXIr8uDO88Gf6oinkjkHCGOtruhDK0iTYVIkIT5HKyPAx63u4xpEenF9dEIuhpThAtmca5J+Xh5rn S3YiBFbG/DNxIvJJFyblmOT29PTW+W3mQ6fAGErkhn+fSl3i3C6aat1Q0PrIHyBRtoph9ZO9yRgPw bHJrcdTel/9CEBtT4MBfMPfRNnDYdTTrkcDm7YXCgkZa45Q3ObGAs0swUGJFoTkb5v19tf8Pu61xB E9nhEjp9syKKDzAvm62RQuQ401LYIM10kYq/+f5fO0e7QBOamOjwUMmRrvA1+tTQL/DRQNk6JC5/z EnP7MEiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ0EY-00000008lQZ-2kNM; Tue, 20 Oct 2026 03:09:50 +0000 Received: from mail-m82219.xmail.ntesmail.com ([156.224.82.219]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ0EN-00000008lEp-0ogo; Tue, 20 Oct 2026 03:09:42 +0000 Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 51a4ceebc; Tue, 20 Oct 2026 11:09:33 +0800 (GMT+08:00) From: Damon Ding To: Sandy Huang , Heiko Stuebner , Andy Yan , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Andrzej Hajda , Robert Foss Cc: Neil Armstrong , Manivannan Sadhasivam , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Dave Jones , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Damon Ding Subject: [PATCH v3 5/6] drm/rockchip: analogix_dp: Add support for RK3568 Date: Tue, 20 Oct 2026 11:09:15 +0800 Message-Id: <20261020030916.3223833-6-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261020030916.3223833-1-damon.ding@rock-chips.com> References: <20261020030916.3223833-1-damon.ding@rock-chips.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0aa15749229303a8kunmfd20f05334c78f X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkaTkpJVkwaTx9JGhlOQ0tJT1YVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSE pKQk1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=L0GRG5h6UBqPdZoOzncwl9bjfmfKLEpR1+D+v0ATg2rRCRzOYAsoMajwTwPFcDze9GhuUM8Cfm3eVmf/8jkO0WdlJTL/KbOZVUkRxJZVN7GHDvUcSnacoAgcs6xPEvd6+70VvHa7gY1RKFmKhEJhy9fZyT+2nED3ieHLyNipHs0=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=PIme3hcZlC53RfvT2IEjzq2swieDeYbsRW7Jr3b/EnY=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261019_200941_197236_A05EF541 X-CRM114-Status: GOOD ( 14.84 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The RK3568 eDP controller does not require any GRF configurations, so make the "rockchip,grf" property optional. Also enable the optional avdd-0v9 and avdd-1v8 supplies which power the eDP PHY. Add the "rockchip,rk3568-edp" compatible along with its chip data; the register base in the chip data is used to match the platform device memory resource. Signed-off-by: Damon Ding --- Changes in v2: - Fail the probe when the chip data requires GRF configurations while the "rockchip,grf" property is missing.(Sashiko) --- .../gpu/drm/rockchip/analogix_dp-rockchip.c | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index ccdd4b9ecdb8..38c78360842f 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -320,12 +320,17 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp) struct device *dev = dp->dev; struct device_node *np = dev->of_node; struct clk *clk; + int ret; - dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf"); + dp->grf = syscon_regmap_lookup_by_phandle_optional(np, "rockchip,grf"); if (IS_ERR(dp->grf)) return dev_err_probe(dev, PTR_ERR(dp->grf), "failed to get rockchip,grf property\n"); + if (!dp->grf && (dp->data->lcdc_sel.valid || dp->data->edp_mode.valid)) + return dev_err_probe(dev, -EINVAL, + "missing the required rockchip,grf property\n"); + dp->grfclk = devm_clk_get_optional(dev, "grf"); if (IS_ERR(dp->grfclk)) return dev_err_probe(dev, PTR_ERR(dp->grfclk), @@ -351,6 +356,14 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp) return dev_err_probe(dev, PTR_ERR(dp->apbrst), "failed to get apb reset control\n"); + ret = devm_regulator_get_enable_optional(dev, "avdd-0v9"); + if (ret && ret != -ENODEV) + return dev_err_probe(dev, ret, "failed to enable avdd-0v9\n"); + + ret = devm_regulator_get_enable_optional(dev, "avdd-1v8"); + if (ret && ret != -ENODEV) + return dev_err_probe(dev, ret, "failed to enable avdd-1v8\n"); + return 0; } @@ -530,6 +543,14 @@ static const struct rockchip_dp_chip_data rk3288_dp[] = { { /* sentinel */ } }; +static const struct rockchip_dp_chip_data rk3568_edp[] = { + { + .chip_type = RK3568_EDP, + .reg = 0xfe0c0000, + }, + { /* sentinel */ } +}; + static const struct rockchip_dp_chip_data rk3576_edp[] = { { .chip_type = RK3576_EDP, @@ -555,6 +576,7 @@ static const struct rockchip_dp_chip_data rk3588_edp[] = { static const struct of_device_id rockchip_dp_dt_ids[] = { {.compatible = "rockchip,rk3288-dp", .data = &rk3288_dp }, {.compatible = "rockchip,rk3399-edp", .data = &rk3399_edp }, + {.compatible = "rockchip,rk3568-edp", .data = &rk3568_edp }, {.compatible = "rockchip,rk3576-edp", .data = &rk3576_edp }, {.compatible = "rockchip,rk3588-edp", .data = &rk3588_edp }, {} -- 2.34.1