From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF2ED606A321 for ; Wed, 21 Oct 2026 16:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QTtAmYRm; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ppsqazaf; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Zj+APSth DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xpcFx5Tgg5MtNBAEwITPf99dESr1dNj5mhlvVGEZ9HE=; b=QTtAmYRmogGv+plJPMEvW/WkRM QVaN7VsWoW9rNZHGjdR3ZYlaNlHJzMcmQ+Cd2ZFbM5CNvLdeqIs9soJkXqDGq1kBYY7rVEWALcpwm DqjMNPqi2VruZIZOtPawxyU3onf6qM777KLi6EZ132yF1RByme++m+pHIff40ZwqKljAq6vHaayNl PqKue8YrOL6fMYsa114WZeo9W/0TjMht58y30UpjA4UiA1ELwlaBjVs4dxtm7V0f9V0mcuswn2vOc VJHVHK/UMnTasgakJYRwmpIk9l9Mz59GhIP+QSSyNh64x+Xi9D+ZVf8b6DAo7Ko2KhhDdz9SVa/BT H+YYu7kA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJYrm-0000000CLaa-3Hi1; Wed, 21 Oct 2026 16:08:38 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJYrk-0000000CLZj-0WB5 for linux-arm-kernel@lists.infradead.org; Wed, 21 Oct 2026 16:08:37 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69LFTxWm1045488 for ; Wed, 21 Oct 2026 16:08:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xpcFx5Tgg5MtNBAEwITPf99dESr1dNj5mhlvVGEZ9HE=; b=ppsqazaf3z/Ovnn1 SzWOwFC6FBH4fWPIj1FFpw1+MfbxoKTpq3L+dL3Z+e3w7356YZ6RysSOxUSlT+jE QJ63VeLe4fC9YoZU8/wWjZGfXODKSBwllcZGiYbUnENdNs5V4JoZtOO0xT0uHd/I xWphiIy5SHHmhNox7zwzrK2Vqs+UWLy3gU0nXuyduCWSyhwAtJrrWHEuN+VRgTMm hlzoca2KU2LPeFWWVXhGFOSPOe97rBtnG8yGmM71Gq6BNVbN2C1Iwmwrje5lGBva VCVasiUkD3EzsCgdmldMxwRAjdIFHG23zVG5vKxeMRaRrlso7XF2npL2q3GBF2Sc GdYlJQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hetj49mwf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 21 Oct 2026 16:08:35 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8a0688a43d3so686695b3a.0 for ; Wed, 21 Oct 2026 09:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792598915; x=1793203715; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=xpcFx5Tgg5MtNBAEwITPf99dESr1dNj5mhlvVGEZ9HE=; b=Zj+APSthLYvBEQq+FpUBl8LEe58GcixZ8SXmDtPsnSzBmuBbP0Gy+q9BT0M72btEW5 GmrrcU+5rISwa6p2LAp0F15gZRavh3cmkYEniyWkgpjqduXb4Pf4tmjEPaSCS1f+Vr3z gs5u3GA03343425IYihj1p5Kfz+DJXXdOMh+g3qA73uZEZJFisGFhq8Kjfb+vJ5coeMz piR1Bm9nFcg3IenQTFO1al28guwy3cvZpQqF+LzhEI4OZnwkeuAbz3fI7FWM1E0Wczw0 743i6Li4RZe2A8PMJbThLVzsicHEzL5MfJImmHSiOaKZEIFiowrs8NNgs2uCC2vayzAQ SIUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792598915; x=1793203715; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xpcFx5Tgg5MtNBAEwITPf99dESr1dNj5mhlvVGEZ9HE=; b=zDavNwvF3fYZmKJuoASmIaJPSTAXe2SBKBe3jDTGEbfBJcsVPqS5ZdNJvrcIkqVrkh SamK+X8VQ01yAX9kAW/czbCs4DmicWTyFc5MlR846Rrb0viBhQWJa/59HLb1RtTw1XvL WuIX6/i1Bs3tLkgQelIaKTz4KO7csIsH9ibGKF6qu4UmqSU8L0xBYUar5/7kWsRZbpEL YQRW8iVfVPZfT1bI+LzggiCxEIX/4bEHV7FkpUdPxYcbOcs0ZEIZzp/h/jNvVgCLmfNQ hdEXV5psAara+dk0lTqtOCYvSTjS+lG259CIC6Gv8681GNCDAJY2rJevyDCxaKbOL189 bbGQ== X-Forwarded-Encrypted: i=1; AKwUvByDz61S6P3QIno4PQlOTQl1N1/n+4nxUMUj6kJoDdnbR3CoaLAUt7VBIxk/djcSCUxELYE8oLXl8KZlVtgPKE5P@lists.infradead.org X-Gm-Message-State: AFq9FYJMcvt7JSLZsTCrvNq82JOGGjltWFzFfCD1kk8CMAiEbRUh4gyE 7VQf+tr1OZ9Kw1MXpzvwOQ9pxUIPLE5uFBlG+cAOhGXOOeyhseAbNWRKQciQcCam4fUVDTX4l1W dMR7/P9Fey4VKB/haDaaxJZNgw0PkD4zoyCKViIyUg1jk5ClPehJLM2+tUWEyBCQ19i1dSBUC1G 0QYg== X-Gm-Gg: AYBFou0hzy1nvtcdBPxLBx9ZmQvQ8wIE6JrPFYKOvkXqAaNCzhbe/STMKcyYbP2Qb8g nFBeQmApLonUwF+zFahVz5dhEFf/dFFtiVRgGj+t3CW/9eoOU9VJgDsm93Kve1f5sxSndgUtit/ mW1224JJPSI4hy/ytuKC68ea5oyczJ5aRP+AfSLGCrioUhTSl/CI2ZZF77GJDekW8EcXn+rMSA5 B9KF0pFCcB9vt2THaqL8PXqoIp6NZK0YFmdOfwDCHoFxiwItUSOluKFSdnN5zFfW53VYlZY4Y32 XMxkDkaEgLetroBh7Vj7ts8n3WkRcs3HB96s/SpH3rKTzxfaGMpzAJZ2gxlvfcXcTzDU0Xr6fBR qULfc/94pGo38XHrvq58MdVeUvBqrrwqYcga+nodPFg== X-Received: by 2002:a05:6a21:3288:b0:3e2:2b76:bf23 with SMTP id adf61e73a8af0-3e287eda189mr2084252637.68.1792598914748; Wed, 21 Oct 2026 09:08:34 -0700 (PDT) X-Received: by 2002:a05:6a21:3288:b0:3e2:2b76:bf23 with SMTP id adf61e73a8af0-3e287eda189mr2084221637.68.1792598914240; Wed, 21 Oct 2026 09:08:34 -0700 (PDT) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd6b861c7dfsm188964a12.25.2026.10.21.09.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2026 09:08:33 -0700 (PDT) Date: Wed, 21 Oct 2026 09:08:27 -0700 From: Jonathan Cameron To: Jason Gunthorpe Cc: Alexandre Ghiti , Albert Ou , Ard Biesheuvel , Arnd Bergmann , Catalin Marinas , Jonathan Corbet , David Sterba , Ilias Apalodimas , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Rutland , Palmer Dabbelt , Paul Walmsley , Randy Dunlap , Simon Glass , Shuah Khan , Nick Terrell , Will Deacon , Alexandre Ghiti , Conor Dooley , linux-integrity@vger.kernel.org, Palmer Dabbelt , patches@lists.linux.dev, Piotr =?ISO-8859-1?Q?Kr=F3l?= , Ross Philipson , Sami Tolvanen , Song Shuai Subject: Re: [PATCH v2 03/15] efi/libstub: Free cmdline_ptr in efi_pe_entry Message-ID: <20261021090827.000078b8@oss.qualcomm.com> In-Reply-To: <3-v2-989a18390eb1+486-arm64_drtm_jgg@nvidia.com> References: <0-v2-989a18390eb1+486-arm64_drtm_jgg@nvidia.com> <3-v2-989a18390eb1+486-arm64_drtm_jgg@nvidia.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: LXyIKyfq2hDnyO4JuLaP8VrBQHO27_oA X-Proofpoint-GUID: LXyIKyfq2hDnyO4JuLaP8VrBQHO27_oA X-Authority-Analysis: v=2.4 cv=N768hG9B c=1 sm=1 tr=0 ts=6ad8e383 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=Ikd4Dj_1AAAA:8 a=EUspDBNiAAAA:8 a=gCM90IwNaqpJe8xd-nwA:9 a=CjuIK1q_8ugA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIxMDA2NCBTYWx0ZWRfX+6UGQFJsnFOX M61rBga3KTF+CW9Bb169kQutpJPA/a0sKxLDIl2JKi1ZJizro6JTxhr4GIFtMX4allvE3Ke9WAO yFIKncPw/kh3V12tHYET8FxSj2BGwOhkt+yJNKVfXoK8i/n3RxKsvZypTRiP/xZCcSvIXECV47E pmYpYJdeVJeHpfMi1QvrWK8LIgatvolUZhtlzHxrGZvYUvYWU++3TfxvyBT15Z/QXZ1Tsq9+k1h YrwtY62qrJlh52OPz/B3lUzyqruu5X+lCaIdPRYOeysep6snJb/EwZ29uaBqmz3HC1AgETA07TE bSFFFHpkyQ045oCgQnyOlrXvmz1aByM5VxtV3ktSSV657jMl8vpLiNt2b5a42K2D0rKUPqaHdlq s6o4Y4c70MR576eRS4EDZDMW6zoyis3Cv72Q3HNG9OfpsaNHw7bPgv11Tc5KzQvsR1C6+tm+EtI 9vfRpvt5LpyLZBaPqUg== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIxMDA2NCBTYWx0ZWRfXwsDgdxtHBj76 6Kb7ckvX/nqxMVkNmiaGs98ncYFRlNRPrmQZPIUP56ZS5YT3xO+lzVx5FJJyJX1FLPeTxw/xHo4 RAf4ekjW/NuSEG5Xo/buYuyaJS2D5rc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-21_04,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610210064 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261021_090836_172167_1FE9AFE9 X-CRM114-Status: GOOD ( 21.44 ) X-Spam-Score: -2.8 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, 2 Oct 2026 20:31:40 -0300 Jason Gunthorpe wrote: > Sashiko points out that efi_handle_cmdline() allocates this memory and > hands it over to the caller. If efi_pe_entry() ever returns it should be > freed. Add a __free annotation. > > Fixes: 42c8ea3dca09 ("efi: libstub: Factor out EFI stub entrypoint into separate file") > Signed-off-by: Jason Gunthorpe Seems sensible. If anyone has more time than either of us, I note the efi_handle_cmdline() use of __free() should move down to the point of allocation. It's only a couple of lines, but none the less... Reviewed-by: Jonathan Cameron > --- > drivers/firmware/efi/libstub/efi-stub-entry.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/libstub/efi-stub-entry.c b/drivers/firmware/efi/libstub/efi-stub-entry.c > index aa85e910fe595e..fc1282fb442e71 100644 > --- a/drivers/firmware/efi/libstub/efi-stub-entry.c > +++ b/drivers/firmware/efi/libstub/efi-stub-entry.c > @@ -40,7 +40,6 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle, > unsigned long image_addr; > unsigned long image_size = 0; > /* addr/point and size pairs for memory management*/ > - char *cmdline_ptr = NULL; > efi_guid_t loaded_image_proto = LOADED_IMAGE_PROTOCOL_GUID; > unsigned long reserve_addr = 0; > unsigned long reserve_size = 0; > @@ -63,6 +62,7 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle, > return status; > } > > + char *cmdline_ptr __free(efi_pool) = NULL; > status = efi_handle_cmdline(image, &cmdline_ptr); > if (status != EFI_SUCCESS) > return status;