From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC128606A319 for ; Thu, 22 Oct 2026 21:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ufbqv3/G; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=DSlGka5V DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=VnX/SJ/TUUJ6Boa3Yc8krurLw5MGewq6ClqgjuG4laY=; b=Ufbqv3/GttDVby WWVqVBZau1pLPPDqttS7gQNovrNnpFYO4kccgVmlrvIk5EbV8YY0PY3xF1NzeILgVFQMyFccfR87B RaI6of36atX4B3Z4FyCKIDW2jjGBjNZYW0TZjY7MOpaP3VYJk9jQMc7EDrkRIiHOm0+PlNhum8onO yIOrlOfKeut6Q3ACcA24zbMy5PDYds2rwjws9YmKzsoBnbPz6u9ZMDE2k0kZ5GV1HuDh24ojGkHu3 ykAqyKBNTqHhyUY07tnKyclXfe8Ud7cuEIctaDY5Baqp+BmwJwx4QpYQqYDprCuqNxnroni7wayP5 dzB7wQOFA62UWDShEzzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xJzwO-0000000EygC-3FIR; Thu, 22 Oct 2026 21:03:12 +0000 Received: from mail-ua1-x92f.google.com ([2607:f8b0:4864:20::92f]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xJzwM-0000000EyfZ-2QXo for linux-arm-kernel@lists.infradead.org; Thu, 22 Oct 2026 21:03:11 +0000 Received: by mail-ua1-x92f.google.com with SMTP id a1e0cc1a2514c-980c4f5c921so145680241.2 for ; Thu, 22 Oct 2026 14:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792702989; x=1793307789; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VnX/SJ/TUUJ6Boa3Yc8krurLw5MGewq6ClqgjuG4laY=; b=DSlGka5VpCuxFoBg31IVWMgZAL+kdk1D4s9SPqkH0xXsQ4NQ58VsocHbE7T0d0Lymx RXGT/Q/ctkZx0Y2w5iS3vmwwA/wd9soXdjTrDSALoCpfMYqQUzqbV9RcfjPfCzB6F5IC AnTb8JVBvnxjDAWdwoo2MM7pnJHr2udn4eQpMOiQpST8xxZak2Stc0DY6tB1FirJfS40 2w+N7O1SStskE/eF/ZdG55FTBxA3ku5BOVuepSygUBtyWkEMrSPYQv2IAvEGvNrWsKfz G4YGBKUekGazwB6atDCUI+W4vKxMJ1zlPQ0gHTvBsls5FyVB+7seGuICSx6uP1TE1EZv LbKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792702989; x=1793307789; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VnX/SJ/TUUJ6Boa3Yc8krurLw5MGewq6ClqgjuG4laY=; b=1iPutWdaDjpPr0PDOao0oUeIO+0DCSO5ymm+q2tKjmKf6R7ZGta9eramd2P3jHXxVE HLyPCz1WYp2iR/8n/Lyb1HQbTSVLY9df/z55HV1HCiJB3r2hS2Mk97oGjH7J8O/2GBDK fr6AHsZjzHFlAc+sgiUWQC4kGAWgDtSzdlwa1FbkPSCFhsNxQMPaGfhDEnhdWoLYUR5y FwKFwRqvMONj+S4teCQOULHbCTfNnVBNMIMF9md6Cqoh7K1gL4fnQ7dLtTiYwyv6dy/G fexvkp/X+bs7/hmBwdUiWeVRnKvb0VcEc9kBUsoPV/MLmMnZZfxetZcm/3NQeCGPGp6E RCmw== X-Forwarded-Encrypted: i=1; AKwUvByF4f/SgvvSelXfdFd2A4KM1kX0KCvLJw+tTNWOKnF5udNuqGf9b0iavHttfKhEiiVAxG/HwIg32RidihfL8Xqx@lists.infradead.org X-Gm-Message-State: AFq9FYKAlI90CtK1Tm5c3/5R0UzvE5K/s9ubVY0uk9O98+WLRN2KWdd9 UZNVwJYuhI+YpI5epf0jwTTLVOSbtce6qcvEX0qYRGJ/7jQ3SpSYYFB7 X-Gm-Gg: AYBFou2q4ZTNvAL3ir1MdhGY/oDufomjTQsvnGuKF9+2HxQqAY/4Or0em4luG/QPxG7 jMeRtL1OxRc43W23p3M++eb8pd2UhpD8pQdK/zE8PW7hxZM4FYY8CQG/06PwR7d194KBDf5jenu NEF/KGdXU69eCNJTqgCG8pVWRnALS9CJ4ckGNVybKI0tswRpWqpFuhthc/VAalMsAK7OU4XG3Ly ViYNuUi+74fOSVsulFJF4mtk/DMyzFCxKOTJs6ZpZH83lY5kfrCeHbnnYHsLx9MlVrhxRXIwxGV mOv6fdDNSUuYJ9tP4WJXDYv8YsbD6ngN3zWrf3shcTHGMo9Afe1wlyO9gAUxUp9XTMVqProA0aS 3LWpZXy+DS/VIdJTh+Qz3zPfnlWB54NMXWZpz72lSWmE4tVTAzIoS52wOBnhsL7e0C1NdFLd0pr i/JveVy/3WTECu+KBZgir3MRjIB7TesVbFy78iggwaV3sNkHBDdeRVOaB4FFaKjc/LyNM6JMlmV JUvlfcxkxApoo+4tc5zk/sZ+MJoPcnMT4Fu0YfuprH6LK2nyxYp2TSJSmmklvgeqVuEMlhvB8NG 6kpt74INs6DYRDgFy7p7 X-Received: by 2002:a05:6102:5048:b0:7cc:9d46:ac88 with SMTP id ada2fe7eead31-7ccc324e368mr293096137.18.1792702989019; Thu, 22 Oct 2026 14:03:09 -0700 (PDT) Received: from Biostar-A520MT ([187.94.15.233]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9910160bad4sm527066241.1.2026.10.22.14.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 14:03:08 -0700 (PDT) From: Breno Rodrigues Alves To: linux@armlinux.org.uk Cc: Bart Van Assche , James.Bottomley@HansenPartnership.com, mkp@kernel.org, linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Breno Rodrigues Alves Subject: [PATCH v4] scsi: arm: Convert acornscsi-io.S to C Date: Thu, 22 Oct 2026 18:02:52 -0300 Message-ID: <20261022210252.80844-1-breno3011alves@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261022183658.58090-1-breno3011alves@gmail.com> References: <20261022183658.58090-1-breno3011alves@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261022_140310_645994_BE2F3A2D X-CRM114-Status: GOOD ( 27.60 ) X-Spam-Score: 1.2 (+) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The Acorn SCSI expansion card presents each 16-bit SCSI data halfword on the low half of a 32-bit card access. The hand-written assembly in acornscsi-io.S implements the two directions of the data path: - __acornscsi_in() : packs pairs of 16-bit card reads into 32-bit memory words - __acornscsi_out() : expands 16-bit memory halfwords into 32-bit card writes (duplicating the halfword in both halves for the bulk of the transfer) Both routines are simple pointer walks that a modern compiler handles just as well as hand-written assembly, so replace the .S file with an equivalent C implementation. The C version takes its arguments as (void __iomem *, char *, int), matching the prototype actually used by acornscsi.c. The assembly version had no C prototype, so the original comment declaring the first argument as unsigned int was never enforced; using the caller's type removes that latent inconsistency and lets the MMIO accessors do the right thing on any architecture. The 16-, 8- and 4-byte unrolled bodies from the assembly are folded into a single 4-byte loop per direction and expressed with put_unaligned_le32() / get_unaligned_le32(), which the compiler unrolls exactly as before. The LE variants are used because the assembly performed a plain 32-bit store on little-endian ARM, which emits bytes in little-endian order and is what the SCSI payload expects. Note on odd transfer lengths: the original assembly dropped the final odd byte when the tail reached the two-byte handler, leaving the byte unwritten (out) or unread (in). The C version advances the MMIO pointer by a full 32-bit card word in the trailing loop, so the remaining odd byte is transferred through the low half of the next card word, which is where the hardware actually samples it. Callers in acornscsi.c pass even lengths in practice, so this is a latent-bug fix, not a behaviour change that affects existing systems. No Makefile change is required: acornscsi_mod-objs already lists acornscsi-io.o, and the build system will pick up the new .c file in preference to the removed .S file. Signed-off-by: Breno Rodrigues Alves --- drivers/scsi/arm/acornscsi-io.S | 135 -------------------------------- drivers/scsi/arm/acornscsi-io.c | 105 +++++++++++++++++++++++++ drivers/scsi/arm/acornscsi-io.h | 14 ++++ drivers/scsi/arm/acornscsi.c | 4 +- 4 files changed, 121 insertions(+), 137 deletions(-) delete mode 100644 drivers/scsi/arm/acornscsi-io.S create mode 100644 drivers/scsi/arm/acornscsi-io.c create mode 100644 drivers/scsi/arm/acornscsi-io.h diff --git a/drivers/scsi/arm/acornscsi-io.S b/drivers/scsi/arm/acornscsi-io.S deleted file mode 100644 index fdd7237bb..000000000 --- a/drivers/scsi/arm/acornscsi-io.S +++ /dev/null @@ -1,135 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * linux/drivers/acorn/scsi/acornscsi-io.S: Acorn SCSI card IO - */ -#include - -#include -#include - -#if defined(__APCS_32__) -#define LOADREGS(t,r,l...) ldm##t r, l -#elif defined(__APCS_26__) -#define LOADREGS(t,r,l...) ldm##t r, l##^ -#endif - -@ Purpose: transfer a block of data from the acorn scsi card to memory -@ Proto : void acornscsi_in(unsigned int addr_start, char *buffer, int length) -@ Returns: nothing - - .align -ENTRY(__acornscsi_in) - stmfd sp!, {r4 - r7, lr} - bic r0, r0, #3 - mov lr, #0xff - orr lr, lr, #0xff00 -acornscsi_in16lp: - subs r2, r2, #16 - bmi acornscsi_in8 - ldmia r0!, {r3, r4, r5, r6} - and r3, r3, lr - orr r3, r3, r4, lsl #16 - and r4, r5, lr - orr r4, r4, r6, lsl #16 - ldmia r0!, {r5, r6, r7, ip} - and r5, r5, lr - orr r5, r5, r6, lsl #16 - and r6, r7, lr - orr r6, r6, ip, lsl #16 - stmia r1!, {r3 - r6} - bne acornscsi_in16lp - LOADREGS(fd, sp!, {r4 - r7, pc}) - -acornscsi_in8: adds r2, r2, #8 - bmi acornscsi_in4 - ldmia r0!, {r3, r4, r5, r6} - and r3, r3, lr - orr r3, r3, r4, lsl #16 - and r4, r5, lr - orr r4, r4, r6, lsl #16 - stmia r1!, {r3 - r4} - LOADREGS(eqfd, sp!, {r4 - r7, pc}) - sub r2, r2, #8 - -acornscsi_in4: adds r2, r2, #4 - bmi acornscsi_in2 - ldmia r0!, {r3, r4} - and r3, r3, lr - orr r3, r3, r4, lsl #16 - str r3, [r1], #4 - LOADREGS(eqfd, sp!, {r4 - r7, pc}) - sub r2, r2, #4 - -acornscsi_in2: adds r2, r2, #2 - ldr r3, [r0], #4 - and r3, r3, lr - strb r3, [r1], #1 - mov r3, r3, lsr #8 - strplb r3, [r1], #1 - LOADREGS(fd, sp!, {r4 - r7, pc}) - -@ Purpose: transfer a block of data from memory to the acorn scsi card -@ Proto : void acornscsi_in(unsigned int addr_start, char *buffer, int length) -@ Returns: nothing - -ENTRY(__acornscsi_out) - stmfd sp!, {r4 - r6, lr} - bic r0, r0, #3 -acornscsi_out16lp: - subs r2, r2, #16 - bmi acornscsi_out8 - ldmia r1!, {r4, r6, ip, lr} - mov r3, r4, lsl #16 - orr r3, r3, r3, lsr #16 - mov r4, r4, lsr #16 - orr r4, r4, r4, lsl #16 - mov r5, r6, lsl #16 - orr r5, r5, r5, lsr #16 - mov r6, r6, lsr #16 - orr r6, r6, r6, lsl #16 - stmia r0!, {r3, r4, r5, r6} - mov r3, ip, lsl #16 - orr r3, r3, r3, lsr #16 - mov r4, ip, lsr #16 - orr r4, r4, r4, lsl #16 - mov ip, lr, lsl #16 - orr ip, ip, ip, lsr #16 - mov lr, lr, lsr #16 - orr lr, lr, lr, lsl #16 - stmia r0!, {r3, r4, ip, lr} - bne acornscsi_out16lp - LOADREGS(fd, sp!, {r4 - r6, pc}) - -acornscsi_out8: adds r2, r2, #8 - bmi acornscsi_out4 - ldmia r1!, {r4, r6} - mov r3, r4, lsl #16 - orr r3, r3, r3, lsr #16 - mov r4, r4, lsr #16 - orr r4, r4, r4, lsl #16 - mov r5, r6, lsl #16 - orr r5, r5, r5, lsr #16 - mov r6, r6, lsr #16 - orr r6, r6, r6, lsl #16 - stmia r0!, {r3, r4, r5, r6} - LOADREGS(eqfd, sp!, {r4 - r6, pc}) - - sub r2, r2, #8 -acornscsi_out4: adds r2, r2, #4 - bmi acornscsi_out2 - ldr r4, [r1], #4 - mov r3, r4, lsl #16 - orr r3, r3, r3, lsr #16 - mov r4, r4, lsr #16 - orr r4, r4, r4, lsl #16 - stmia r0!, {r3, r4} - LOADREGS(eqfd, sp!, {r4 - r6, pc}) - - sub r2, r2, #4 -acornscsi_out2: adds r2, r2, #2 - ldr r3, [r1], #2 - strb r3, [r0], #1 - mov r3, r3, lsr #8 - strplb r3, [r0], #1 - LOADREGS(fd, sp!, {r4 - r6, pc}) - diff --git a/drivers/scsi/arm/acornscsi-io.c b/drivers/scsi/arm/acornscsi-io.c new file mode 100644 index 000000000..08071963d --- /dev/null +++ b/drivers/scsi/arm/acornscsi-io.c @@ -0,0 +1,105 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Acorn SCSI card I/O + * + * The Acorn SCSI expansion card exposes each 16-bit SCSI data + * halfword on the low half of a 32-bit card access: + * + * - on reads, one 16-bit value is returned per 32-bit card load; + * consecutive card reads are packed into 32-bit memory words + * + * - on writes, a 16-bit memory halfword is expanded into a 32-bit + * card word. The original assembly duplicates the halfword into + * both halves of the card word for the bulk of the transfer and + * writes only the low 16 bits of the trailing partial word, + * since the hardware samples only the low half. + */ + +#include +#include +#include +#include + +#include "acornscsi-io.h" + +/* + * Transfer a block of data from the Acorn SCSI card into memory. + * + * The card address is rounded down to a 32-bit boundary. Each + * 32-bit read from the card yields one valid 16-bit halfword in + * the low half; pairs of card reads are packed into single 32-bit + * memory words. + */ +void __acornscsi_in(void __iomem *addr, char *buffer, int length) +{ + const u32 __iomem *card = PTR_ALIGN_DOWN((const u32 __iomem *)addr, 4); + u8 *buf = (u8 *)buffer; + + while (length >= 4) { + u32 w0 = readl(card + 0); + u32 w1 = readl(card + 1); + + put_unaligned_le32((w0 & 0xffff) | (w1 << 16), buf); + + card += 2; + buf += 4; + length -= 4; + } + + if (length >= 2) { + u32 w0 = readl(card); + + put_unaligned_le16(w0 & 0xffff, buf); + + card++; + buf += 2; + length -= 2; + } + + if (length >= 1) { + u32 w0 = readl(card); + + *buf = w0 & 0xff; + } +} + +/* + * Transfer a block of data from memory to the Acorn SCSI card. + * + * Each 16-bit value read from memory is expanded into a 32-bit card + * word, with the halfword duplicated in both halves (matching the + * original assembly). For the trailing partial halfword the card + * only samples the low 16 bits, so two byte stores are sufficient. + */ +void __acornscsi_out(void __iomem *addr, char *buffer, int length) +{ + u32 __iomem *card = PTR_ALIGN_DOWN((u32 __iomem *)addr, 4); + const u8 *buf = (const u8 *)buffer; + + while (length >= 4) { + u32 v = get_unaligned_le32(buf); + u32 lo = v & 0xffff; + u32 hi = v >> 16; + + writel(lo | (lo << 16), card + 0); + writel(hi | (hi << 16), card + 1); + + card += 2; + buf += 4; + length -= 4; + } + + if (length >= 2) { + void __iomem *cp = (void __iomem *)card; + + writeb(buf[0], cp); + writeb(buf[1], cp + 1); + + card++; + buf += 2; + length -= 2; + } + + if (length >= 1) + writeb(*buf, card); +} diff --git a/drivers/scsi/arm/acornscsi-io.h b/drivers/scsi/arm/acornscsi-io.h new file mode 100644 index 000000000..64acfb8bb --- /dev/null +++ b/drivers/scsi/arm/acornscsi-io.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Acorn SCSI card I/O + */ + +#ifndef _ACORNSCSI_IO_H +#define _ACORNSCSI_IO_H + +#include + +void __acornscsi_in(void __iomem *addr, char *buffer, int length); +void __acornscsi_out(void __iomem *addr, char *buffer, int length); + +#endif /* _ACORNSCSI_IO_H */ diff --git a/drivers/scsi/arm/acornscsi.c b/drivers/scsi/arm/acornscsi.c index 79d7d7336..263a1bf24 100644 --- a/drivers/scsi/arm/acornscsi.c +++ b/drivers/scsi/arm/acornscsi.c @@ -140,6 +140,8 @@ #include +#include "acornscsi-io.h" + #define VER_MAJOR 2 #define VER_MINOR 0 #define VER_PATCH 6 @@ -886,7 +888,6 @@ static void acornscsi_data_read(AS_Host *host, char *ptr, unsigned int start_addr, unsigned int length) { - extern void __acornscsi_in(void __iomem *, char *buf, int len); unsigned int page, offset, len = length; page = (start_addr >> 12); @@ -931,7 +932,6 @@ static void acornscsi_data_write(AS_Host *host, char *ptr, unsigned int start_addr, unsigned int length) { - extern void __acornscsi_out(void __iomem *, char *buf, int len); unsigned int page, offset, len = length; page = (start_addr >> 12); -- 2.56.0