From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD30606A31A for ; Tue, 27 Oct 2026 10:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=THXtOza+; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=G4XeIGIP DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=EhPXelCABLWuSjrEc8aU2EyQqZo8N/hPtG5bDKHLnWw=; b=THXtOza+ZfSUB/ FvjccnnfD6wBdxZM03KLKNTBMDHdFwp6M0v184PaZgKjJ+8BnUWLBiFYHTloLeoLGZIRWAH/J1tvN YhAWEaV+Jv1AOdRUp3jeBP21z8N/HiEqDRHV/nb/MdrK3QaRR4oUG0tOD/ZHQ6D27IYdgRx0By/Ds 8bLB6MzlgSxLKU0unTcgAGPkUJCmbUskAzDXB4iKjXSfcDtLiHtwiPQStx9Xl9UDMCUEo3oOPZ1ZF Bqh97N2Ritgplsrd8/S+w0A/033GdtXbu+Zofxpt0b/p6JvjaOKsjNBwoI8VzDf0HbWRoAko3lzRK Uh9Mtx2ESXPY1awR6w/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLeZU-00000004JDF-3iN4; Tue, 27 Oct 2026 10:38:24 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLeZT-00000004JD7-2McY for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2026 10:38:23 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A801860220; Tue, 27 Oct 2026 10:38:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06CB41F01828; Tue, 27 Oct 2026 10:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793097502; bh=EhPXelCABLWuSjrEc8aU2EyQqZo8N/hPtG5bDKHLnWw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=G4XeIGIPvE+xYgVHpDHqXMtEF0v553A8vM1XSFfYh384TgrWfqwXzR2+Pa9nabpcE loLXPqZ0UItj8rbU9nV9Ry6thYMHGe1Nnjc9HBWjAPIJg86MypzuaeWKd72uIBZH6I i+9jPsriG1qmLkzrbWCEONILNwucHtUh9CV/lLb1MGpkhljCKDi0f6KLW5Fw2Ko1yX 57PtbTRHimNS+qO6riC03hkVbR850TJUpCLm0UZDrHWgQAVaTugrjHHBaK2PXILAOR DYLQJk/Jsi0uXa7P/kYf4Y9dnR1A26gUiP4Qu/gbylqJDfJrn7Rc3rFCyW8TowY7Bu 6qZAWdYPxYbkQ== From: Lee Jones To: lee@kernel.org, Linus Walleij , Mattias Wallin , Samuel Ortiz , linux-arm-kernel@lists.infradead.org, mfd@lists.linux.dev, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH v2 21/27] mfd: abx500-core: Unregister device ops on devm release Date: Tue, 27 Oct 2026 09:30:50 +0000 Message-ID: <20261027093306.2812695-22-lee@kernel.org> X-Mailer: git-send-email 2.56.0.307.g5fe7bd680c-goog In-Reply-To: <20261027093306.2812695-1-lee@kernel.org> References: <20261027093306.2812695-1-lee@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 abx500_register_ops() allocates struct abx500_device_entry via devm_kzalloc() and links it into the global abx500_list without registering a devres cleanup action. If a caller's probe function subsequently fails, devres frees the entry while it remains linked in abx500_list, causing use-after-free and list corruption on later traversals. Register a devm_add_action_or_reset() callback in abx500_register_ops() to remove the entry from abx500_list before devres frees it. Fixes: c211b6b9c014 ("mfd: abx500-core: Convert to managed resources for allocating memory") Closes: https://sashiko.dev/#/bug/linux-6a9c6b8b-8f89-4af5-8cb1-102822e44e6e Cc: stable@vger.kernel.org Reviewed-by: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/abx500-core.c | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c index e896531d0354..5873e335c395 100644 --- a/drivers/mfd/abx500-core.c +++ b/drivers/mfd/abx500-core.c @@ -5,6 +5,7 @@ * Author: Mattias Wallin */ +#include #include #include #include @@ -33,6 +34,21 @@ static void lookup_ops(struct device *dev, struct abx500_ops **ops) } } +void abx500_remove_ops(struct device *dev) +{ + struct abx500_device_entry *dev_entry, *tmp; + + list_for_each_entry_safe(dev_entry, tmp, &abx500_list, list) + if (dev_entry->dev == dev) + list_del(&dev_entry->list); +} +EXPORT_SYMBOL(abx500_remove_ops); + +static void abx500_unregister_ops(void *data) +{ + abx500_remove_ops(data); +} + int abx500_register_ops(struct device *dev, struct abx500_ops *ops) { struct abx500_device_entry *dev_entry; @@ -45,20 +61,11 @@ int abx500_register_ops(struct device *dev, struct abx500_ops *ops) memcpy(&dev_entry->ops, ops, sizeof(*ops)); list_add_tail(&dev_entry->list, &abx500_list); - return 0; + + return devm_add_action_or_reset(dev, abx500_unregister_ops, dev); } EXPORT_SYMBOL(abx500_register_ops); -void abx500_remove_ops(struct device *dev) -{ - struct abx500_device_entry *dev_entry, *tmp; - - list_for_each_entry_safe(dev_entry, tmp, &abx500_list, list) - if (dev_entry->dev == dev) - list_del(&dev_entry->list); -} -EXPORT_SYMBOL(abx500_remove_ops); - int abx500_set_register_interruptible(struct device *dev, u8 bank, u8 reg, u8 value) { -- 2.56.0.307.g5fe7bd680c-goog