From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7186D606A31F for ; Tue, 27 Oct 2026 13:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Jh0/7Ss8; dkim=pass (1024-bit key, unprotected) header.d=rock-chips.com header.i=@rock-chips.com header.a=rsa-sha256 header.s=default header.b=IrIPNZFm DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=CAzYdmJLVepJ08iaC2Wrs5PVOHKqjdTppJaoKTJ86Pw=; b=Jh0/7Ss8kfYzNl E/A6wTi5UaMFjFE33vzqzPhjBXojdxVWd3Fi9z3AuVWEmwNz6dHQLsmXUG7XvUBraue1bCqyAkCnK JDRNZ731t2n0td4/zgGGOT/FcoHmoizSv/oH9qzWm+WAHhMvGH6Vv3ySsLcmWgM2R7wZKc+/bMft4 6JYP/ILIQxRwQ/Kei93Z8b+BFo2KYq/J+yFjWh0siGC8Zi/Kajykeog/W83khwmGwX5w4odRCTMk1 cNK6kXZM3FD/qKyLRkli5lCQSRJ4fQ09/Yx/0xscH65Nusp3noQRqIDTHH1+ZAkm49OX3wv9mhJR+ awUqDqpwqOeri5woGR8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLhEX-00000004rRQ-2l0z; Tue, 27 Oct 2026 13:28:58 +0000 Received: from mail-m8389.xmail.ntesmail.com ([156.224.83.89]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLhEA-00000004qvr-0Dxs; Tue, 27 Oct 2026 13:28:36 +0000 Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 528777a3a; Tue, 27 Oct 2026 21:28:29 +0800 (GMT+08:00) From: Damon Ding To: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Heiko Stuebner , Sandy Huang Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Dmitry Baryshkov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v5 12/18] drm/rockchip: analogix_dp: Unbind bridge when connector init fails Date: Tue, 27 Oct 2026 21:28:04 +0800 Message-Id: <20261027132810.1746118-13-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261027132810.1746118-1-damon.ding@rock-chips.com> References: <20261027132810.1746118-1-damon.ding@rock-chips.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0aa17d8c4e3903a8kunm87c266213d571c X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkZTxlPVh8eSExKHU9LGh9NS1YVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=IrIPNZFmBwH0pCXfzEJEHVZQ+NPQJV3GTxc4VylSkHaNrwqoEwgl2idGW+YR345A8NS4ScPfWZiCUC8qOhoYYht00k8nZIAQSFFtrX4Wi4yiUJOSAvfWNdNODA9UT0hEYA7G1nsvasW8jqXDrabZt1xk0YMi4s9aBm2uhr7+bcs=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=CAzYdmJLVepJ08iaC2Wrs5PVOHKqjdTppJaoKTJ86Pw=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261027_062834_932797_72B0B064 X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The rockchip_dp_bind() returns without unwinding analogix_dp_bind() when drm_bridge_connector_init() fails. The aux device registered by analogix_dp_bind() is then left behind with a dangling drm_dev pointer, which could be accessed on later AUX transfers. Call analogix_dp_unbind() in the error path to release the aux device. Signed-off-by: Damon Ding --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index 38c78360842f..e6310d66e8e3 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -419,6 +419,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master, if (IS_ERR(connector)) { ret = PTR_ERR(connector); dev_err(dp->dev, "Failed to initialize bridge_connector\n"); + analogix_dp_unbind(dp->adp); goto err_cleanup_encoder; } -- 2.34.1