From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D92F9606BFA8 for ; Wed, 28 Oct 2026 19:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CT4phZjc; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=NGFb/RCD DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To: From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=ua8GfkfDrHDUR8px+Sy19+vmLzFSWzTq6VAHh+SakiE=; b=CT4phZjczUZYlmS1TkfHIKKqvZ dO7iV0iJWMe9Plhbbg3Rjx+fLUdNeWq2yiqK2SYCom1vZ8SKhOF0wa9RrdxBl2xk1MGivKX0MQ1IZ UQhvhLhEvWt50rn9Z+Bc7WuY92Bvs+2H0F00c8VRyM+pedzcU6Bxtnm1F0U92Nscyq7KApjb7Z+yr 5aJd/jy9ghD53DawI0BigLfsJ3nvKYLBQWvdjVQnRUG40CdPBbC0bk6U20+4I1nU8+fvzEiiIB/Hi orF0EYqNgpUwVCmHdnhTIVjIMgH7kXOBYkxSn5+VyYyn1TBXX8XLeCJ9lcHv7RdbDvKeBMBFys9EB N8gmqDfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM8va-00000007ndo-4Ave; Wed, 28 Oct 2026 19:03:14 +0000 Received: from mail-pj1-x1048.google.com ([2607:f8b0:4864:20::1048]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM8vS-00000007nRB-33J3 for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2026 19:03:08 +0000 Received: by mail-pj1-x1048.google.com with SMTP id 98e67ed59e1d1-3acc98e3b3cso1086364a91.3 for ; Wed, 28 Oct 2026 12:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793214184; x=1793818984; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ua8GfkfDrHDUR8px+Sy19+vmLzFSWzTq6VAHh+SakiE=; b=NGFb/RCD0VAplnHpuvuQ7ny6tLr+WrtOWctWSAcGiDaYd/U7i7b+Kaiv0UJGlZ5u0z yIrWf0adQkG3Yqa25KjyhLHUCYdTuQLca8AHprFnI3wzNzPZ/ZKYRQoTDAkg9I3l+K84 vcPdeP57kACoKs2FPI9Bn1IzcbLyoNJ4QLo4nAx/WCx1zfEMMa500/SnQu5Ryfcof8ZO /VY7bqush6AAX58Gn4ObACiQ2HksfuwbEVDrA8gTZe9i0Pl4npahHLsg/Bvo3qJjkTII XdMb2k0t2G1YeJn0iXFjO4VmUaTZE7BaIu+L6sOCl0Uch3wm3dbB2CUMaDK4hdds+hjD SIkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793214184; x=1793818984; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ua8GfkfDrHDUR8px+Sy19+vmLzFSWzTq6VAHh+SakiE=; b=epadn61kuu/BhWc/fx/RtXaloBIhxLzVnSV3lIAl4X+9etS3sVpy4ePpxinw/BF3QE ZfAFFAgHH2SGX/p8+7Wf4lNsBfbhRHS2gjxZSOiX39lIy/vbRkiObsnfKMvSR9/XEd2L M+OQOoQaodQk6sjiDdn3VE3hc5HjjmNtHBC12btbRVSUEiTHkZXIsy2HWAx1J0TGFZEq mMhLgo/Yzgt9e8xDIl/lpy8WNfYr6RFV9eqOg5kEGSoxqFJeUPn0PORNYykpxFo64glW Ts2D5pOq3WafrMM8zfCOM8Vm0D1ZrxMsS7VGXPUo5vyxHqS59YTswHVY21b1HOZwrepK KjuA== X-Forwarded-Encrypted: i=1; AKwUvBywM3o7DpTkxm027mLiknVSAtjG5vn0yfm6yAk/E09bKxPrjeHb/0NLI2DAY2Y3o0FpOrRyPJcL93uU8iHoRl46@lists.infradead.org X-Gm-Message-State: AFq9FYI+trN07u4voiLmKw1/cPrN+rgY71sTm17bhCXHGdoB8EMNlDER OPHlJ44pRDMWa+AF4Vb2K8tRE4YKvp4EsArCcy3DX9NbSVyoSz9jYmf2+Rjgo2uXspAkpBwMqtx rhTe9vA== X-Received: from pjbov14.prod.google.com ([2002:a17:90b:258e:b0:3a8:d9d:78ef]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:224f:b0:3a0:b312:1fbe with SMTP id 98e67ed59e1d1-3ae580a7ac7mr2187674a91.23.1793214184152; Wed, 28 Oct 2026 12:03:04 -0700 (PDT) Date: Wed, 28 Oct 2026 12:02:54 -0700 In-Reply-To: <20261028190259.1819571-1-seanjc@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261028190259.1819571-1-seanjc@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261028190259.1819571-3-seanjc@google.com> Subject: [PATCH 2/7] KVM: Add a @force param to __kvm_vcpu_kick() for PPC backwards compatibility From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Nicholas Piggin , Atish Patra , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Teodorescu Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261028_120306_783139_C4ECFFD7 X-CRM114-Status: GOOD ( 16.36 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Sean Christopherson Sender: "linux-arm-kernel" X-Spam-Status: No, score=-26.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Plumb in a @force param to __kvm_vcpu_kick() to force an IPI without checking kvm_arch_vcpu_should_kick(). The param will be used to drop kvm_arch_vcpu_should_kick() in favor of kvm_request_needs_ipi() without regressing PPC, which for unknown reasons unconditionally blasts an IPI in a variety of kvm_vcpu_kick() flows. No functional change intended (nothing yet passes in @force=true). Signed-off-by: Sean Christopherson --- include/linux/kvm_host.h | 6 +++--- virt/kvm/kvm_main.c | 10 +++++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index e7fc94e2910a..3b9844c3906d 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -1570,11 +1570,11 @@ void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu); bool kvm_vcpu_wake_up(struct kvm_vcpu *vcpu); #ifndef CONFIG_S390 -void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait); +void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force); static inline void kvm_vcpu_kick(struct kvm_vcpu *vcpu) { - __kvm_vcpu_kick(vcpu, false); + __kvm_vcpu_kick(vcpu, false, false); } #endif @@ -2315,7 +2315,7 @@ static __always_inline void kvm_make_request(int req, struct kvm_vcpu *vcpu) static inline void kvm_make_request_and_kick(int req, struct kvm_vcpu *vcpu) { kvm_make_request(req, vcpu); - __kvm_vcpu_kick(vcpu, req & KVM_REQUEST_WAIT); + __kvm_vcpu_kick(vcpu, req & KVM_REQUEST_WAIT, false); } #endif diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index cf4cb586f140..67addb9e48a7 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3908,7 +3908,7 @@ EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_vcpu_wake_up); /* * Kick a sleeping VCPU, or a guest VCPU in guest mode, into host kernel mode. */ -void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait) +void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force) { int me, cpu; @@ -3933,9 +3933,13 @@ void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait) * after kvm_arch_vcpu_should_kick(), which could result in sending an * IPI to the previous pCPU. But, that's ok because the purpose of the * IPI is to force the vCPU to leave IN_GUEST_MODE, and migrating the - * vCPU also requires it to leave IN_GUEST_MODE. + * vCPU also requires it to leave IN_GUEST_MODE + * + * Note #2, do NOT check if an IPI is needed if @force is true, as the + * check also modifies vcpu->mode and KVM PPC needs to avoid that side + * effect for unknown historical reasons. */ - if (kvm_arch_vcpu_should_kick(vcpu)) { + if (force || kvm_arch_vcpu_should_kick(vcpu)) { cpu = READ_ONCE(vcpu->cpu); if (cpu != me && (unsigned int)cpu < nr_cpu_ids && cpu_online(cpu)) { /* -- 2.56.0.313.g2479322e68-goog