From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CECA460A260A for ; Wed, 28 Oct 2026 19:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TEkLG9i2; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=Fs7TmEji DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To: From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=kQihi39MSjxZBPCKWC1v+KxEdPYKoJ3DWZvMHVb+Z7E=; b=TEkLG9i2I+78SqANGtJuXoOkhZ T6VXhXK2eh9qjoIEDsuKP6FOArKIHlzEE7Xt0rvbqn1src6clkM55hFjnHbzP4bHZSK3WPh2cJ5G2 zmFtbE6FywD/G5r59R0dbP/uDmOPCo1QPJwILK3CLnYJ+cnjRuamYjbHXs9Cp3Znhei1mplVMHgor coGdCQHaMbuBEb8X1SZorXsRlnzYGbpUVLLbymohiDyiEd3xUg9efiyBmQVUwx53fggQ1A3XY/eY4 JBlFhCSyIgxaIdQfweZGbcWS+ivbxYT4tOpOjfhhgDDpcKRG0RxNy+BEi5wh7M19BxAm7L6KeLRpP e6RWXXwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM8vi-00000007no8-30cl; Wed, 28 Oct 2026 19:03:22 +0000 Received: from mail-pg1-x547.google.com ([2607:f8b0:4864:20::547]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM8vT-00000007nS9-1sfh for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2026 19:03:08 +0000 Received: by mail-pg1-x547.google.com with SMTP id 41be03b00d2f7-cc7e0321ec1so1602306a12.0 for ; Wed, 28 Oct 2026 12:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793214186; x=1793818986; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=kQihi39MSjxZBPCKWC1v+KxEdPYKoJ3DWZvMHVb+Z7E=; b=Fs7TmEji1Os+v4bAxh/his3s9wTK6TMkoO6Miy8bQXB9H+1dZ69IMGSydpfgtjetl2 99E2+DdYZAkzNo5DqflrXMz9maE0iIBx3aEI89jZEBF7S5Paadg/a68rMs/+ALkJzwiQ +FqaBNb37DqYXcQiryJoyPGElslw8LAL51dJsSUJ4UtYbkH2YDhUy0qnG6YueTXxVMTI PJ9EQkakpIZdAD92ObGm9pqPB52v3nA7vZPCLDXyjNB1AOLpoDDZLe8nwI6MMA1YYE01 KH9nFSOci8MELXhZVzY1crSTsNh1SH+YSsayXwMmsNrmUMXzE2xigIVZiGtLu8bU9r4w hgUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793214186; x=1793818986; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kQihi39MSjxZBPCKWC1v+KxEdPYKoJ3DWZvMHVb+Z7E=; b=YxxgB7fDNr7Ak8GIZSncTYHDGjzl91vXneWxhgIojekVNyZgVNpIbsedmPmIkX2g7Q h90Mm7q6hs//EWozoTGfVJ1KQo4xA/j1OOy11aa/KUhbM4w1QpTOSume5O2N+h+EXwqz vrKvmjslVVr13b1OCMxPGis8EqNqiOjtH0z8jva/S5u93i3S95gaH+jTozQu2mNXVLNe bP0D6RNp/TyJCiYc9jMxUu339E7aHKGESbxoot+l5O+XQK3b4148Tc/MZh88WGe821lU Fe799TGtEtTt2UUs4vhfw1RPke0Lrpb86ayM8fT6jpb80n4YmgIX9B6kCxTu8/9IJzDe MQXg== X-Forwarded-Encrypted: i=1; AKwUvBzA4hlkElgzhdXjkYC8FMq0HPqSNxYtrtaBSae64nc1PphUFLYtBOGJGMKVwUyozcGzRzF++Rm4M3kfgIQ7SyO/@lists.infradead.org X-Gm-Message-State: AFq9FYJlQFM7l5u7vKntlh5Mmh1W1rPSXVGx6E4DXUltMMT3gf8nuz9b 9A7/Y0Etqt/Z/gRVCd8+FgN5Rn6120SA96KHlf7WlcDhEFhHmbmD+hPgGRtg+sfhPXPLbIFnR9x cQXpi3g== X-Received: from pgx20.prod.google.com ([2002:a63:1754:0:b0:cd4:ef82:4e33]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:a120:b0:3e1:5816:8749 with SMTP id adf61e73a8af0-3e9023eda44mr2865201637.38.1793214185450; Wed, 28 Oct 2026 12:03:05 -0700 (PDT) Date: Wed, 28 Oct 2026 12:02:55 -0700 In-Reply-To: <20261028190259.1819571-1-seanjc@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261028190259.1819571-1-seanjc@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261028190259.1819571-4-seanjc@google.com> Subject: [PATCH 3/7] KVM: PPC: Explicitly force IPIs when directly kicking vCPUs From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Nicholas Piggin , Atish Patra , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Teodorescu Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261028_120307_525381_A8876BAF X-CRM114-Status: GOOD ( 16.76 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Sean Christopherson Sender: "linux-arm-kernel" X-Spam-Status: No, score=-26.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Explicitly force an IPI when invoking kvm_vcpu_kick() directly instead of relying on kvm_arch_vcpu_should_kick() to unconditionally return 1/true. This will allow dropping kvm_arch_vcpu_should_kick() in favor of kvm_request_needs_ipi(). No functional change intended (1 || 1 == true). Signed-off-by: Sean Christopherson --- arch/powerpc/include/asm/kvm_ppc.h | 13 ++++++++++++- arch/powerpc/kvm/book3s.c | 4 ++-- arch/powerpc/kvm/book3s_pr.c | 2 +- arch/powerpc/kvm/booke.c | 6 +++--- arch/powerpc/kvm/e500_emulate.c | 2 +- arch/powerpc/kvm/powerpc.c | 2 +- 6 files changed, 20 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index 169ea6a7fbad..bbe7378ad0ef 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h @@ -30,6 +30,17 @@ #endif #include +/* + * TODO: For unknown reasons, KVM PPC has historically ignored vcpu->mode when + * determining if kicking a vCPU needs an IPI. Either document why that + * behavior is necessary, or drop this helper and the @force param from + * __kvm_vcpu_kick(). + */ +static inline void kvmppc_vcpu_kick(struct kvm_vcpu *vcpu) +{ + __kvm_vcpu_kick(vcpu, false, true); +} + /* * KVMPPC_INST_SW_BREAKPOINT is debug Instruction * for supporting software breakpoint. @@ -598,7 +609,7 @@ static inline void kvmppc_clear_host_ipi(int cpu) static inline void kvmppc_fast_vcpu_kick(struct kvm_vcpu *vcpu) { - kvm_vcpu_kick(vcpu); + kvmppc_vcpu_kick(vcpu); } static inline bool kvm_hv_mode_active(void) { return false; } diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c index 2efbe05caed7..dce53c5a3868 100644 --- a/arch/powerpc/kvm/book3s.c +++ b/arch/powerpc/kvm/book3s.c @@ -260,7 +260,7 @@ void kvmppc_core_queue_external(struct kvm_vcpu *vcpu, * external interrupts for the guest just before entering * the guest. That is OK even if userspace did do a * KVM_INTERRUPT_SET on a pseries guest vcpu, because the - * caller (kvm_vcpu_ioctl_interrupt) does a kvm_vcpu_kick() + * caller (kvm_vcpu_ioctl_interrupt) does a kvmppc_vcpu_kick() * which ends up doing a smp_send_reschedule(), which will * pull the guest all the way out to the host, meaning that * we will call kvmppc_core_prepare_to_enter() before entering @@ -827,7 +827,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu, void kvmppc_decrementer_func(struct kvm_vcpu *vcpu) { kvmppc_core_queue_dec(vcpu); - kvm_vcpu_kick(vcpu); + kvmppc_vcpu_kick(vcpu); } int kvmppc_core_vcpu_create(struct kvm_vcpu *vcpu) diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c index ecfb88bf6464..1894968f2c25 100644 --- a/arch/powerpc/kvm/book3s_pr.c +++ b/arch/powerpc/kvm/book3s_pr.c @@ -2066,7 +2066,7 @@ static struct kvmppc_ops kvm_ops_pr = { .emulate_op = kvmppc_core_emulate_op_pr, .emulate_mtspr = kvmppc_core_emulate_mtspr_pr, .emulate_mfspr = kvmppc_core_emulate_mfspr_pr, - .fast_vcpu_kick = kvm_vcpu_kick, + .fast_vcpu_kick = kvmppc_vcpu_kick, .arch_vm_ioctl = kvm_arch_vm_ioctl_pr, #ifdef CONFIG_PPC_BOOK3S_64 .hcall_implemented = kvmppc_hcall_impl_pr, diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 13ad4cf5fa71..fd7f24a68b31 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -650,7 +650,7 @@ static void kvmppc_watchdog_func(struct timer_list *t) if (new_tsr & TSR_WIS) { smp_wmb(); kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu); - kvm_vcpu_kick(vcpu); + kvmppc_vcpu_kick(vcpu); } /* @@ -661,7 +661,7 @@ static void kvmppc_watchdog_func(struct timer_list *t) vcpu->arch.watchdog_enabled) { smp_wmb(); kvm_make_request(KVM_REQ_WATCHDOG, vcpu); - kvm_vcpu_kick(vcpu); + kvmppc_vcpu_kick(vcpu); } /* @@ -1872,7 +1872,7 @@ void kvmppc_set_tsr_bits(struct kvm_vcpu *vcpu, u32 tsr_bits) set_bits(tsr_bits, &vcpu->arch.tsr); smp_wmb(); kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu); - kvm_vcpu_kick(vcpu); + kvmppc_vcpu_kick(vcpu); } void kvmppc_clr_tsr_bits(struct kvm_vcpu *vcpu, u32 tsr_bits) diff --git a/arch/powerpc/kvm/e500_emulate.c b/arch/powerpc/kvm/e500_emulate.c index 051102d50c31..10cd6b4ab456 100644 --- a/arch/powerpc/kvm/e500_emulate.c +++ b/arch/powerpc/kvm/e500_emulate.c @@ -75,7 +75,7 @@ static int kvmppc_e500_emul_msgsnd(struct kvm_vcpu *vcpu, int rb) int cpir = cvcpu->arch.shared->pir; if ((param & PPC_DBELL_MSG_BRDCAST) || (cpir == pir)) { set_bit(prio, &cvcpu->arch.pending_exceptions); - kvm_vcpu_kick(cvcpu); + kvmppc_vcpu_kick(cvcpu); } } diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c index 9194cf492d1c..09c94b849185 100644 --- a/arch/powerpc/kvm/powerpc.c +++ b/arch/powerpc/kvm/powerpc.c @@ -1903,7 +1903,7 @@ int kvm_vcpu_ioctl_interrupt(struct kvm_vcpu *vcpu, struct kvm_interrupt *irq) kvmppc_core_queue_external(vcpu, irq); - kvm_vcpu_kick(vcpu); + kvmppc_vcpu_kick(vcpu); return 0; } -- 2.56.0.313.g2479322e68-goog