From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1D72606A329 for ; Wed, 28 Oct 2026 19:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=DpIaIwvE; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=KTaXjGjA DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To: From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; b=DpIaIwvET27MlMUqoLsC6rESG5 qBIZScnD0zbDoLzxL/AmlMZqYCTmVNwmaADx7faz3buQG8XTB262MWftfgmudAEKfPYY5ePHfcdjs a+zFxeBPNvinjp2zqJXCltCdHY1DbdJvrs/WoU5L+7NJMhu6GlhzzZyEwx+bAnwweYNl0z4rc5jYr 9Rz0n8kiU69lQHNTk3Bc/CbdD8xT6rH+LJSj3lvmMy1Z5SqPJnZlYA89DuUniDSk/EP27aiqFrnBH ogjQ/FUSrjlCNwbrM5mT18FKo+38YbKLE6To7EHrVC2rkl14Z2vdqQ+vK12GQJkYTbvhv/ki6JQzt +JRNIgRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM8vz-00000007oDn-1y4U; Wed, 28 Oct 2026 19:03:39 +0000 Received: from mail-pj1-x1046.google.com ([2607:f8b0:4864:20::1046]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM8vW-00000007nXm-2OCC for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2026 19:03:12 +0000 Received: by mail-pj1-x1046.google.com with SMTP id 98e67ed59e1d1-3ac8f449d1bso1104131a91.3 for ; Wed, 28 Oct 2026 12:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793214189; x=1793818989; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; b=KTaXjGjAZ1Q3AcVJd3PZtKz1imGJTDQ43wkUW/scpQWOwUQszBXEb8zrjvMFhgQIQ6 n5oK6FtIRSf/3T23Ry1Taht8IqrQF3w8ubSBAc/ZruK/fWK6IdeBPBk6/ikPgkcta1QM ty9dFXPrMFVVaSPvLKabGyePU+BhhlYb1m6krJZ0QX1WOv8fF9y6yYUbfW97G1HmacF0 JcDUvaTPiuNeOXZb893ILOdkT11dakhykpiBsNKHBmAoVdhOqfC5/pmMerfAGAkg3yqH WwlwhZgPiBIPgZHmn9tkyOe909DnYda9W84DNjgovKSRQTH6cNERRCESCBGTtPZygMaz Sy9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793214189; x=1793818989; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; b=UGrYblUmf5zmVpo0HL0Go3xLLi61ZaWUvevzetybUGcfw7CfQmaqpemWXCWUQDX4Zo T3LI24TlMoeyyDYUrzfk2WPZoCIicmrBR8hfpn0F1/TVap+UZ5vXnzPNsjfiExIb+s7D paf2CnXIMjKqrZkDZU1aMG/gi4uZykRbBkrdBIeHHBO7KiFvbkQ1d/8F148sx7nLLj1F f5dkryNA3zkjgSGklq7jaQdJ7RYDXMP0dyRVNZJVZ1COc1mzl7FmaXtCg6fdetrLyWCP Hcq5/JN4Ht8pvjway+Fi4qAiKJtOgkZxTYjJjeCIksOXDCM+ink1mSPd8H0jd4sDcwi+ 67bQ== X-Forwarded-Encrypted: i=1; AKwUvBx9l0H+xOB0nFCREwqnxs5n/BpFUg3PMkPm3IFeXeDn6Ki8fx7Geb60D+gyF79enr5j1sq13PlLVv6dXK9oaNc8@lists.infradead.org X-Gm-Message-State: AFq9FYJvKrGr/DSuMm21Cy07AQ0vLY0HWAZtpJqLsGeFDMkcx84V3iHa +fXAyzDgdJoXb72NleF4hZZ+QRb+rZpiHKlIYYBjieWStscR3ZZHKFVTdK3gLC6AJD/8yVEhxjS N54eL6A== X-Received: from pghw14.prod.google.com ([2002:a63:f50e:0:b0:cda:c74c:ca8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4b86:b0:3ac:a11a:7c84 with SMTP id 98e67ed59e1d1-3ae58195de0mr2519930a91.65.1793214189231; Wed, 28 Oct 2026 12:03:09 -0700 (PDT) Date: Wed, 28 Oct 2026 12:02:58 -0700 In-Reply-To: <20261028190259.1819571-1-seanjc@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261028190259.1819571-1-seanjc@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261028190259.1819571-7-seanjc@google.com> Subject: [PATCH 6/7] KVM: Plumb the full request into __kvm_vcpu_kick() From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Nicholas Piggin , Atish Patra , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Teodorescu Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261028_120310_640165_9BF49B31 X-CRM114-Status: GOOD ( 15.79 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Sean Christopherson Sender: "linux-arm-kernel" X-Spam-Status: No, score=-26.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Plumb the full request instead of just a "wait" boolean into __kvm_vcpu_kick() so that it can use kvm_request_needs_ipi() instead of the flawed kvm_vcpu_should_kick(). No functional change intended. Signed-off-by: Sean Christopherson --- arch/powerpc/include/asm/kvm_ppc.h | 2 +- include/linux/kvm_host.h | 6 +++--- virt/kvm/kvm_main.c | 17 +++++++++-------- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index bbe7378ad0ef..011dc422af78 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h @@ -38,7 +38,7 @@ */ static inline void kvmppc_vcpu_kick(struct kvm_vcpu *vcpu) { - __kvm_vcpu_kick(vcpu, false, true); + __kvm_vcpu_kick(vcpu, 0, true); } /* diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 9db42f58c561..035b1bdd8c09 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -1570,11 +1570,11 @@ void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu); bool kvm_vcpu_wake_up(struct kvm_vcpu *vcpu); #ifndef CONFIG_S390 -void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force); +void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, int request, bool force); static inline void kvm_vcpu_kick(struct kvm_vcpu *vcpu) { - __kvm_vcpu_kick(vcpu, false, false); + __kvm_vcpu_kick(vcpu, 0, false); } #endif @@ -2314,7 +2314,7 @@ static __always_inline void kvm_make_request(int req, struct kvm_vcpu *vcpu) static inline void kvm_make_request_and_kick(int req, struct kvm_vcpu *vcpu) { kvm_make_request(req, vcpu); - __kvm_vcpu_kick(vcpu, req & KVM_REQUEST_WAIT, false); + __kvm_vcpu_kick(vcpu, req, false); } #endif diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index e1a9da8b43d7..f1792256576b 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3913,7 +3913,7 @@ EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_vcpu_wake_up); /* * Kick a sleeping VCPU, or a guest VCPU in guest mode, into host kernel mode. */ -void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force) +void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, int req, bool force) { int me, cpu; @@ -3948,14 +3948,15 @@ void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force) cpu = READ_ONCE(vcpu->cpu); if (cpu != me && (unsigned int)cpu < nr_cpu_ids && cpu_online(cpu)) { /* - * Use a reschedule IPI to kick the vCPU if the caller - * doesn't need to wait for a response, as KVM allows - * kicking vCPUs while IRQs are disabled, but using the - * SMP function call framework with IRQs disabled can - * deadlock due to taking cross-CPU locks. + * Use a reschedule IPI to kick the vCPU if the request + * doesn't need to wait for a response (or there is no + * request), as KVM allows kicking vCPUs while IRQs are + * disabled, but using the SMP function call framework + * with IRQs disabled can deadlock due to taking cross- + * CPU locks. */ - if (wait) - smp_call_function_single(cpu, ack_kick, NULL, wait); + if (req & KVM_REQUEST_WAIT) + smp_call_function_single(cpu, ack_kick, NULL, true); else smp_send_reschedule(cpu); } -- 2.56.0.313.g2479322e68-goog