Re: [PATCH 03/11] ARM: dts: omap3: Add device tree entry for SGX GPU

[Andreas Kemnade <andreas@kemnade.info>]

On Tue, 9 Jan 2024 11:19:42 -0600
Andrew Davis <afd@ti.com> wrote:

[...]
> diff --git a/arch/arm/boot/dts/ti/omap/omap36xx.dtsi b/arch/arm/boot/dts/ti/omap/omap36xx.dtsi
> index e6d8070c1bf88..c3d79ecd56e39 100644
> --- a/arch/arm/boot/dts/ti/omap/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap36xx.dtsi
> @@ -211,10 +211,11 @@ sgx_module: target-module@50000000 {
>  			#size-cells = <1>;
>  			ranges = <0 0x50000000 0x2000000>;
>  
For quite some time. I see
sgx_pwrdm (INA),OFF:0,RET:0,INA:1,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
in /sys/kernel/debug/pm_debug/count

with a status = "disabled" here (so practically reverting the patch it is:

sgx_pwrdm (OFF),OFF:1,RET:0,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0

All without pvrsgx driver installed. 

What is going on here? OFF is more power-saving than INA I think?!
> -			/*
> -			 * Closed source PowerVR driver, no child device
> -			 * binding or driver in mainline
> -			 */
> +			gpu@0 {
> +				compatible = "ti,omap3630-gpu", "img,powervr-sgx530";
> +				reg = <0x0 0x2000000>; /* 32MB */
> +				interrupts = <21>;
> +			};
>  		};
>  	};
>  

Regards,
Andreas