From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC4D606A31C for ; Fri, 30 Oct 2026 23:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=J3xrXzLO; dkim=pass (2048-bit key, unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256 header.s=amazoncorp2 header.b=rGKToUSm DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=UgsuAaqC4mZioJp/qMefWvyxtbVtIVGewUrp4BJ3Akc=; b=J3xrXzLOerXZyFvAxLt9AjLYiD ov0+JkgOci3yafQ/PvoMKwXWMnH/gsO6uCt4Cl3upbVsNEJl19ls+YPm9nF4yfFRBfRreaiYZLY1M C3sCp3nyExdXm59GRZ3Aps/4andI4PFQZfOgAiOoe04EG4OzmYbv9JoHLqXulrEeogLmIixt5hAO4 Leqj7yNCrRmx6XbbAPYRoW97D1u8Txh7IgvgLaKqLUqAF3xfXuJqlq1qIym3TIv/UYNbakvGtritm 8GYh16MfWV2deBGmYhpAKaScddZWKfT+8XfyjyZNDNCV7GLApdzuvCTF+wmSV4IgByTDMT3vmeSkJ 3dV8u/cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMw7U-0000000CjiG-1YuI; Fri, 30 Oct 2026 23:34:48 +0000 Received: from pdx-out-013.esa.us-west-2.outbound.mail-perimeter.amazon.com ([34.218.115.239]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMw7S-0000000CjhN-1MRw for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2026 23:34:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1793403286; x=1824939286; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UgsuAaqC4mZioJp/qMefWvyxtbVtIVGewUrp4BJ3Akc=; b=rGKToUSm5QxEHF4QoOwmQMWzJ52RnOUtmCcH+LaiL+LGKvEPDiFEKVJf pSRV7VkL/0xD+UJMmH18Ag19AbRoG6k81CaEmNIVMTW4AJiPncJd0FT7V 28w/+bEhUbiPXEBsH8sXkxGYvW4BmAeOWDyZkAT2SMkEkomSclP9Ry3qT PbfCBYX30ElYuwoh7bIGlT9wi6iN5koTcLPkfcDYBFJkR5woqCrEiYkhp LNOKF9jTIikAEQVpQW9iYPR9/MGpWo0WYMy1FUnNPEA+yx/vJt5NNEk6Z ZMMPLhJFl+elcn4r1+O3C9PaYj3s4Al+HXyP72xpOw6hSxdmn/bLnLP4y Q==; X-CSE-ConnectionGUID: hWh706vGSHCTQmH9TSqIeQ== X-CSE-MsgGUID: TIrsSjpQQc2xztvm6Ratng== X-IronPort-AV: E=Sophos;i="6.27,186,1787011200"; d="scan'208";a="32495273" Received: from ip-10-5-9-48.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.9.48]) by internal-pdx-out-013.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2026 23:34:44 +0000 Received: from EX19MTAUWA001.ant.amazon.com [205.251.233.182:1110] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.7.65:2525] with esmtp (Farcaster) id 2f8f6925-7c7c-4ecc-bdcc-6516bd209c8f; Fri, 30 Oct 2026 23:34:43 +0000 (UTC) X-Farcaster-Flow-ID: 2f8f6925-7c7c-4ecc-bdcc-6516bd209c8f Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWA001.ant.amazon.com (10.250.64.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.56; Fri, 30 Oct 2026 23:34:43 +0000 Received: from dev-dsk-patrzhan-2a-52a3f46b.us-west-2.amazon.com (172.22.91.11) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.56; Fri, 30 Oct 2026 23:34:43 +0000 From: Patrick Zhang To: Marc Kleine-Budde , Vincent Mailhol , CC: Pavel Pisa , Ondrej Ille , Harini T , Michal Simek , , , Subject: [PATCH v2 2/3] can: xilinx_can: enable NAPI before starting the controller Date: Fri, 30 Oct 2026 23:33:29 +0000 Message-ID: <20261030233330.3483988-3-patrzhan@amazon.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20261030233330.3483988-1-patrzhan@amazon.com> References: <20261030233330.3483988-1-patrzhan@amazon.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D031UWC001.ant.amazon.com (10.13.139.241) To EX19D001UWA001.ant.amazon.com (10.13.138.214) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261030_163446_410144_66C1931B X-CRM114-Status: GOOD ( 15.43 ) X-Spam-Score: -11.9 (-----------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 xcan_open() calls xcan_chip_start(), which writes XCAN_IER_OFFSET to unmask the RX interrupts and then sets XCAN_SRR_CEN_MASK to enable the controller, and only then calls napi_enable(). A frame that arrives in that window raises the RX interrupt. xcan_interrupt() clears the RX bits in XCAN_IER_OFFSET and calls napi_schedule(). NAPI is still disabled, so napi_schedule_prep() finds NAPI_STATE_SCHED set and the schedule is dropped. Only xcan_rx_poll() unmasks RX again, and it never runs. The interface receives no data frames until the next close. Transmit still works. The RX overflow interrupt stays enabled, so once the RX FIFO fills, xcan_err_interrupt() counts rx_over_errors and reports overflow error frames, but nothing reads the FIFO. Every re-open (ip link down/up, a driver rebind) runs the same race again. The window is only the tail of xcan_chip_start(), so the failure is rare. Adding an mdelay(50) at the end of xcan_chip_start() makes it reproducible with continuous traffic from another node and a single "ip link set down/up" on the test device. Enable NAPI before the controller starts, so that an early RX interrupt can schedule the poll. NAPI can be enabled while the controller is in reset, because nothing schedules it until an interrupt arrives. If xcan_chip_start() fails, disable NAPI again. Otherwise the next open would call napi_enable() on an already enabled instance and trip the BUG_ON() in napi_enable_locked(). This is the same race as in "can: ctucanfd: enable NAPI before starting the controller". Tested on a Versal board. Fixes: b1201e44f50b ("can: xilinx CAN controller support") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Patrick Zhang --- Notes: v2: - Correct the commit message: the RX overflow interrupt stays enabled during the stall, so rx_over_errors is counted once the FIFO fills - Name the ctucanfd fix by subject instead of "the previous patch" - v1: https://lore.kernel.org/r/20261021205924.2538511-3-patrzhan@amazon.com drivers/net/can/xilinx_can.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 43d7f2282..5c2412bf9 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1570,18 +1570,22 @@ static int xcan_open(struct net_device *ndev) if (ret) goto err_irq; + /* Keep before xcan_chip_start(): the ISR masks RX interrupts and only + * the poll unmasks them. + */ + napi_enable(&priv->napi); ret = xcan_chip_start(ndev); if (ret < 0) { netdev_err(ndev, "xcan_chip_start failed!\n"); goto err_candev; } - napi_enable(&priv->napi); netif_start_queue(ndev); return 0; err_candev: + napi_disable(&priv->napi); close_candev(ndev); err_irq: free_irq(ndev->irq, ndev); -- 2.50.1