Re: [PATCH v2 8/9] ARM: dts: omap: dm8168-evm: Correct SD card pinmux

[Andreas Kemnade <andreas@kemnade.info>]

On Wed, 28 Oct 2026 17:06:09 +0100
Ettore Chimenti <ettore.chimenti@linaro.org> wrote:

> From: Andrew Goodbody <andrew.goodbody@linaro.org>
> 
> The SD card lines use external pullups and so the internal pullups need
> to be disabled so that they do not cause contention on the lines.
> This bug was revealed by correcting the effective bit mask of
> the pinctrl device. Use the correct macro for DM8168.
> 
> Also fix typo in comment SD_DAT2->SD_DAT3.
> 
> Fixes: 86800ffe84055 ("ARM: dts: omap: dm816x: Correct pinctrl register")
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
> Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
> Tested-by: Christopher Obbard <christopher.obbard@linaro.org>
> [ettore.chimenti@linaro.org: squashed after fixing DM816x macros ]
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/ti/omap/dm8168-evm.dts | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/dm8168-evm.dts b/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> index 81450e15b889..a6d42766a496 100644
> --- a/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> +++ b/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> @@ -45,13 +45,13 @@ DM816X_IOPAD(0x0aac, MUX_MODE0)			/* SPI_D1 */
>  
>  	mmc_pins: mmc-pins {
>  		pinctrl-single,pins = <
> -			DM816X_IOPAD(0x0a70, MUX_MODE0)			/* SD_POW */
> -			DM816X_IOPAD(0x0a74, MUX_MODE0)			/* SD_CLK */
> -			DM816X_IOPAD(0x0a78, MUX_MODE0)			/* SD_CMD */
> -			DM816X_IOPAD(0x0a7C, MUX_MODE0)			/* SD_DAT0 */
> -			DM816X_IOPAD(0x0a80, MUX_MODE0)			/* SD_DAT1 */
> -			DM816X_IOPAD(0x0a84, MUX_MODE0)			/* SD_DAT2 */
> -			DM816X_IOPAD(0x0a88, MUX_MODE0)			/* SD_DAT2 */
> +			DM816X_IOPAD(0x0a70, PULL_DIS | MUX_MODE0)	/* SD_POW */
> +			DM816X_IOPAD(0x0a74, PULL_DIS | MUX_MODE0)	/* SD_CLK */
> +			DM816X_IOPAD(0x0a78, PULL_DIS | MUX_MODE0)	/* SD_CMD */
> +			DM816X_IOPAD(0x0a7C, PULL_DIS | MUX_MODE0)	/* SD_DAT0 */
> +			DM816X_IOPAD(0x0a80, PULL_DIS | MUX_MODE0)	/* SD_DAT1 */
> +			DM816X_IOPAD(0x0a84, PULL_DIS | MUX_MODE0)	/* SD_DAT2 */
> +			DM816X_IOPAD(0x0a88, PULL_DIS | MUX_MODE0)	/* SD_DAT3 */
>  			DM816X_IOPAD(0x0a8c, MUX_MODE2)			/* GP1[7] */
>  			DM816X_IOPAD(0x0a90, MUX_MODE2)			/* GP1[8] */
>  		>;  
>