From: Krzysztof Kozlowski <krzk@kernel.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Srinivas Kandagatla <srini@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
Jacky Bai <ping.bai@nxp.com>,
mfd@lists.linux.dev, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: mfd: nxp,bbnsm: Add NVMEM for GP registers
Date: Mon, 2 Nov 2026 08:28:40 +0100 [thread overview]
Message-ID: <20261102-translucent-elated-pronghorn-cbb73b@quoll> (raw)
In-Reply-To: <20261101200140.141642-2-wahrenst@gmx.net>
On Sun, Nov 01, 2026 at 09:01:38PM +0100, Stefan Wahren wrote:
> + nvmem:
> + type: object
> + $ref: /schemas/nvmem/nvmem.yaml#
> +
> + properties:
> + compatible:
> + enum:
> + - nxp,imx93-bbnsm-nvmem
> +
> + required:
> + - compatible
> +
> + additionalProperties: false
> +
> rtc:
> type: object
> $ref: /schemas/rtc/rtc.yaml#
> @@ -88,6 +102,12 @@ examples:
> compatible = "nxp,imx93-bbnsm", "syscon", "simple-mfd";
> reg = <0x44440000 0x10000>;
>
> + nvmem {
> + compatible = "nxp,imx93-bbnsm-nvmem";
> + #address-cells = <1>;
> + #size-cells = <1>;
I don't think you tested your changes. address/size cells are not
allowed - see your binding.
Anyway, empty node makes almost no sense, so fold the node into the
parent.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-02 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 20:01 [PATCH 0/3] nvmem: Add driver for i.MX BBNSM GP register Stefan Wahren
2026-11-01 20:01 ` [PATCH 1/3] dt-bindings: mfd: nxp,bbnsm: Add NVMEM for GP registers Stefan Wahren
2026-11-02 7:28 ` Krzysztof Kozlowski [this message]
2026-11-01 20:01 ` [PATCH 2/3] nvmem: Add driver for i.MX BBNSM GP register Stefan Wahren
2026-11-01 20:01 ` [PATCH 3/3] arm64: dts: imx91_93_common: Enable BBNSM NVMEM Stefan Wahren
2026-11-02 7:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102-translucent-elated-pronghorn-cbb73b@quoll \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mfd@lists.linux.dev \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srini@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox