From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BB5A606A324 for ; Mon, 2 Nov 2026 22:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=qm6OT9vk; dkim=pass (1024-bit key, unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.a=rsa-sha256 header.s=mail header.b=v3q9/L+c DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=FIGvM0UwaN65BT0wYtQVF41feUQgPkRPdEQ92h4m6lY=; b=qm6OT9vkzo7QwvkG99dXP8CiQw wwckvMg8enby6Lxqgs2GOE/btJNRb58/BqSGsPoNA5d7LFIatcs3QWB4jQ7sKiDNBYwmzsyi3fDpq ygLP7sE2XkQQu+Ogyh/UTaggRpfAokgIwj3qa7kJI1D3K60mFu6wtFqnZGsRpn9b/TNM5LfiVZp9/ rAWiLQ7oXbtr1EarJiPR2INoBHF03+uTMpfCIaWfcBpuzHkF5wLQt38QzDf+HODoFUG6F1CL26Ftj vJW5JHinDo5N8US8s6DxnmZ5bDUE2QfRDgiTvZqRMEL98uxCA8gedTy4Jo4O59XC8if63bIPc7MdJ ViZQ8m9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xO0ai-00000000ZY6-0dlS; Mon, 02 Nov 2026 22:33:24 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xO0ae-00000000ZXR-3kSl; Mon, 02 Nov 2026 22:33:23 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 08EA3BA; Mon, 2 Nov 2026 23:31:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1793658661; bh=hcOlHliRKSdaB8pM8GXWnVePw0nVINC3lhEapMNXOvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v3q9/L+cC8F0c3oTmnGliaiHDPtz2BQT1fYsEcbxAsdmZOR17s672GVxURsXGBl94 I9rincg3HmxNrV6iBjPY+ByDA83AkZfde3bZ5ZkFC1xzsMbFc/qDPR768YbNspTYwT nXIMVYKF4JQQc/Gi9Qfn8axWqidohc3urfpgMbBA= Date: Tue, 3 Nov 2026 00:33:16 +0200 From: Laurent Pinchart To: iav@iav.lv Cc: Dafna Hirschfeld , Mauro Carvalho Chehab , Nicolas Dufresne , Hans Verkuil , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: rkisp1: Depend on PM Message-ID: <20261102223316.GB3548113@killaraus.ideasonboard.com> References: <20261102-rkisp1-depends-on-pm-v1-1-35a26cb2bbce@iav.lv> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20261102-rkisp1-depends-on-pm-v1-1-35a26cb2bbce@iav.lv> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261102_143321_101727_835DD231 X-CRM114-Status: GOOD ( 18.42 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Nov 02, 2026 at 05:49:46PM +0000, Igor Velkov via B4 Relay wrote: > From: Igor Velkov > > rkisp1_runtime_resume() enables the clocks and lets the interrupt > handlers run. Without CONFIG_PM it is never called, so rkisp1_probe() > reads RKISP1_CIF_VI_ID with the clocks disabled and every interrupt > handler returns IRQ_NONE. > > ARCH_ROCKCHIP and arm64 ARCH_MXC select PM, Why do we need this patch then ? > and no arm32 i.MX has this > ISP, so only COMPILE_TEST builds lose the driver. rkcif already depends > on PM. > > Signed-off-by: Igor Velkov > --- > Split out of the rkvdec CONFIG_PM discussion, as Nicolas asked [1]. > Without PM, olddefconfig on arm64 COMPILE_TEST now drops the driver; > with PM it builds as before (W=1). > > [1] https://lore.kernel.org/r/8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com > --- > drivers/media/platform/rockchip/rkisp1/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/rockchip/rkisp1/Kconfig b/drivers/media/platform/rockchip/rkisp1/Kconfig > index f53eb1f3f3e7..c825fbacee96 100644 > --- a/drivers/media/platform/rockchip/rkisp1/Kconfig > +++ b/drivers/media/platform/rockchip/rkisp1/Kconfig > @@ -4,6 +4,7 @@ config VIDEO_ROCKCHIP_ISP1 > depends on V4L_PLATFORM_DRIVERS > depends on VIDEO_DEV && OF > depends on ARCH_ROCKCHIP || ARCH_MXC || COMPILE_TEST > + depends on PM > select MEDIA_CONTROLLER > select VIDEO_V4L2_SUBDEV_API > select VIDEOBUF2_DMA_CONTIG > > --- > base-commit: 27285b099fbc5cb2ae3aef20f3bbd7b3c88b3005 > change-id: 20261102-rkisp1-depends-on-pm-219d94239b56 -- Regards, Laurent Pinchart