From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C2CE60A5BDD for ; Wed, 4 Nov 2026 15:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ah4iRZxO; dkim=pass (2048-bit key, unprotected) header.d=deq.rocks header.i=@deq.rocks header.a=rsa-sha256 header.s=securedbylima-20251205 header.b=Na/adWXn DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=AiY2yui9DQjU6dkBTFrcvq3Sdje7Pd4O5PPdTtK3bDs=; b=ah4iRZxOkAwYBX a1/QYbr989xN6UKtf9U7GhpGYhuu4BYWSPUMaO2bSnxvwe/7MzW6GTuSo2VGBGMITRhGmRKd40yUO l1rbTZ+n9nAC/u4jCZXE7GfFIJ8zcveGhUdYtTBaqZGEi2inKqv2b0xe7lNqQUrxkIW+SwK3KWCip IXeMXuMn4WRfHwnyKMZ0pC3ICyqzWvtgYiM1du4R20aud6h+0LSqebNTgqSRGO56dwpkPz6kGtAlp q6BKs0vo6tDGp+uYeQpgmswQICAA79mtnD+9SaDidLtkBxIrJzgdncAsOdsuGGvSy9Pn35SQGa7Ao pp0SyeQMF/wX8E2e+4hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOciu-00000005kB3-0Qqt; Wed, 04 Nov 2026 15:16:24 +0000 Received: from bulk0.mail-out.lima-city.de ([91.216.248.212]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOcil-00000005k1c-2eZE for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2026 15:16:16 +0000 From: Andre Eikmeyer DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=deq.rocks; s=securedbylima-20251205; t=1793805373; bh=gJ97BxnBMFL4vlZaqEERaFBjAerkYWWjMKMV9bTKY+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Na/adWXnVWlf3d1npu9w6rvFzPG8JEFeEbHlld7ytt6E0TqwnABqWqGVAhWvDbMqY so8EvrcKJi62VsMXLJ4KZJ2d2qT57RxQfmz8bF3IdaL2wOoCnH7zCaQeJv3HtbSfYW QMqt7bb3hk/Pd2fi3XrnXI7zdViQ94Lua0Bk80L1CaTE1ZU33AoGa+Kks01uQCQ3mW TucYRdQJnpLjuvSZWy6gWG75e8XMoJU8QW6IRgIpy4+JG6Yb/okzp8layqXvo9AC++ 2DCC0tbAwFaqGUj5PdHx5m+qNf6dqLnzGdGZUiGGUbziYp/ZbfoH+ZSnQoV3IVwl5t onZGb8qEcIHhw== To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, sven@kernel.org, j@jannau.net, neal@gompa.dev, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, 66ton99@gmail.com, josemiguelo.ochoa@gmail.com, aditya.garg@linux.dev, Andre Eikmeyer , Yossef Osman Subject: [PATCH 3/4] Revert "Bluetooth: hci_event: strip Broadcom vendor bits from legacy adv report type" Date: Wed, 4 Nov 2026 16:16:00 +0100 Message-ID: <20261104151601.70493-4-dev@deq.rocks> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261104151601.70493-1-dev@deq.rocks> References: <20261104151601.70493-1-dev@deq.rocks> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261104_071615_827523_4FC981FA X-CRM114-Status: GOOD ( 10.28 ) X-Spam-Score: -2.8 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 This reverts commit 88397423671f2b54119a6162a1834d207dcf1a81. The commit clears the upper bits of the legacy LE Advertising Report event type for every controller with manufacturer 15, Broadcom. The reports of these bits, in its own commit message and here, all come from the Broadcom controllers of the Apple T2 Macs. The previous patch clears the bits in hci_bcm on Apple machines and in hci_bcm4377, the drivers of these controllers, before the event reaches the core. That makes the check in hci_le_adv_report_evt() redundant for them. Tested-by: Yossef Osman Tested-by: Aditya Garg Signed-off-by: Andre Eikmeyer --- net/bluetooth/hci_event.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 736dd2f741e..0675c224f6c 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -6683,17 +6683,6 @@ static void hci_le_adv_report_evt(struct hci_dev *hdev, void *data, hci_store_wake_reason(hdev, &info->bdaddr, info->bdaddr_type); - /* Broadcom ROM firmware (BCM4364B3 on Apple T2 Macs, no - * patchram) sets vendor bits in the legacy Event_Type. - */ - if (hdev->manufacturer == 15 && info->type > LE_ADV_SCAN_RSP) { - /* 0x0f masks out upper vendor bits (0x10, 0x20, 0x80), - * extracting the standard legacy advertising type - * (0x00-0x04) stored in the low nibble (bits 0-3). - */ - info->type &= 0x0f; - } - if (info->length <= max_adv_len(hdev)) { rssi = info->data[info->length]; process_adv_report(hdev, info->type, &info->bdaddr,