From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4639D606A329 for ; Thu, 5 Nov 2026 00:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=L7zI86yR; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=d/1758ii; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=NMyvpQvO DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=zVQeXawDrt23PfxpSVgUQcYKvrbayL+kqPTtMOiJzmo=; b=L7zI86yRcnI6Hn 72469BsYylC6kI146WmUaEPRohC7bpVsrkzRGeP5ka+j/+gXXK4hDxicCNrf+FpbiQfeNhK64F7Bp vSaFy0KbMA0Ck9dg/+kX10oedpvNsIvX+PxVsqr95TImn9iWcFAhZPXLWyUEuHoJPkI+Uh2nVQqx1 qNjtp8urov9qpqZQNIjKciK3obIMbKNUAP4rsyL+0bgleHGrZoZ9UL6UvMP15IN8X8sFsk8icnARq nDPbRBiZAW/Jcss+hpT8YeizpVqjOghYuXwIxAWK563a7iZ+HgGlbUp4LNBfwyH17AOaBOTcr82W5 04VvomGpXuUbQTDrvWGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOl4t-00000007KHx-0Vlc; Thu, 05 Nov 2026 00:11:39 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOl4q-00000007KHc-2PgB for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2026 00:11:37 +0000 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A4M6Gtl1692569 for ; Thu, 5 Nov 2026 00:11:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zVQeXawDrt23PfxpSVgUQcYKvrbayL+kqPTtMOiJzmo=; b=d/1758ii96ozVzWf BzzbSupEWj/IFudrwFQhlL0mxAy495leOOosbr+TuXez5+xLgMEe3AEPxL0W6b9r Uj8Pf8nlU8Hg1gZWQKTep2g869qG9qoiRJR5nYSwGz8WipojGnfUTNiuOm+oa7NS FZgygGxzyCOhlXNXdNNfPU0oH7nT2juze6RJ2RlTQAm3B9dcGAIPgLiSDlC+9jtB I74mO2jf+pOWK/kwSF7Xc6iKzcoLHVJFFYrHp+aeVlmb05UGSvZhqzS30AJjzTW9 QWD3AGHJ9Qt6WVdxNu6ZCV9UwugkXsxhv1vnJG7lN7AdAkpI8Pjxayn4QYQAyWwT erYWuQ== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hr6br28vu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Nov 2026 00:11:34 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-1ab289bb41eso142237c88.1 for ; Wed, 04 Nov 2026 16:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793837494; x=1794442294; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=zVQeXawDrt23PfxpSVgUQcYKvrbayL+kqPTtMOiJzmo=; b=NMyvpQvOyRU6Oh4Y2nnyaOZMNWS1bHCQwCrPzNP0cDpU0FG7j/URCAb59nVH8BavKw CizMTgrMLRi6iFLbqid0KbRCdlmgZA0qGNy8XO2YxgHNNvKCGDayYYu3gHSuUBlwmjVZ MiFEJNtEWs76MPn4iiITL3jJusSxAwzE253ovf1XEY9Rl2XIsujlXgFYX6NPS1BQ8VXp T/umJf1SoPlh6jn2xscJ7GHq9WJ/0rMv1MTJ5wTC72tKDH58bh+S/Bmx+q3c05cMmx/5 3Hzb+c5b4z9si077pJnbdjN0qaS72wJUjJUWMMhPGe0762/GpvWZXNWPU+qTpiGDyeqD VRkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793837494; x=1794442294; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zVQeXawDrt23PfxpSVgUQcYKvrbayL+kqPTtMOiJzmo=; b=SXtRo6b3U/16umfFk7T+CWpnkTr8SrYlTXOgIjLmsFiP/NpHOp/Bxj/BbCTrg0nqVu hBdPu8bI2sImm8U+tdK13MpNnOGOFV3M639R87q2DIwTxF5AcK8o0P5ceR6gmmIr/HsL yTipVeW5A+2KxoU8CWuHfdH8ZKnuG3nBTup6/wJ9Wyreu9mwMFg85/pJ9ANQRaR1roFu g7cobzevFj3YL+bnisrv5SXZqnPZ9KMvNSsPhrWI7Yk5laQ4qennt6X69zN7Oh59NGbp 7Tr5UfymktnTvls9ZCxARbkJcX0Oc3eRjDdfdBHxyXZicV/+dEuAD/A+rwlpkoHM7MwV wIsw== X-Forwarded-Encrypted: i=1; AKwUvBxlIe3RtOvOc2asPGQ4USAoDWOtWNbe/giSunGvPhLOMGo+wVYIxhNIQGbKx3sbwTXeiy7O5NXIzHNp4BolMA+E@lists.infradead.org X-Gm-Message-State: APuU4Z9jzlqEVpPggu53tRTMQTh20Yl0X1q60WU2H9KKdeGcKab6MTLa PafYq9JJln2BNsZqmuUUrPW3vx5sDGuwadbWxGGoZmTQNW5A8PQ31sgoIolL9XKNEeNSeR5Wq/U JKytVv2Z+RqQ+KMgV1vyIFk1Pzp+QcS8mz6LY1bFUhn/pabnXOUi0snb7R4TyCiEqQqC22e5gyA Og9A== X-Gm-Gg: AYBFou3RnCxWjFrk85ZhjZX3ebqZpKJVKKgTQ6xzD26UunREMhXB/VMp5MeqhA/bBtv YvWFTyKl7u4mA4Avyq0RKofwUvwFzL8XtnPEl6F3cZe1uNWCZ9m+hZgceSMbpvn2WpWnOzeP7Y2 ZEXxmlxahSuvzMYOT23qmH+oMx2LvfLzSngTHFE1RAUHJxloC0Ivi1wkC4IqpvaEKGt1B/n51CZ tf3ZBwl7xl3no2XQoIRLInKFJ6xJhbQ9/B31FXUCcmM0fkjE9pu+TPVihP/OACNu7CDjyxx5LnI z2fst0P7dkR0VgkAH6ceDC6/Jnu54dRjGOm00zOGylO5LdjCRPZ1kBeOIz7hIKpLPAJgh7dx+yW 6DueyHe+y1eS6dNfdb3TKbgijfzQEjWri89+MmerTIfYGKWKA+wt+XNLooAAoxXxi60yV8LTn4B DBheMc8HkjWh9TJYAZUiIhzticWg== X-Received: by 2002:a05:701b:418c:10b0:1a7:4c5f:57e9 with SMTP id a92af1059eb24-1b24f4e4cdemr1394429c88.27.1793837493649; Wed, 04 Nov 2026 16:11:33 -0800 (PST) X-Received: by 2002:a05:701b:418c:10b0:1a7:4c5f:57e9 with SMTP id a92af1059eb24-1b24f4e4cdemr1394386c88.27.1793837492930; Wed, 04 Nov 2026 16:11:32 -0800 (PST) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b245c1c272sm10961037c88.8.2026.11.04.16.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 16:11:32 -0800 (PST) Date: Wed, 4 Nov 2026 16:11:25 -0800 From: Jonathan Cameron To: Andy Shevchenko Cc: "Rafael J. Wysocki (Intel)" , Thierry Reding , Arnd Bergmann , arm , soc@kernel.org, Jon Hunter , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Len Brown , linux-acpi@vger.kernel.org, Lorenzo Pieralisi , Sudeep Holla , Hans de Goede , Jonathan Cameron , Mika Westerberg , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , James Morse , Ben Horgan , Sizhe Liu Subject: Re: [GIT PULL 4/7] firmware/tegra: Changes for v7.4-rc1 Message-ID: <20261104161125.00000523@oss.qualcomm.com> In-Reply-To: References: <20261003095924.1370238-1-thierry.reding@kernel.org> <20261003095924.1370238-4-thierry.reding@kernel.org> <928b3eaf-32da-43a9-9ca5-d59ef8a3b330@app.fastmail.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA1MDAwMCBTYWx0ZWRfX+uVeiXVCn+xi SlqvALtHKjhM40Xt/Afb99Bzc3U0fuHZ+bMMzgnkHl+goU9qb0KdsFsKMA0KrXk9yTZZGELmARd V7vsh17DsYnfWsmMn2Jk9Zl7s4uSHCBgFUzF5mKuG23TIWVdkCtNf8lDIapUmDGAI62VBoPRPM5 tisQTMNp2cC8HZE3fnVknlooKDrQ2XOgSb5RVOkCUPqmzXocrGvQ4fWl6PTqYSvY6KV5hRpLzs+ nymAO95tESnHNfg53mkODF8k3HxQUvmm8lE6Ui9k9YccydG5tkCy+EUKuSerLdREmKNxJVZ3gGz YH3PMmYEhj8S68LzfFHWAzZb9ofhofZVHUdjlH9WjP/dhZkET60rqLIrb3gDRaTlfdq7GP3+ypu yVPL17eMFwhr0w45q2z7LJeQh4gXRpY8On5Qg/CWgnFOC70wOBHMf+4vQmItBZ1XSbybTpXKTmW qz11n6oUtRuSZEnquGQ== X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA1MDAwMCBTYWx0ZWRfXxn5EVeTArx/E O8oqMmRn0fKLHf8uUm8/2PGotvgGhJ5RAyUPtbAeRPmaxYIc45RzRCcNH/85kRgpPLlyts70Iwb 8ioK1qFCGso3LwoLsTfAKZv+DVZ3e00= X-Proofpoint-GUID: nqIjrdyEuU11YVkD7DNTKF7kI_40DV5z X-Proofpoint-ORIG-GUID: nqIjrdyEuU11YVkD7DNTKF7kI_40DV5z X-Authority-Analysis: v=2.4 cv=futJ914f c=1 sm=1 tr=0 ts=6aebc9b6 cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=Ikd4Dj_1AAAA:8 a=QyXUC8HyAAAA:8 a=t4CJLuyQXvHctLNzf8QA:9 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-04_05,2026-11-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 bulkscore=0 spamscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611050000 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261104_161136_645114_997481E9 X-CRM114-Status: GOOD ( 70.48 ) X-Spam-Score: -2.8 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, 4 Nov 2026 19:08:01 +0200 Andy Shevchenko wrote: > On Wed, Nov 04, 2026 at 05:28:18PM +0100, Rafael J. Wysocki (Intel) wrote: > > On Wed, Nov 4, 2026 at 3:41=E2=80=AFPM Thierry Reding wrote: =20 > > > On Wed, Nov 04, 2026 at 03:11:09PM +0100, Arnd Bergmann wrote: =20 > > > > On Wed, Nov 4, 2026, at 13:42, Thierry Reding wrote: =20 > > > > > On Tue, Oct 13, 2026 at 07:22:23PM +0200, Arnd Bergmann wrote: =20 > > > > >> On Sat, Oct 3, 2026, at 11:59, Thierry Reding wrote: > > > > >> > > > > >> Where is the ACPI binding documentation for this driver, and who= is > > > > >> responsible for reviewing it? =20 > > > > > > > > > > Sorry for the late reply, this fell through the cracks. > > > > > > > > > > Admittedly there's not much of a formal process here at all. Anyt= hing > > > > > I've received up to now seemed to be fairly straightforward suppo= rt > > > > > extensions like this where the ACPI tables basically provide the = same > > > > > information as the DT via standard resources like register ranges. > > > > > > > > > > I suppose for anything beyond this, we'll want better documentati= on and > > > > > broader review. > > > > > > > > > > Is there anything in particular that you're looking for? Should I= guide > > > > > people internally to always Cc linux-acpi for anything that conce= rns > > > > > ACPI? =20 > > > > > > > > I don't know, I'm also still learning about how this is done, I > > > > was hoping that there was already an established way. =20 > > > > > > Yeah, me too. Maybe Rafael and Len can provide some guidance here. =20 > >=20 > > I cannot speak for Len, and he has not been actively involved in the > > maintenance of ACPI support in the kernel for several years. > >=20 > > As far as I'm concerned, the code maintained by me is mostly located > > in drivers/acpi/ (as per the relevant MAINTAINERS entries) and it is > > mostly generic code related to ACPI support. I generally don't > > maintain device drivers using ACPI support except for the ones under > > drivers/acpi/ which mostly bind to devices representing interfaces > > defined in the ACPI specification (which is kind of a special case). > >=20 > > But there is more. There is ACPI support code in other places (like > > for instance gpiolib-acpi maintained by Andy and Mika, or platform-x86 > > drivers maintained by Ilpo) and there are experienced kernel > > developers in the ARM ecosystem with quite a bit of ACPI-related > > knowledge (Hans, Jonathan, Sudeep, Lorenzo - all CCed) who can be > > reached out to for guidance (and arguably they have more experience > > with ARM platforms than I do). > > =20 > > > I don't know how ACPI on more traditional platforms works, but I imag= ine > > > that it's a lot of the same anyway, except perhaps that people have m= ore > > > experience with the spec and today might be doing a good job already.= =20 > >=20 > > If you have any specific questions, I think I should be able to answer > > at least some of them, but I'm afraid I cannot give you general > > guidance on how to do ACPI support in device drivers that would be > > universally useful. Different drivers have different needs. > >=20 > > There are things in ACPI that are not present in DT and vice versa. > > It also depends on what bus types we're talking about (platform vs PCI > > vs USB etc). =20 >=20 > And don't forget the big player(s) such as Microsoft that from time to ti= me > creates an "extension" to the ACPI (in means of additional tables or how = some > of the existing data should be interpreted if it's not clear from the ACPI > specification). For instance, above mentioned USB ACPI support for some c= ases > heavily relies on the MS "extensions". Or earlycon support for ACPI is ba= sed > on MS defined SPCR table. And so on... >=20 > > > > Having a review done by the ACPI maintainers would definitely =20 > >=20 > > So as per the above, who exactly do you mean by "ACPI maintainers"? > > If you mean "the people maintaining the code in drivers/acpi/", that's > > just me and quite frankly, I'm not sure if my review, specifically, > > would be super-useful for driver development (the fact that my review > > bandwidth is almost completely saturated nowadays aside). > >=20 > > My recommendation would be to ask other people within the ARM > > ecosystem who have more experience with ACPI for help. > > =20 > > > > help from my point of view, but I'm not sure whether they are > > > > set up for that, in case there are a lot of new drivers. =20 > >=20 > > I am not and had I been trying to do it, it wouldn't have scaled anyway. > > =20 > > > I think platform maintainers need to be a first line of defense here > > > since they sit at the intersection of a lot of this. At least that's = the > > > case for me. Also, I'm eager to learn how to do this right, but I'm > > > often at a loss of where to start. The spec is a bit daunting, and th= en > > > there's various extensions, too. Maybe the AI genies can help me ramp > > > up. =20 > >=20 > > My advice would be to reach out to people within your ecosystem in the > > first place. It is a bit of a guessing game to figure out who are the right people today when it comes to ACPI and both ARM and x86 platforms.=20 They fall into a few categories and it depends on what you are trying to do. Starting point is push back hard on your firmware folk wrt to shipping something random without an upstream discussion first. You wouldn't expect that to work for dt, it shouldn't work for ACPI either. Features will get rejected if people try to just do something that works for them (same as a weird custom DT binding gets rejected). 1) Basic stand alone driver stuff. Mostly that's all pretty standard and follow the specs where possible. If there are gaps start asking questions. Linux definitely doesn't support all the stuff that has been added to the spec in recent years. So this covers things like register addresses, interrupts etc. All fine, hopefully a subsystem maintainer can take a look and will have enough of any idea. If not ping the folk on this thread for help. Things are a bit flexible for consumer type devices where fixed and bodges are common, generally less so if it is server grade hardware. 2) Stuff that is an ACPI spec gap or place where we'd expect generalization. There are several examples of this on list this week and a few more in my inbox. The particular series here might fall into this category. I've not figured out enough of the details yet to say definitively. I'd also expect a driver using AML as the target interface to either point at a published spec doc, or to include some snippets of the AML - that can be a lot easier to read than the driver code (imagine reading DT by only looking at how drivers parse it). FWIW The driver feature in question looks like it is doing something a bit = similar to the PCI trace and tune driver Hisilicon has (though IIRC that has a presence as a PCI driver) https://docs.kernel.org/trace/hisi-ptt.html or if you squint at it differently resctrl / mpam fb. Given that has new ABI etc, I'd expect that to have gotten broader review as well. Probably keeping it to linux-tegra and lkml alone wasn't going to result in anyone noticing! https://lore.kernel.org/all/?q=3D20260929095915.2215685-1-anrao@nvidia.com Anyhow, feel free to reach out if you want some feedback on this or similar. I can perhaps at least point you to someone who knows a specific area better than me. Jonathan =20 > > =20 > > > > I assume there is a knowledge gap in both subsystem maintainers > > > > regarding ACPI (certainly this is the case for me for drivers/bus, > > > > drivers/firmware, drivers/soc, etc) and ACPI maintainers regarding > > > > many of the subsystems that we support with DT. =20 > > > > > > Agreed. I've seen some patches where the ACPI support was as simple as > > > just adding an ID table entry and the rest was all standard, but I th= ink > > > once we move beyond standard resources things might get a bit more > > > complicated. I imagine that ACPI may not even have specs for certain > > > aspects that we currently handle in DT... =20 > >=20 > > That certainly is true, but the ACPI specification is under active > > development and pieces that are missing can be added to it. There is > > a process for that in place and ARM people take part in it. =20 >=20 >=20 > On top of the above in Linux we also developed some "extensions", for ins= tance > how I=C2=B2C muxes are described, or how some multi-functional devices ar= e being > enumerated. These specifics we usually document under > Documentation/firmware-guide/acpi/ (see i2c-muxes.rst for the mentioned c= ase). >=20