From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 431CD606A31C for ; Sun, 8 Nov 2026 07:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fbFhYjrU; dkim=pass (2048-bit key, unprotected) header.d=gahingwoo.com header.i=@gahingwoo.com header.a=rsa-sha256 header.s=fm1 header.b=R9B7rd3B; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=SUSj9R92 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=g+huM/NKQcWUPIHptRetUeMwbx85L5S5iTYg0Z/daLI=; b=fbFhYjrUr032SL 99ehKqt2PWjHlN9dl06YwTjcWD7XwNwcArUi8OdL+4rQSxFnLuAF0EArwI22fW683kSARB2pUUsDu vFeCB0WfvuAQcNHvDDkGZEvalPCrArpRQbgbEjGxt7vXpSY9zrJVd6u0guSpLtY44SjiKonWrRlcN PCVaC0nWJh9yY2lp76y3hCN40FnNenOEoLbQPssuzT33IEZXoDoL0o1VajN4BBHcSTJvFMC6igUFc nPGcn8/5r4nxKG3tK3HZrcBZ+iUUDpmMchnq/ZIKB72okQC70/heompmm/yLaURvqGDPTSK5yMIph E+EBT1cn/R2rgigNhyDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPwvu-0000000Fl9P-0FtA; Sun, 08 Nov 2026 07:03:18 +0000 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPwvs-0000000Fl8E-068g for linux-arm-kernel@lists.infradead.org; Sun, 08 Nov 2026 07:03:17 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 7ABBA7A00CD for ; Sun, 8 Nov 2026 02:03:15 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Sun, 08 Nov 2026 02:03:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1794121390; x= 1794207790; bh=g+huM/NKQcWUPIHptRetUeMwbx85L5S5iTYg0Z/daLI=; b=R 9B7rd3BNViMdbqCN7hT0qGarpy5PElWmNgzdzFb3oRUQysN0QM+msxh8vpE6q860 C84iTsUdQJVN2PySbKhRXzzdP4wjLMU76pI6ellidwPqyWW5yKgb3mrpEmZPAik3 x/CSl9sTGwYW7bnmXeg3X0alHDJjZXAdJuLnDP9MbktXzPWiLCEYYgYr03I13eC+ Y4CsbTVIinxcabL36dmnoMfwnUEHME6B0nsb81gM8RVEcmHMu4WJ7Pb1JvbuplCI FsG1o9cWwPuSJ1++K7w2R4XxRw/1oGR1W5qz9B2U+Bpe1PVZ3Y/mhBAKnX1fxRLD ZnzrlPWzQRevdz+HlrH0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1794121390; x=1794207790; bh=g +huM/NKQcWUPIHptRetUeMwbx85L5S5iTYg0Z/daLI=; b=SUSj9R92P/31qNtCS OqosTKcFxMDG1WcjIxvRlG0J++v9Al5G6XNzAAM48s62Y2HMbHdFu5W9kdJbWk0x KL3LxfhHxtUzGed5aOrjq0nEeZJ4XcJ9MUmXuSMBNNE3bMDk/lYAvyvYV0a7khss +fuHOOO/gbmb4ALw1lxTH2KtPPvkNxylkI2WusIca92PwXCWYAWqiQqrGCjJb4Pr +q61Fj29LtaOG3H3MmVs7ep5tjiulbQ6zlKCEll6H7sXSVbC7JHjgHxkUNmOHUhJ HpYyU3Dyg4lzi5VUZwXMQHIhEkoHOMF5JttGtSKMPrOhlMEUWsikVattHoTwmZJn 8Q4NA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=gahingwoo.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794121390; d=gahingwoo.com; mf=PGdhaGluZ0BnYWhpbmd3b28uY29tPg==; rt=PGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZz4=; s=fm1:rsa-sha256:VhXRFbRVqoJ0UIZklPJ+UdPq0JoInN1Y8cCJv6gEFs7l8Ya +Rjou/yg5moXih0RiqYhPkakJiEAdP9gFE4ee5id9a5mf4XqQL19q2gr7t1ngs/d K57M2tiuQcQ8MAD1nBJQdbU/GUbAxpl8HXFa2KWRNR47jUSFjEAEcA2QSufi2vUJ sZOgW4hH9hmhUMxgBvsLTKste5iZ+xEPHsyhnZHgOd6PmM6BOu6KkfsofTpzzJKB mpBI6QwLEpTf5hMSUNSHD0zof+Y8rAAmb93Z4Iuu6m6hV4c8RIyH1ByT2KeQed3p VlIW2KeJNpnjjrJUsp8N2CKtXhc8SOYasNxs02g==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-transfer-encoding,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:vdaGr8RqO7sU/de1fBqcB5bQ1dSYXkuJ1evB9fZmycQ=:EHpEhZcDNXxevg9L8+GX0gX62PoVMOoLNiKInDNyB3k=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFKhclCCJN9i5LFQp5fvn9DylL5PDR95+qcmUDEkBDvAaUlhVhO6JW1PTcA0oiilr afxU+kS37MwfkRVrV2sLhNS1OkBSH9hrpfUYkvEeAEfTx8oUhC1lvQdEqsrvfO12L2kPDm Y90xvEv61R5vWsABT3XVmqKcWsSTBPoQRHs33ySAWpN7mh8mIX7nfmpu6Q5St0DdZLVl6o GJpMHUC7TjUVqLMHfqfKk9SHn10f5lL6CdG6YeehrsosttZtbM1aNiFk46XYC+svmJcMBn 4w1I3sJZaXrv8SSndHCWUOH7cbPZHBY65Sr1oZjnZZRxSV2wTTFO+3xU/Lmvhk4YCMlhJv ZSSK/ZaNH8UYgys9cYpUBi0V9VivVdlDRnsl6Hr9yZAEYPUinUlA/9oH0xC3P9C+I18X2q 1KJ2ZzPpUcgaIXPpZ7avIxu/qr+KgduGQFTh+LzlOQHAASQLngIATaHg+Dp3Sp4YEIR5TU u+M5rXYGRNkY4eDT7EOXjaqj9ebW7EF2KUq8wuM4okv4IL/RzZc7V3i5cKG+T2Ncu0bRHZ HVzDZ4RL0aiLEDMcmvJ0qFknSKMG2Y6uDDpidBQk274C8JvgDurwlqMIF2LxPWS1XVnfRb NbAlsSxA8tTXvFFzBM2So3mQjkx3nDX4xYaTEKfCF+vlS0u8SY2fT070HP8A X-ME-Proxy: Feedback-ID: i7a5e4b5f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Nov 2026 02:03:01 -0500 (EST) From: Jiaxing Hu To: tomeu@tomeuvizoso.net, heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, ulfh@kernel.org, p.zabel@pengutronix.de, ogabbay@kernel.org, zhangqing@rock-chips.com Cc: royalnet026@gmail.com, abel.vesa@oss.qualcomm.com, sebastian.reichel@collabora.com, sidong.yang@furiosa.ai, u.kleine-koenig@baylibre.com, chaoyi.chen@rock-chips.com, shawn.lin@rock-chips.com, finley.xiao@rock-chips.com, diederik@cknow-tech.com, alchark@flipper.net, leonard@lausen.nl, jeff.hugo@oss.qualcomm.com, rfoss@kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiaxing Hu Subject: [PATCH v16 13/16] accel/rocket: add a GET_PARAM ioctl for the hardware version Date: Sun, 8 Nov 2026 19:59:14 +1300 Message-ID: <20261108065917.135194-14-gahing@gahingwoo.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261108065917.135194-1-gahing@gahingwoo.com> References: <20261108065917.135194-1-gahing@gahingwoo.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_230316_096632_90FC1298 X-CRM114-Status: GOOD ( 18.05 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Add DRM_IOCTL_ROCKET_GET_PARAM so that userspace can query the NPU hardware version and pick the matching hardware description, such as the SRAM configuration and the register layout. Add DRM_ROCKET_PARAM_HW_VERSION, which returns a hardware version enum that matches the device tree compatible. The enum starts at 1 and 0 is not used: RK3588: 1 RK3576: 2 An unknown parameter or a non-zero reserved field returns -EINVAL. Signed-off-by: Jiaxing Hu --- drivers/accel/rocket/rocket_core.h | 1 + drivers/accel/rocket/rocket_drv.c | 29 ++++++++++++++++++++++ include/uapi/drm/rocket_accel.h | 40 ++++++++++++++++++++++++++++++ 3 files changed, 70 insertions(+) diff --git a/drivers/accel/rocket/rocket_core.h b/drivers/accel/rocket/rocket_core.h index d5d353cc38e7..13d962467ff0 100644 --- a/drivers/accel/rocket/rocket_core.h +++ b/drivers/accel/rocket/rocket_core.h @@ -31,6 +31,7 @@ struct rocket_soc_data { unsigned int num_clks; unsigned int num_resets; bool task_con_16bit; + u32 hw_version; }; struct rocket_core { diff --git a/drivers/accel/rocket/rocket_drv.c b/drivers/accel/rocket/rocket_drv.c index fff31c1ebe52..c094f6843095 100644 --- a/drivers/accel/rocket/rocket_drv.c +++ b/drivers/accel/rocket/rocket_drv.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #include #include @@ -129,6 +130,31 @@ rocket_postclose(struct drm_device *dev, struct drm_file *file) module_put(THIS_MODULE); } +static int +rocket_ioctl_get_param(struct drm_device *dev, void *data, struct drm_file *file) +{ + struct rocket_device *rdev = to_rocket_device(dev); + struct drm_rocket_get_param *args = data; + const struct rocket_soc_data *soc; + + if (args->reserved != 0) { + drm_dbg(dev, "Reserved field in drm_rocket_get_param struct should be 0.\n"); + return -EINVAL; + } + + soc = READ_ONCE(rdev->cores[0].soc); + if (!soc) + return -ENODEV; + + switch (args->param) { + case DRM_ROCKET_PARAM_HW_VERSION: + args->value = soc->hw_version; + return 0; + default: + return -EINVAL; + } +} + static const struct drm_ioctl_desc rocket_drm_driver_ioctls[] = { #define ROCKET_IOCTL(n, func) \ DRM_IOCTL_DEF_DRV(ROCKET_##n, rocket_ioctl_##func, 0) @@ -137,6 +163,7 @@ static const struct drm_ioctl_desc rocket_drm_driver_ioctls[] = { ROCKET_IOCTL(SUBMIT, submit), ROCKET_IOCTL(PREP_BO, prep_bo), ROCKET_IOCTL(FINI_BO, fini_bo), + ROCKET_IOCTL(GET_PARAM, get_param), }; DEFINE_DRM_ACCEL_FOPS(rocket_accel_driver_fops); @@ -227,12 +254,14 @@ static const struct rocket_soc_data rk3588_soc_data = { .num_clks = 4, .num_resets = 2, .task_con_16bit = false, + .hw_version = DRM_ROCKET_HW_RK3588, }; static const struct rocket_soc_data rk3576_soc_data = { .num_clks = 6, .num_resets = 1, .task_con_16bit = true, + .hw_version = DRM_ROCKET_HW_RK3576, }; const struct of_device_id rocket_dt_match[] = { diff --git a/include/uapi/drm/rocket_accel.h b/include/uapi/drm/rocket_accel.h index d0685e372b79..597bf892c96d 100644 --- a/include/uapi/drm/rocket_accel.h +++ b/include/uapi/drm/rocket_accel.h @@ -15,11 +15,13 @@ extern "C" { #define DRM_ROCKET_SUBMIT 0x01 #define DRM_ROCKET_PREP_BO 0x02 #define DRM_ROCKET_FINI_BO 0x03 +#define DRM_ROCKET_GET_PARAM 0x04 #define DRM_IOCTL_ROCKET_CREATE_BO DRM_IOWR(DRM_COMMAND_BASE + DRM_ROCKET_CREATE_BO, struct drm_rocket_create_bo) #define DRM_IOCTL_ROCKET_SUBMIT DRM_IOW(DRM_COMMAND_BASE + DRM_ROCKET_SUBMIT, struct drm_rocket_submit) #define DRM_IOCTL_ROCKET_PREP_BO DRM_IOW(DRM_COMMAND_BASE + DRM_ROCKET_PREP_BO, struct drm_rocket_prep_bo) #define DRM_IOCTL_ROCKET_FINI_BO DRM_IOW(DRM_COMMAND_BASE + DRM_ROCKET_FINI_BO, struct drm_rocket_fini_bo) +#define DRM_IOCTL_ROCKET_GET_PARAM DRM_IOWR(DRM_COMMAND_BASE + DRM_ROCKET_GET_PARAM, struct drm_rocket_get_param) /** * struct drm_rocket_create_bo - ioctl argument for creating Rocket BOs. @@ -185,6 +187,44 @@ struct drm_rocket_submit { __u64 reserved; }; +/** + * enum drm_rocket_param - parameters for DRM_IOCTL_ROCKET_GET_PARAM + * @DRM_ROCKET_PARAM_HW_VERSION: an enum drm_rocket_hw_version value. + */ +enum drm_rocket_param { + DRM_ROCKET_PARAM_HW_VERSION = 0, +}; + +/** + * enum drm_rocket_hw_version - the NPU, one value per DT compatible + * @DRM_ROCKET_HW_RK3588: "rockchip,rk3588-rknn-core" + * @DRM_ROCKET_HW_RK3576: "rockchip,rk3576-rknn-core" + */ +enum drm_rocket_hw_version { + DRM_ROCKET_HW_RK3588 = 1, + DRM_ROCKET_HW_RK3576 = 2, +}; + +/** + * struct drm_rocket_get_param - ioctl argument for querying a parameter. + */ +struct drm_rocket_get_param { + /** + * @param: Input: an enum drm_rocket_param value. + */ + __u32 param; + + /** + * @reserved: Reserved, must be zero. + */ + __u32 reserved; + + /** + * @value: Output: the value of the parameter. + */ + __u64 value; +}; + #if defined(__cplusplus) } #endif -- 2.43.0