From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 174EF606A31A for ; Sun, 8 Nov 2026 07:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=V3D4SeSJ; dkim=pass (2048-bit key, unprotected) header.d=gahingwoo.com header.i=@gahingwoo.com header.a=rsa-sha256 header.s=fm1 header.b=T1db98wB; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=0MpJD2Y2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=xh4FDfpKCu1l07Q85vVWgq/0/rjVj2rTpjI3ZLXV+Vc=; b=V3D4SeSJQj2Cw9 qKTxeYtPaFhS0ONscTtFVCMbZqNADkMreH2onyq74evVSW6j1IfMnTqq2lEEZ9GGOmR1HK/iY8OHi i18+NeaJrANWh26eESp2cjL/aOtzz9GtCqPfgZ4VCH0Bgkcfmb0zs204RExPx4PqnEwhlKJM6ag7j +8lWAhK4mb+85e4Vf71w3C0GyjmMQj0jDNUVQbbSTajZMmekoA4T+NE/eKFpK+qW1KfLRFIlqwqO9 FtwjiC5XhTVRsfXt2L77AWtVl8xYOh0MglHNTCLmNmeNhrpgA2pjJANTliOOIyZPdUvN44Cs4OALg sE4S6slGOOLwxG0Y1MOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPwsu-0000000FjMH-3ZBM; Sun, 08 Nov 2026 07:00:12 +0000 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPwss-0000000FjKh-1JJz for linux-arm-kernel@lists.infradead.org; Sun, 08 Nov 2026 07:00:11 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id C138F7A013F for ; Sun, 8 Nov 2026 02:00:09 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Sun, 08 Nov 2026 02:00:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1794121205; x= 1794207605; bh=xh4FDfpKCu1l07Q85vVWgq/0/rjVj2rTpjI3ZLXV+Vc=; b=T 1db98wB92XSaeJ3Vy0yeD+OQDZS9MTgAyJ9P7A4nwqFWKBuCWREV237hjEhBJV/V oONrmNtvNpCsYNlt43HL8tGFRCxSvq74eB2JBzyZ1J8YCwqWnWH5mx+hZl6XMe/3 9EhCHyOOeAIu4uBrRUF0a+c68Wktzv4fPawKEOR4dIhdMlnQ+w3CAqnljoxEAURW b3hpvpJ94TPvQsbfU2KaOncfTno54Xq3lhKvFYiq4lv6u7AxvhNR+TXc3tUTYhF7 oJVQW6BxTQqIbNoUTXhDEv18XU9ECc8YwNCUJaDhbaZ61QC6JkPa8uucZ9SO44yV O5hgat+JYFwLRgIVTWxhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1794121205; x=1794207605; bh=x h4FDfpKCu1l07Q85vVWgq/0/rjVj2rTpjI3ZLXV+Vc=; b=0MpJD2Y2A2M02KiNW 3e1Swp1HsZIJki7ELLy3oeDBNiWbQ0AMSN1lLoaL+fkJVVzXDaihQd6PUqTrP6sY nAHXT/3UGeqjWpzAMj6jN1YvVJl5kbNZocUFarhxywMlcSpalu1Y/E2P3IqslX7z A24VC5kZoLhdrxAHypTRoJh+xWtv1LzaJibx0v5ErD7KbOP3inKLBdS9T9xbTacV MbLwKmL/k9y2C4JI/UBHAIxsDgAltk2rpFH2UXRmyaxPNfbnFL5mSSY8tGWk+sEA U6SROZG6/DuUrwHTwFfq97mqi+qWheohLBPiVmhTUZJ85aQlORmNcZNQFO2rjpx/ SOEKQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=gahingwoo.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794121205; d=gahingwoo.com; mf=PGdhaGluZ0BnYWhpbmd3b28uY29tPg==; rt=PGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZz4=; s=fm1:rsa-sha256:fxet1oZ0q1kqVNBh5/NQBHOCX/z4PLyQwmFG2O/4XLgGAz7 g8ZUW+e1IuWCkHhsh2jLL+4sdQ7+t+W0wQ2+aMMidglhaQUjHBTSlfamo+4j4sVZ rchSwPaew/gyRAm/guiAbL4Cqssfnjm7VZ+9pAIQUGIbOwLVNm5Y5IERTcnhZzu6 7LiJSHwmSPgpJR5nAXTBAY+VJy3FNKEt4FPDACJoOIyxRMGPqHIQcotv3d3V81pu PZaCeJg0muhDJQ5vUsjetQ70a4W7kW2OKPThDY4hFYwXm/hFE8K5QVCORl1ltEHz QXhKiOI5xPTUAVSEl2OQ6H0J3N7TgnP6+2rcE5Q==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-transfer-encoding,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:P7qr9+Vk84mwgZ83Dm/8vDCMawrueFpw6qrFatp8LYw=:nSL1kRFz222Qw28hbW/GZoL62yXNlvTaEzwpjY7YddQ=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFKhclCCJN9i5LFQp5fvn9DylL5PDR95+qcmUDEkBDvAaUlhVhO6JW1PTcA0oiilr afxU+kS37MwfkRVrV2sLhNS1OkBSH9hrpfUYkvEeAEfTx8oUhC1lvQdEqsrvfO12L2kPDm Y90xvEv61R5vWsABT3XVmqKcWsSTBPoQRHs33ySAWpN7mh8mIX7nfmpu6Q5St0DdZLVl6o GJpMHUC7TjUVqLMHfqfKk9SHn10f5lL6CdG6YeehrsosttZtbM1aNiFk46XYC+svmJcMBn 4w1I3sJZaXrv8SSndHCWUOH7cbPZHBY65Sr1oZjnZZRxSV2wTTFO+3xU/Lmvhk4YCMlhWl oG781Qdu0p4IjDuFIf3UJedZ3PC3oW9naVF/ZMpB5/6eyHLwa5Mtp9hVE47Dx1PnK1Da6V NTplgmRe5ue9yuPYlEJfY6v4CLo4WLE4Ypelbcp0+vPIY8HN7Hdytg4gphobHpyoWCRlO6 hCM8kDy0g/jXljJD4gSAQNkfs504NgfEbWRpSIFN2UFizJPH/9WT55n5uSdQ5sXWMILie1 cwWAGTScrYMaIuEXAqrBp4HhDUTCbBrpG4HfT6rsdWIcEffb1VHjwbfgzXJrN5XQ9HkIdZ pS85Oa4CpTtK+ekqtlWaS9sT2t3NzehhwDfRD5nw5Pt7Dr3QVz34c4ASBdxA X-ME-Proxy: Feedback-ID: i7a5e4b5f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Nov 2026 01:59:55 -0500 (EST) From: Jiaxing Hu To: tomeu@tomeuvizoso.net, heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, ulfh@kernel.org, p.zabel@pengutronix.de, ogabbay@kernel.org, zhangqing@rock-chips.com Cc: royalnet026@gmail.com, abel.vesa@oss.qualcomm.com, sebastian.reichel@collabora.com, sidong.yang@furiosa.ai, u.kleine-koenig@baylibre.com, chaoyi.chen@rock-chips.com, shawn.lin@rock-chips.com, finley.xiao@rock-chips.com, diederik@cknow-tech.com, alchark@flipper.net, leonard@lausen.nl, jeff.hugo@oss.qualcomm.com, rfoss@kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiaxing Hu Subject: [PATCH v16 02/16] accel/rocket: take the completion register writes under job_lock Date: Sun, 8 Nov 2026 19:59:03 +1300 Message-ID: <20261108065917.135194-3-gahing@gahingwoo.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261108065917.135194-1-gahing@gahingwoo.com> References: <20261108065917.135194-1-gahing@gahingwoo.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_230010_387573_DC2D33DC X-CRM114-Status: GOOD ( 12.84 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The IRQ handler writes OPERATION_ENABLE and INTERRUPT_CLEAR before it takes job_lock, while rocket_job_hw_submit() sets OPERATION_ENABLE to 1 under that lock. If the two run at the same time, the 0 written by the IRQ handler can overwrite the 1 written for a new task and stop a task that has just started. Move both writes into the existing scoped_guard(), so they are under the same lock as the submit. Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL") Signed-off-by: Jiaxing Hu Tested-by: Igor Paunovic # RK3588, three cores, induced reset, JOB_TIMEOUT_MS=2 Reviewed-by: Heiko Stuebner --- drivers/accel/rocket/rocket_job.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index c3edb94355a3..03e5f094f60b 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -369,10 +369,15 @@ static void rocket_job_handle_irq(struct rocket_core *core) { pm_runtime_mark_last_busy(core->dev); - rocket_pc_writel(core, OPERATION_ENABLE, 0x0); - rocket_pc_writel(core, INTERRUPT_CLEAR, 0x1ffff); + scoped_guard(mutex, &core->job_lock) { + /* + * Stopping the block belongs under the lock. hw_submit() writes + * OPERATION_ENABLE too, and outside the lock this zero can land + * after that one and stop a task that has only just started. + */ + rocket_pc_writel(core, OPERATION_ENABLE, 0x0); + rocket_pc_writel(core, INTERRUPT_CLEAR, 0x1ffff); - scoped_guard(mutex, &core->job_lock) if (core->in_flight_job) { if (core->in_flight_job->next_task_idx < core->in_flight_job->task_count) { rocket_job_hw_submit(core, core->in_flight_job); @@ -384,6 +389,7 @@ static void rocket_job_handle_irq(struct rocket_core *core) pm_runtime_put_autosuspend(core->dev); core->in_flight_job = NULL; } + } } static void -- 2.43.0