From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7BC606A334 for ; Wed, 11 Nov 2026 12:10:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=MXf7pvYI; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=LgyggL3i DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=8kDTQyiKQOfIkOGO/u8mg2T8m6Y6HEmmU0F0HKV40UE=; b=MXf7pvYIztvbR+ rZAFAg+be6e4/i+wisTVj408gnYzwerV5wZqGNrO0vT7CKoAZwg80zR8SGyEKZNH7DOJsxoWs+HDU I7BYe8JNK1+yhkWS5tZlMom1sxKuNAEKnb5nosUfn+ELv01cu+t9eXprs0VavATX1D0PUEgKBit/2 lBOq3FAjU7MtXzBDC7aVQzq4lqrpfy/BlWdDR+45Y9e1Q+3xe+nLURj+BkOB5SGz1NeMQTxU9aIuw XZ1zNydsPUV4g8QEjcDavqzeGok3xqH5bJGk358Y+nnAEl+1zyRJ9vZWpmRkBojIexMU7xfhm62m2 tsUuY1BTZ4DjcaZPNejw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xR79I-00000006cqX-0Kcb; Wed, 11 Nov 2026 12:09:56 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xR79E-00000006cpK-15rW for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2026 12:09:54 +0000 Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-55e0090c580so990794b6e.3 for ; Wed, 11 Nov 2026 04:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794398991; x=1795003791; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=8kDTQyiKQOfIkOGO/u8mg2T8m6Y6HEmmU0F0HKV40UE=; b=LgyggL3iAV5QU4hacrMdtwyM/HWno7rlJauMMEFqGHfruG8ljXreQHJjppMFIxIl/w Eff16/HHxzO+Qg8zpxT7GAOBYF30PBjrHlsP79AZZa9giScT+DnleGZE1u4QbSVXBBnV NbspJc4UIClBUMxw0R93zMqSotvlZrC7M2c0aXqLR3jsZo99i1pOBGZfSEn7DWy3eacq IW6DtPiToP5wjciPjCGoq6AQ0zAxoL6xpm2tKIMdbfR9dU2apDUonDjn6RvKnUI65Hac LTyUR2dQHC+Q5XXMh6hDRU8sKIvZwL/AxlqAKmRZoXKTJFzhAE+e6Lwbhi8Y6ZGl8fr3 mtWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794398991; x=1795003791; h=content-transfer-encoding:mime-version:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8kDTQyiKQOfIkOGO/u8mg2T8m6Y6HEmmU0F0HKV40UE=; b=jAxor3QeRzv4XwcXjaMBqCpOz3LIdK01Qf4jndeavXkcA7aunAt8Ij1Npq7f3O80sW qJp8zaMIHCbT5u9MdPlqQ+LOA1tUk9nguzJF8p8ucmd1uxV9OkD/zevwBLD9obtgmubJ wwDhuC+jtWcI1fiFK+YFmOut0jCqtEsioX+mNVu0VMlr9H3YydrXrf8iIhbfPBwcMjTm wVwPKZBOepmxe3xZyoMZfZ2ZdLpno3v93pSRnzNaRRtb1YuE2k1/7J6khGOow58LE+0w uRw34Tbn08/hPuGpdK/RbKwA5gy1bvh2lYjVaOZdVqb1+MFFyTriRT79tg0tzoQWeYaF Bn7Q== X-Forwarded-Encrypted: i=1; AL+hErFkGnw8qkiNAp3G1KVOXLq7HbP8dJau1huC08DQGEfe5OV4uKveGTRdRq2lYGBjpPeWHy3COf7NYwwI0QFdIHZZ@lists.infradead.org X-Gm-Message-State: APuU4Z9c+VNfB/rh4rwoUqqGzJidrqcB4LoZwGaw5jnAr4K88MsHl+Tv +vQW1bSYvD+Yd39oyXt+tOW33BWMKA91dOePzjQxrk07oBkB/LjmZ3PT X-Gm-Gg: AYBFou2LJWg+HW/7FU0SzsDEr7kiMluDYe22iQkEpVkK1q+U9yrRlgxxPz1HOf4Rtzb QISuZFU745YYIRwjmpBKjSsI+UgCIK64ZGzVAY36EEubgJqR1v+TgjWj++OcUTWWOnlbWgRXDK6 hyDyk1UaNqQ4yKPTJ8Te4mZs7L/nRK98ZFVZ5YFozsB1KqMOuy4IXQ9fuC9QMld7Cjyxzi4IpNE utwAEbzfc8FHBnpPSEfYPjLAsFpUtkSPUIficW/edO4QcycH4QPUSff3zxK9J3Zj+2IZmF82DJZ bdsD5zXU4fhaVqIqMqgQM/+za6A7caZk2mUB0NEPSVcRZeIzmLcuA6cmm4O1OMYRjfDG6WYmYxH EzlYpVkpRdof3ZP8Thb7I0BFBGEQKsRTywF8eQFlqA0FqdtV6NeFz7hz+gSclogrgT+Yk62qrzD bkVUB8pwq+tCn1jupZ6fJ6YJ/tRXPhXGp8z5IIcthxYdXqLsS5gWydhBHt/3zzTAKiBqbFtoVp7 6VkQWmf21PoXP+enb0oCQHm4DlN9svm5CWlsAcb6pzVInOixxHH8gYtVZGgyJvtOEpIGObdJs+/ 0xKGkw5yhDOnVoqVMFsAOL/AmvJYlgwI/GsGwy5cE/H6mr83VFSOF9t0MUEQyRLIB614Kv1zShV +iqU6 X-Received: by 2002:a05:6808:244f:b0:53b:1d13:dffd with SMTP id 5614622812f47-56b92c464dcmr1457460b6e.7.1794398990670; Wed, 11 Nov 2026 04:09:50 -0800 (PST) Received: from AMD.home.internal (dhcp-9-244-8-156.gobrightspeed.net. [9.244.8.156]) by smtp.gmail.com with ESMTPSA id 5614622812f47-5690504fdb5sm4958534b6e.3.2026.11.11.04.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 04:09:50 -0800 (PST) From: Enzo Adriano To: junhui.liu@pigmoral.tech Cc: Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Richard Cochran , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, Jerome Brunet , Andre Przywara , Norman Herms , Vinicius Pedrosa Subject: Re: [PATCH v6 3/8] clk: sunxi-ng: a733: Add PRCM CCU Date: Wed, 11 Nov 2026 07:09:48 -0500 Message-ID: <20261110-a733-fwclk-junhui-reply@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: <20261009-a733-clk-v6-0-ae8178fce7e8@pigmoral.tech> <20261009-a733-clk-v6-3-ae8178fce7e8@pigmoral.tech> <20261103-a733-ccu-v6-fw-clocks@gmail.com> Content-Type: text/plain; charset="us-ascii" X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261111_040952_423968_FE9CC7A9 X-CRM114-Status: GOOD ( 12.09 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi Junhui, > I'd prefer not to mark these clocks as critical just for the vendor > firmware. You can see my reply in v5: I agree that native PSCI and a future OR100 Crust port are separate from the vendor SCP on E902, and that future E902 remoteproc/mailbox drivers should own these clocks. Vinicius's native-PSCI reboot report used locally modified TF-A on A7Z [1]. Upstream TF-A still has no A733 target; its port is under review [2]. The immediate problem is that the new CCU's unused-clock cleanup breaks reboot with the firmware these boards ship. On one Cubie A7S, RAM-booting v7.4-rc1 + CCU v6 + DT v3 and its dependencies with vendor boot0/BL31/SCP/U-Boot and no clk_ignore_unused, the run without critical flags stalled at reboot -f. With only bus-r-riscv and bus-r-msgbox critical, two warm reboots returned to vendor Linux while r-timer0, bus-r-timer and bus-msgbox0 were 0/0 (enable/prepare); five flags also passed once. > Since you've already submitted a separate patch adding these critical > flags, I'll leave that to you. I will narrow my separate patch [3] to bus-r-riscv and bus-r-msgbox. Chen-Yu, Jernej, Samuel: would you take these two flags as a separate patch until E902/mailbox drivers can own the clocks? There is precedent in A523 bus-r-cpucfg (1dba74abf3e2) and Meson AXG fclk_div3, kept critical for SCPI firmware until the driver claims its clocks and a handoff exists (drivers/clk/meson/axg.c). I have not tested power-off, suspend, either flag alone on A7S, or other boards or firmware; Vinicius found either flag alone insufficient on A7Z with vendor BL31 [4]. [1] https://lore.kernel.org/r/20261011200153.575096-1-vinicius.eduardo.pedrosa@gmail.com [2] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/55200 [3] https://lore.kernel.org/r/20261031020640-263f7b05-a7s-clock@gmail.com [4] https://lore.kernel.org/r/20261005183038.417798-1-vinicius.eduardo.pedrosa@gmail.com Thanks, Enzo