From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A45D9606A31C for ; Tue, 10 Nov 2026 02:37:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lHWKoyox; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=FDXmRROp DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Unsubscribe-Post:List-Owner; bh=m9wZvEuCDe3XvfF7/Jwj2zWHljA+DeJITddjwCddf8c=; b=lHWKoyoxoLUDqMiH3qiHRKsraH kmF47bvWuDSrpfjQAVDWEPUAmrbM6JS1YQrOeR41tp6WpYFO5Lg6qTufsg8rMlvBWP2OpBSkWoQTb swNCZaYquviIog8IrDtDvFg3z3Rc7UJdfeqEayXAEM+oVvECiDgqa1rdV8+YMMyVGByVtmuXK3eQ7 HrvZ9TJyxAULcxxO2lcmHYVVL7bGPE7nno6FRIvIUv7i+1uco627H4JDRW9lBNDIZS0D5k2dpmPr3 WgW07Vw0Q3MB6WwMCvQjxVkoDYE2DeJl1FA2L3nfNaPKcz0DbZo2GGoMuYaSC21nvzeFlfDLzNmup IQ72e5eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQbjv-00000002BL0-0StO; Tue, 10 Nov 2026 02:37:39 +0000 Received: from mail-dy1-x1332.google.com ([2607:f8b0:4864:20::1332]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQbjr-00000002BJt-26Sv for linux-arm-kernel@lists.infradead.org; Tue, 10 Nov 2026 02:37:37 +0000 Received: by mail-dy1-x1332.google.com with SMTP id 5a478bee46e88-36dbde64409so3034931eec.0 for ; Mon, 09 Nov 2026 18:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794278254; x=1794883054; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=m9wZvEuCDe3XvfF7/Jwj2zWHljA+DeJITddjwCddf8c=; b=FDXmRROpMiIcGSX2P/GsRrWfzII05RDaczz5NbT/UlVimf22gVyFTbH4+doPsf0YAI CZW8V9s9C+gQm5vqLZqhMGk7377Vtkvw5pvHRZLR+vsb4ZmvJu0TRNI+k52oL45HfYuI K1DcSgdaXX5qCTGJKxArZOFIdQbg5swS+s1HJYy1F0IVN8fmAxzry1W8TgamHbRyYA8/ JljAW+Qp1aT4XH5JDnTZMNOZs5O2c9ZZJshTpy6rmRvhMZB8u9pY4ryWnMcnBuEQ0Ggg PRBTiCMAvzF3q3IPW1NaNzTpcG8v6QOKaIqGUGeagOhM/RNN7Sofb5ffqPqnfDK8kZrM 3Rzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794278254; x=1794883054; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=m9wZvEuCDe3XvfF7/Jwj2zWHljA+DeJITddjwCddf8c=; b=rLPPgE8r8rKNnhqow9pGT8WaLg5rBLK9E4YRdg1rLCjYTux241Jl5lr0avLxjA+pOg DWDDy3U+twpTJli719Hn1zHrDVq9q6fBDQ8kcXA4gRin+bXFSEAn8zBnlZ0okYnNbdN/ ya2uyXxwHmTRdNc7BIWMEZah6R49efKjnE1MGtZ7Tu0EVaKmUhE8SLZtyn9QVJnj8F0i M4RDmihYwABxp0b8MguS5KdyNTbi+zvUfzBKxm85YeRP9tB6mtZl7aQbJRoC158c0Cfg gF6b7e9yWMKyqiNM87AGaDZTBDwfunS12hWIgR6XApWeqEUYS+WKbGNMQQpv5HP0xHwl E3pQ== X-Forwarded-Encrypted: i=1; AL+hErFkaqkVHTHoAhJnfo/XiQm8bd/LqMJJg2xlSrDpAm13/QhYq4LtyWQBRl0PKn/KnlvuXNNO2Lnw0/pUyOfyXAjG@lists.infradead.org X-Gm-Message-State: APuU4Z9SbwhUVyRBK7JMbUtIYQBK5Tc0TbYvQA+gAFfeMHFw5flLikl6 dhYxdCLJZ2IXacUgaGBASufSIz6+kmLVVXVLSeCpk5qFq/cV9mDY20vS X-Gm-Gg: AYBFou3arij+dIdzYAduQvj+ST7g2uBmVQXDMVeUysRgUUHNFRFH0l25cfmfh99y/F8 jYBPAzcF4DPwOmpuHDD0E8uX119XLgnQNkKXtzRhxQ1yZOetuZuBMhh+7lsoxt1dB85vLjCNoYI LbBn0dk4/CYLmy2DJNS8xnWXJheXRPO7//6ZknVOKX9QhtoCfC1k/uAr2QKTeA0QyBMxYUqHMP5 /azIaUcm0CcjONL8MewhSbPbhDarzXsNK5tVXsxMAqf6V1tl2HuEOBY1KAwulsbOVn0WGpx8N3C dmExmWtw+CrsPusaHmEtJe7Dwrf/mYRYNqH18lLUmRbubYn12fSy+rGYLkU1Mt/MvRkmKvJaG84 odw9xAOT2FihdD+tTMXeO9pFZ1FgGvthk4HF5LS6EGj3cIu9nc7ASCMpvRHb+Ymbfu0acN/xSCL GCMWSL3EeM+IyxLqHJi0cBkP7Aen4EzArtJTAydqf28rY1D6H4ZL3073+BCMjj4VTbeVrRJKQsR x/MWqRrVQ9FzBJFiIsSXDq1Kp5rKS5Nd4eVDJGdlL2LWnMYbH3N2Es5u6u0Fp8Pb2ysmaRtpQzk g4bLJxnSUpRzqcv0bgxl5/KIMwo8k6Tu+8IzUN8= X-Received: by 2002:a05:701b:4354:b0:1ac:2f6d:e1c6 with SMTP id a92af1059eb24-1b3b5fa8f34mr1600581c88.6.1794278253866; Mon, 09 Nov 2026 18:37:33 -0800 (PST) Received: from arch.localdomain ([152.175.35.61]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b3b5b54431sm2883025c88.17.2026.11.09.18.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 18:37:33 -0800 (PST) From: Jun Yan To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Heiko Stuebner Cc: Jun Yan , Damon Ding , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v3] drm/bridge: analogix_dp: use devm_phy_optional_get() for the DP PHY Date: Tue, 10 Nov 2026 10:37:19 +0800 Message-ID: <20261110023721.2014061-1-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.56.0 X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261109_183735_550534_75AF5FD1 X-CRM114-Status: GOOD ( 14.85 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The DP PHY is optional: the Rockchip RK3399 eDP controller (used as the internal eDP port) has no separate PHY device and relies on its built-in PHY, which is programmed directly through the GRF registers, so its DT node carries no "phys"/"phy-names" property. Requesting the PHY with devm_phy_get() therefore returns -ENODEV (or -ENOSYS when CONFIG_GENERIC_PHY is disabled) and the driver logs a misleading "no DP phy configured" error at probe time before falling back to a NULL phy. Use devm_phy_optional_get() instead, which returns NULL when the PHY is absent and otherwise behaves identically, and drop the manual -ENODEV/ -ENOSYS handling. This also removes the spurious error message. Signed-off-by: Jun Yan Reviewed-by: Damon Ding --- Changes in v3: - Add missing changelog entries and reference links - Link to v2: https://lore.kernel.org/dri-devel/20261013134659.335829-1-jerrysteve1101@gmail.com/ Changes in v2: - Added comments to explain the changes made. - Link to v1: https://lore.kernel.org/dri-devel/20260924020417.868588-1-jerrysteve1101@gmail.com/ .../drm/bridge/analogix/analogix_dp_core.c | 22 ++++++------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 6df6963740d2..637b1bff0f6c 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1426,21 +1426,13 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) if (ret) return ERR_PTR(ret); - dp->phy = devm_phy_get(dp->dev, "dp"); - if (IS_ERR(dp->phy)) { - dev_err(dp->dev, "no DP phy configured\n"); - ret = PTR_ERR(dp->phy); - if (ret) { - /* - * phy itself is not enabled, so we can move forward - * assigning NULL to phy pointer. - */ - if (ret == -ENOSYS || ret == -ENODEV) - dp->phy = NULL; - else - return ERR_PTR(ret); - } - } + /* + * RK3288/RK3399 use Analogix DP controller built-in PHY, + * no extra PHY configuration is required. + */ + dp->phy = devm_phy_optional_get(dp->dev, "dp"); + if (IS_ERR(dp->phy)) + return ERR_CAST(dp->phy); dp->clock = devm_clk_get(&pdev->dev, "dp"); if (IS_ERR(dp->clock)) { -- 2.56.0