From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74D11606A8B9 for ; Wed, 11 Nov 2026 21:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aI2ou8Jq; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aAbDfQab DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=Q87Wl85GfFdAm5sI7YhIU296WIXHysjelEmZ6Jt78Zo=; b=aI2ou8JqDrzP7G 1owUY6MAxOrA6z60PLdITtR2od7j4l0M77zFOkkzXb2yWK0enRrHq/3rgJrJ6FW/RHJ+m1dwf8b4R 42WMeqV3EvV9VJjSbmJt/qf1N/fTohjX0giFxnNx5iR75Znozl8zuruaD9YvznkYiM3EtW1/nutO1 F/FCc4rZg2/OGS+ViIShlhZRbsppfeSh29WZdrqpRLYQOPwphub40hv4KLJtvwLrR+KgLBPt1d7VP 7Tra+362Ys4IA+DQHy9Ond/OW00gheTq2Ox0T1te5QpjAm9UtvkDtpovKV8RqNkU9oBHl9QY01gMT ANuiGJ5+oL3NpGOisrwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRGGu-00000007rjC-2AHg; Wed, 11 Nov 2026 21:54:24 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRGGt-00000007riT-1wP9; Wed, 11 Nov 2026 21:54:23 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3B62940A38; Wed, 11 Nov 2026 21:54:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D0E41F00A13; Wed, 11 Nov 2026 21:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794434063; bh=Q87Wl85GfFdAm5sI7YhIU296WIXHysjelEmZ6Jt78Zo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aAbDfQabkJCWMoI446YjnWaSVHAkThh4Xya03u901cDNc41eR145Skd0CaRzYQoGh ZAEREymwRaHATtz1OkSCi0sAfMPKSvBPo6KVVyXbpEXXEdTwIbIqER6BbSYCTxGhEr zwrhld9wfi1mxQ3vPy5p1eDcU9djnbtcENyu0wxamYC06UC2ptFtcI36AIbksl6X3q s8PzmrvmwsMdJpr3VC22vFwfvitB9FeM2E7ZSZUNUjXuGgZdC9+Nq8qo+NX0m/tzsB KBO7SOc5HLRBABrmR2agjY6BmWU5ATM1oNI+1YRf9gD/pwcwG1nb10vslRQrKO5/IH i79eIEZjyZtjw== From: Lee Jones To: lee@kernel.org, James Tai , Yu-Chun Lin , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Linus Walleij , Tzuyi Chang , linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH 10/10] pinctrl: realtek: rtd1625: Set dcycle_offset to NA for pins without duty-cycle support Date: Wed, 11 Nov 2026 21:51:55 +0000 Message-ID: <20261111215256.1982044-11-lee@kernel.org> X-Mailer: git-send-email 2.56.0.567.gdb80ae8cd5-goog In-Reply-To: <20261111215256.1982044-1-lee@kernel.org> References: <20261111215256.1982044-1-lee@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 In rtd1625_main2_sconfigs[], pins gpio_86 through gpio_91 do not support clock duty-cycle adjustment (dcycle_maskbits is 0), but specify 0 instead of NA for dcycle_offset. Because rtd_pconf_parse_conf() tests sconfig_desc->dcycle_offset == NA to determine whether duty-cycle configuration is supported, an offset of 0 causes it to compute GENMASK(0 - 1, 0) and corrupt the pad control register. Set dcycle_offset to NA for gpio_86 through gpio_91. Fixes: e309dbd523b8 ("pinctrl: realtek: add rtd1625 pinctrl driver") Closes: https://sashiko.dev/#/bug/linux-8a8f690f-15e7-4dbd-a3a2-87bc00edf7b9 Cc: stable@vger.kernel.org Signed-off-by: Lee Jones --- drivers/pinctrl/realtek/pinctrl-rtd1625.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/realtek/pinctrl-rtd1625.c b/drivers/pinctrl/realtek/pinctrl-rtd1625.c index 88f2be37f743..f6e038e4bbdd 100644 --- a/drivers/pinctrl/realtek/pinctrl-rtd1625.c +++ b/drivers/pinctrl/realtek/pinctrl-rtd1625.c @@ -2993,12 +2993,12 @@ static const struct rtd_pin_sconfig_desc rtd1625_main2_sconfigs[] = { RTK_PIN_SCONFIG(gpio_65, 0x34, 16, 3, 19, 3, 22, 3), RTK_PIN_SCONFIG(gpio_66, 0x38, 3, 3, 6, 3, 9, 3), RTK_PIN_SCONFIG(gpio_67, 0x38, 16, 3, 19, 3, 22, 3), - RTK_PIN_SCONFIG(gpio_86, 0x3c, 0, 0, 14, 4, 18, 4), - RTK_PIN_SCONFIG(gpio_87, 0x3c, 0, 0, 24, 4, 28, 4), - RTK_PIN_SCONFIG(gpio_88, 0x40, 0, 0, 2, 4, 6, 4), - RTK_PIN_SCONFIG(gpio_89, 0x40, 0, 0, 12, 4, 16, 4), - RTK_PIN_SCONFIG(gpio_90, 0x40, 0, 0, 22, 4, 26, 4), - RTK_PIN_SCONFIG(gpio_91, 0x44, 0, 0, 2, 4, 6, 4), + RTK_PIN_SCONFIG(gpio_86, 0x3c, NA, 0, 14, 4, 18, 4), + RTK_PIN_SCONFIG(gpio_87, 0x3c, NA, 0, 24, 4, 28, 4), + RTK_PIN_SCONFIG(gpio_88, 0x40, NA, 0, 2, 4, 6, 4), + RTK_PIN_SCONFIG(gpio_89, 0x40, NA, 0, 12, 4, 16, 4), + RTK_PIN_SCONFIG(gpio_90, 0x40, NA, 0, 22, 4, 26, 4), + RTK_PIN_SCONFIG(gpio_91, 0x44, NA, 0, 2, 4, 6, 4), RTK_PIN_SCONFIG(hif_clk, 0x44, 13, 3, 16, 3, 19, 3), RTK_PIN_SCONFIG(hif_data, 0x48, 3, 3, 6, 3, 9, 3), RTK_PIN_SCONFIG(hif_en, 0x48, 16, 3, 19, 3, 22, 3), -- 2.56.0.567.gdb80ae8cd5-goog