From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A934160A380B for ; Fri, 13 Nov 2026 00:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=OKdGfWk+; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=RgZT1B8Y DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=GSzexzY3tNd8fGcKsjnU3nRndcIeboSpFV5OISlu3o8=; b=OKdGfWk+rJr6Tn eV6mBNaygZTWwpQCv1hgyYNZKJSmJhkR4x1cyZkfShfJfIpt4eiV4d89Poq58VkMvfE43QMVZV7vR 9l5OkTANQcCqJCs49VusFylD5G57TPMnLShm5234/RAk50iqGsLk2Gb63M/YDr0cHNrx2agkGNh6y BQcQmA1NDGNo8wf9p0BJ/+OIgSR3IPP3Zho2e5+QfcsjcK7lWBplcQJSmi3hku8u2YH+kBLqBMw6A 8OrQwKjY7nzpFacjUxEFk37Stx/128i0TZ9R+GvfD5AtYKvy3XjCy4i2KAG2UKtohNklLT0MBMcF0 wsAaMO4vbG21bZev8h6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRfDY-0000000BJBO-26aA; Fri, 13 Nov 2026 00:32:36 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRfDU-0000000BJ7g-283g for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2026 00:32:33 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-490a0e72588so112071f8f.3 for ; Thu, 12 Nov 2026 16:32:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794529951; x=1795134751; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=GSzexzY3tNd8fGcKsjnU3nRndcIeboSpFV5OISlu3o8=; b=RgZT1B8YkOYxbsMJ02M7T+XqZoWX5h+DAP23iXbIdFSH6PAeQTncN8I5ZPjh0Y/xSz ZPNsFcIdfxCEFzPcAlhCVulCdFLrBhRlOzj4/4dilyHCfbgwvCKmIP4AjlSUcVEl0J32 YXRIJbzUbrHj5xZWVyvLKg8aGP/81g3HhnKVgTt/+DPH4eKXj0M6mJKrhiVtoeLFhe1e fF9PqCnJo4OernV+0bsH38wgu5melAB28h61QO0i3eV3rw2mCDOr0t4g1SNFxjdM/IqS njiNZ2xv2kGkmUWsZSvQbHvrypyjbsGtshQiWTBNuvzIbCDVMW0tYqkFkXa6c67U1I90 MR2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794529951; x=1795134751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=GSzexzY3tNd8fGcKsjnU3nRndcIeboSpFV5OISlu3o8=; b=xrxMNWrgnVdnO8NIcYC//FecLOXKpYlVbIX3tLfTHNYIbdMBAOMK0O7hqKRf3wl+sz dDO29F8se1+hLUVW7j5JcnlU9PC7bhfVAFI+ScjMKy92sI4GCn4JczYPfg6O78uS4BXp /OzOa0zcnavnkLvMXbJWlJazsDZwTKPs9RlmiFrUv3tXf7VYBAbAEP/RRovclKYZR6Lz 4dOraaytkqRS/mHqeQSKcVYZBfA2yrkD2hV231mqiqewjU1C611tUYQPhyKSLBAm+ub0 QB8kL+DJKG+0GnXFOzwX4dzh4pCPOrs8Obys8rhyeRhH89zNUN/IcNis1Vm0b0qCqN1i iPNg== X-Forwarded-Encrypted: i=1; AL+hErFNg4zfOc4GABhAeEQtvKpcjZy2CT5X961uwpRhwK4XPYeVeN05Rc7dbyzVzBGM4YPGHReHj88wGmKuwVxX5hk3@lists.infradead.org X-Gm-Message-State: APuU4Z9YGKATqbapn68uHz0OGCqS0v/ioD6hhzqj8D0ghL+zzm9x8uWs RQsxGgNM38eMQrXj+dgwGbcNJbdTJhEGZ6KUTYjMiq1IP3L6fYS80om5 X-Gm-Gg: AYBFou3CAotg6y2D/Zp4x/LqZcGdeqZFB26omCoi3b/WxQNImjuUXyw9jm1bcUI+4F1 3yATdr0SmLc6XWUmTnR6sF4M12zHDco/+6g5U+SRMBvOxdLT2QQSyX5i2gQpKMWKt7eVjDE284O CYerqeJksWoSqZFaPpB0r2OTA1akdRTH/Z6u0ZUa+/Qb22rWHxguTdT+kp3uutElr0v0aHEnIJr I2/rrmsclDMWMYJVCF9Tq08ix52JQ6Uxg4euKB0eiYd8zf8qCQnFyJAYZiOG52hbr3ajgFh8kYC KzY6dY0ZghIieL7qPvbMGBSRbRv5SnoSzwHRc3H/iJ9/SGE5xIfzL3Gd5K0RhC5RAKesEFLC6uW Q7G9gd9pIgIDCDzhRblkEYzZvHG8WYsD/qOh6+hzRNheKy2Mh/KUI6/zMgOB8mL6h1kGA3D/38h R57KAzLOWFCytURZiHx4V89g10rMOg+M7+eQPpWVRd97zIPgwdcWgi2PfVfd1L41wo6goLJj0AU QXGMoB3F1xcTAnFylVGLpULgxORUMOaM5J1pxwUGZ53W29/Wwbu/Fmep6jJz0fx8QS7yDevaq6k m0NcEJBo1XtfSaWYWXmW6YNje1XbNt+RBnJ4h+i+Y3sS34Pl2nc4TUpqRf2ym2i85h8zTHo0FoU hAi3PQ7j6sYzYKmmv9hxEHaskMdutgN5Sl9Iq9sl5IKkZvbcY1TSzvQ== X-Received: by 2002:a05:6000:402c:b0:491:4e13:fde3 with SMTP id ffacd0b85a97d-49c712ac654mr2019766f8f.13.1794529950823; Thu, 12 Nov 2026 16:32:30 -0800 (PST) Received: from Ansuel-XPS24.localdomain (host-212-171-11-167.retail.telecomitalia.it. [212.171.11.167]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-49c5f7828a4sm2029768f8f.23.2026.11.12.16.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 16:32:29 -0800 (PST) From: Christian Marangi To: Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v19 02/15] net: phylink: make PCS phylink instance access RCU protected Date: Fri, 13 Nov 2026 01:31:52 +0100 Message-ID: <20261113003217.197757-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261113003217.197757-1-ansuelsmth@gmail.com> References: <20261113003217.197757-1-ansuelsmth@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261112_163232_586537_5F597FDB X-CRM114-Status: GOOD ( 16.59 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 In the context of phylink_pcs_change(), phylink instance is dereferenced from the pcs pointer present in the phylink_pcs struct. There is currently a fragility where this pcs pointer is never set NULL in phylink_destroy() and would reference invalid memory after phylink instance is freed. In this scenario, if a PCS driver calls phylink_pcs_change(), invalid memory can be dereferenced and phylink_link_changed() is called on freed memory. To address this, make the phylink instance saved in phylink_pcs struct RCU protected and access it under RCU lock. Also correctly reset the phylink instance pointer on phylink_destroy() and syncronyze RCU to catch an execution of phylink_pcs_change(). Signed-off-by: Christian Marangi --- drivers/net/phy/phylink.c | 17 ++++++++++++++--- include/linux/phylink.h | 2 +- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 5d649903be9e..83620a120f18 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -1300,10 +1301,10 @@ static void phylink_major_config(struct phylink *pl, bool restart, phylink_pcs_disable(pl->pcs); if (pl->pcs) - pl->pcs->phylink = NULL; + rcu_assign_pointer(pcs->phylink, NULL); if (pcs) - pcs->phylink = pl; + rcu_assign_pointer(pcs->phylink, pl); pl->pcs = pcs; } @@ -2145,6 +2146,11 @@ void phylink_destroy(struct phylink *pl) if (pl->link_gpio) gpiod_put(pl->link_gpio); + if (pl->pcs) { + rcu_assign_pointer(pl->pcs->phylink, NULL); + synchronize_rcu(); + } + cancel_work_sync(&pl->resolve); kfree(pl); } @@ -2609,10 +2615,15 @@ EXPORT_SYMBOL_GPL(phylink_mac_change); */ void phylink_pcs_change(struct phylink_pcs *pcs, bool up) { - struct phylink *pl = pcs->phylink; + struct phylink *pl; + + rcu_read_lock(); + pl = rcu_dereference(pcs->phylink); if (pl) phylink_link_changed(pl, up, "pcs"); + + rcu_read_unlock(); } EXPORT_SYMBOL_GPL(phylink_pcs_change); diff --git a/include/linux/phylink.h b/include/linux/phylink.h index 3a88a69882a6..4a0dc6fa8010 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -494,7 +494,7 @@ struct phylink_pcs_ops; struct phylink_pcs { DECLARE_PHY_INTERFACE_MASK(supported_interfaces); const struct phylink_pcs_ops *ops; - struct phylink *phylink; + struct phylink __rcu *phylink; bool poll; bool rxc_always_on; }; -- 2.55.0