From: Long Wei <longwei27@huawei.com>
To: <catalin.marinas@arm.com>, <will@kernel.org>, <shuah@kernel.org>
Cc: <mark.rutland@arm.com>, <broonie@kernel.org>,
<kevin.brodsky@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kselftest@vger.kernel.org>, <hewenliang4@huawei.com>,
Long Wei <longwei27@huawei.com>
Subject: [PATCH] selftests/arm64: signal: fix inverted feature mask in diagnostics
Date: Sat, 14 Nov 2026 16:10:13 +0800 [thread overview]
Message-ID: <20261114081013.964933-1-longwei27@huawei.com> (raw)
When a testcase is skipped because an incompatible CPU feature is
present, test_init() reports the feature set with:
feats_incompatible & ~feats_supported
That is the set of incompatible features which are *not* supported,
i.e. always empty, instead of the incompatible features which actually
triggered the skip. As a result the diagnostic prints an empty list and
gives no hint about why the test was skipped.
Use the supported set so the offending feature is reported:
feats_incompatible & feats_supported
Fixes: 32de73e89099 ("kselftest/arm64: signal: Allow tests to be incompatible with features")
Signed-off-by: Long Wei <longwei27@huawei.com>
---
tools/testing/selftests/arm64/signal/test_signals_utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/arm64/signal/test_signals_utils.c b/tools/testing/selftests/arm64/signal/test_signals_utils.c
index 4b12dbd7669d..16036e06d6c1 100644
--- a/tools/testing/selftests/arm64/signal/test_signals_utils.c
+++ b/tools/testing/selftests/arm64/signal/test_signals_utils.c
@@ -365,7 +365,7 @@ int test_init(struct tdescr *td)
fprintf(stderr,
"Incompatible Features: [%s] supported\n",
feats_to_string(td->feats_incompatible &
- ~td->feats_supported));
+ td->feats_supported));
td->result = KSFT_SKIP;
--
2.43.0
reply other threads:[~2026-11-14 8:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261114081013.964933-1-longwei27@huawei.com \
--to=longwei27@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=hewenliang4@huawei.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox