Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: VAMSHI GAJJELA <vamshigajjela@google.com>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
	"Abel Vesa" <abelvesa@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Jim Wylder" <jwylder@google.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: spmi: Add SmartDV SPMI controller
Date: Mon, 16 Nov 2026 18:01:53 +0000	[thread overview]
Message-ID: <20261116-compactly-unvocal-9d06dfb6beac@spud> (raw)
In-Reply-To: <CAMTSyjrYSzb57w9G6a+JVaZzRHBBV6zaW_Br_UcM7C5REWLgVw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4176 bytes --]

On Sun, Nov 15, 2026 at 10:13:27PM +0530, VAMSHI GAJJELA wrote:
> On Tue, Nov 3, 2026 at 11:47 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Tue, Nov 03, 2026 at 09:56:06AM +0530, vamshi gajjela wrote:
> > > From: Vamshi Gajjela <vamshigajjela@google.com>
> > >
> > > Document the device tree bindings for the SmartDV IP Solutions MIPI SPMI
> > > master controller ("smartdv,spmi").
> > >
> > > This controller IP is integrated in Google Tensor SoCs starting with the
> > > G5 generation (codename: laguna, canonically written as "lga"), so add
> > > "google,lga-spmi" with a fallback to "smartdv,spmi".
> > >
> > > Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> > > ---
> > >  .../bindings/spmi/smartdv,spmi.yaml           | 126 ++++++++++++++++++
> > >  MAINTAINERS                                   |   6 +
> > >  2 files changed, 132 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/spmi/smartdv,spmi.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/spmi/smartdv,spmi.yaml b/Documentation/devicetree/bindings/spmi/smartdv,spmi.yaml
> > > new file mode 100644
> > > index 000000000000..e0512e60d932
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/spmi/smartdv,spmi.yaml
> > > @@ -0,0 +1,126 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/spmi/smartdv,spmi.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: SmartDV IP Solutions SPMI Controller
> > > +
> > > +maintainers:
> > > +  - Vamshi Gajjela <vamshigajjela@google.com>
> > > +
> > > +description:
> > > +  SmartDV IP Solutions MIPI System Power Management Interface (SPMI) master
> > > +  controller supporting MIPI SPMI Specification versions 1.0 and 2.0.
> > > +
> > > +allOf:
> > > +  - $ref: spmi.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    oneOf:
> > > +      - items:
> > > +          - const: google,lga-spmi
> >
> > > +          - const: smartdv,spmi
> > > +      - const: smartdv,spmi
> >
> > I hate compatibles for purchasable IP like this, particularly when
> > unversioned as they maybe become effectively useless when a new revision
> > releases. The standalone smartdv,spmi compatible has to go at least,
> > soc-specific compatibles are mandatory.
> 
> Agreed. In v2 I will drop "smartdv,spmi" (both standalone and as a
> fallback) and use only the SoC-specific "google,lga-spmi" compatible,
> renaming the binding to google,lga-spmi.yaml and dropping patch 1/3.
> 
> >
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  clocks:
> > > +    description:
> > > +      Core clock to the controller from which SPMI SCL is derived. Optional if
> > > +      the controller uses a free-running clock and clock-frequency is specified.
> > > +    maxItems: 1
> > > +
> > > +  resets:
> > > +    maxItems: 1
> > > +
> > > +  clock-frequency:
> > > +    description:
> > > +      Input core clock frequency in Hz when the controller uses a free-running
> > > +      clock not described in clocks.
> > > +
> > > +  smartdv,master-arb-enable:
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    enum: [0, 1]
> > > +    default: 0
> > > +    description:
> > > +      Enable master bus arbitration phase (0 = disable, 1 = enable).
> >
> > What aspect of board design governs the decision here?
> > Why can it not be determined from the soc specific compatible?
> 
> These parameters do not vary between boards on LGA (this applies
> to all smartdv,* properties below). In v2 I will drop all
> of them from the binding and move the LGA controller configuration into
> of_device_id match data in the driver keyed off "google,lga-spmi"

> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> >
> > I find it hard to believe that this is the set of required properties.
> 
> Agreed. In v2 I will make clocks and resets required alongside compatible
> and reg, and drop the remaining optional properties.

Cool, changes sound good to me thank you.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-11-16 18:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  4:26 [PATCH 0/3] spmi: Add SmartDV SPMI controller driver and bindings vamshi gajjela
2026-11-03  4:26 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add smartdv vamshi gajjela
2026-11-04 14:08   ` Krzysztof Kozlowski
2026-11-13 17:25     ` VAMSHI GAJJELA
2026-11-03  4:26 ` [PATCH 2/3] dt-bindings: spmi: Add SmartDV SPMI controller vamshi gajjela
2026-11-03 18:16   ` Conor Dooley
2026-11-15 16:43     ` VAMSHI GAJJELA
2026-11-16 18:01       ` Conor Dooley [this message]
2026-11-04 14:14   ` Krzysztof Kozlowski
2026-11-15 17:14     ` VAMSHI GAJJELA
2026-11-03  4:26 ` [PATCH 3/3] spmi: Add SmartDV SPMI controller driver vamshi gajjela
2026-11-06 16:58   ` Uwe Kleine-König
2026-11-15 17:23     ` VAMSHI GAJJELA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116-compactly-unvocal-9d06dfb6beac@spud \
    --to=conor@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jwylder@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=vamshigajjela@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox