From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF30F606A329 for ; Mon, 16 Nov 2026 19:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=skI940W+; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=T5lq4Gh0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=NLEVaE48FQsqW5wCynx+dwoMtLwn3qpODOOwTrZzvVg=; b=skI940W+USRSas ckvkFR+3h00Mvnohn4BCp8R9mP9qq8uy/emRb4VAQTSS3/oPRkkMrAwtK2pgKMNWjn9tRrAI8MDuG TMTiFjcQsaAnszn1q4earjH/Z+s+z+z7jQWxZNHZ7bwy9pmnuRmalAWoVuBbVCHS5oNVpQCBg0ZB7 CvX1c9EwznGhvpJW4o7aSnivB/1J3zBstoKvV/zg+qBl2tdzxl0Ud4P08xzzZ4+mhmRrUmLrkcGWk dmrPJRMk5FSK397F1iDeS5KU7Qkra+jaVk42y+b8//AnpnYB5GbHwZOBrilx7tzRy+kcvivH+vaXV LjB01E8Uw/DwDKcEfy1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xT2Oc-00000003kyG-37PZ; Mon, 16 Nov 2026 19:29:42 +0000 Received: from out-11.mta1.migadu.com ([95.215.58.11] helo=mta1.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xT2OZ-00000003kwt-32tk for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2026 19:29:41 +0000 X-Envelope-To: linux-arm-kernel@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=HQx4VWaf+Q2UNANp/KesFc5JF3/bgr/mIFQz1FQDxJQ=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794857377; v=1; x=1795462177; b=T5lq4Gh0WgzvGUuvnv17OTDAn8KiPwL65MmxwoQ9vX7vg6a9evJKaygjKzjVqA1g4NUU1h8M cF/+C+JeTLE0U/Gz05cHEUW0ThRuY2FP4nvlOnA5w5sSH6qTnQrkjTBTcbQ57FtQZ5UgJwIRes6 g11XtvYD82MJNm28eBb0XoSU= X-Envelope-To: linux-arm-kernel@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 5bb806d544a59f94; Mon, 16 Nov 2026 19:29:37 +0000 X-Mizu-Trace-ID: 5bb806d544a59f94 X-Migadu-Flow: FLOW_OUT From: Fuad Tabba To: Marc Zyngier , Thomas Gleixner Cc: Radu Rendec , Zenghui Yu , Lorenzo Pieralisi , Steven Price , Suzuki K Poulose , "Aneesh Kumar K . V" , Will Deacon , Fuad Tabba , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] irqchip/gic-v3-its: Clean the GICv4.1 vPE table to PoC Date: Mon, 16 Nov 2026 19:29:30 +0000 Message-ID: <20261116192933.3266502-3-fuad.tabba@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261116192933.3266502-1-fuad.tabba@linux.dev> References: <20261116192933.3266502-1-fuad.tabba@linux.dev> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261116_112939_927275_69A9ADFD X-CRM114-Status: GOOD ( 11.06 ) X-Spam-Score: -2.8 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On a GICv4.1 system, allocate_vpe_l1_table() sets Z and Valid in GICR_VPROPBASER and points it at a freshly zeroed vPE table, but leaves the zeroes in the CPU's cache. A redistributor that accesses the table as non-shareable reads it from memory, where it might not be zero, and the spec makes that UNPREDICTABLE (GICR_VPROPBASER.Z, IHI 0069H.b 12.11.39). Clean the table to PoC unconditionally, as the driver does for the pending table. Testing rdists_support_shareable() isn't enough, since GICR_VPROPBASER can read back as non-shareable even when the helper returns true. allocate_vpe_l2_table() already cleans the level-2 pages in that case. A vPE table inherited from an ITS is cleaned by its_setup_baser() when the ITS is non-shareable. Fixes: 5e5168461c22c ("irqchip/gic-v4.1: VPE table (aka GICR_VPROPBASER) allocation") Signed-off-by: Fuad Tabba --- drivers/irqchip/irq-gic-v3-its.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 9900c6a53526e..6932dd0a02c42 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -3007,6 +3007,9 @@ static int allocate_vpe_l1_table(void) pa = virt_to_phys(page_address(page)); WARN_ON(!IS_ALIGNED(pa, psz)); + /* Make sure the GIC will observe the zeroed table */ + gic_flush_dcache_to_poc(page_address(page), np * PAGE_SIZE); + val |= FIELD_PREP(GICR_VPROPBASER_4_1_ADDR, pa >> 12); if (rdists_support_shareable()) { val |= GICR_VPROPBASER_RaWb; -- 2.47.3