From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24952606A332 for ; Mon, 16 Nov 2026 19:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sBH9ipl9; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=sG2gNghc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=iVKkn1Qt8urtg33+T4CbLHRgvt5i2katmTYO4GRbEMI=; b=sBH9ipl95ELGMi 4xjdybRTypKbmbaKnCHXTVT5pjNpDRKyv+VRqpi5A9pqVHMHIFwAOBQWUE0HruqmHqw6EFNyQRjC4 NLd/0xAhmEM/Xn6Uat76wTOwDWOOQGpG1JVsRvOk5omk/XMy1Ezr1bTfKMsT5fBvpKSYD9vL2vJWY 3gH9Mn/qQORvlNcsm5hI3TKQG4t0VEU+rct3AwebdULXlmqptBKwDmRu1X4pchVKi2PirqSl3ZqS8 SecSAjsmvCJO76epnPpDZoIak2fPQ8TKqmi1N9tzEZbsUdQo9CW3nlBwVPbri9QUY8uVnkKXHmywo Zaypb1Wl+j5Xg/Md1sdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xT2Os-00000003l4p-0Ltj; Mon, 16 Nov 2026 19:29:58 +0000 Received: from out-53.mta0.migadu.com ([2001:41d0:1004:224b::35] helo=mta0.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xT2Oe-00000003kyF-313N for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2026 19:29:46 +0000 X-Envelope-To: linux-arm-kernel@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=useyEi6UOp4DdWiLFMZSoaOzTXlnpBXCpm7MiCMNcks=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794857382; v=1; x=1795462182; b=sG2gNghcqYoamWMfqVPcAkViwmPQmlMA2sb//9qfN7XWtwg7ez8IiAwX2RQKoJza01MmysUG 3oJcIHfOp4zKVsBig8VNBA0KocB/DQO27+J9RfHc7tet8n3VwPY1beYKmQ+jdxROj1BWAXu20K6 T/l4pLW5BFqFdQfK3mPi6gH0= X-Envelope-To: linux-arm-kernel@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id ef3350f581aa456f; Mon, 16 Nov 2026 19:29:42 +0000 X-Mizu-Trace-ID: ef3350f581aa456f X-Migadu-Flow: FLOW_OUT From: Fuad Tabba To: Marc Zyngier , Thomas Gleixner Cc: Radu Rendec , Zenghui Yu , Lorenzo Pieralisi , Steven Price , Suzuki K Poulose , "Aneesh Kumar K . V" , Will Deacon , Fuad Tabba , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] irqchip/gic-v3-its: Align sub-page ITTs to 256 bytes Date: Mon, 16 Nov 2026 19:29:31 +0000 Message-ID: <20261116192933.3266502-4-fuad.tabba@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261116192933.3266502-1-fuad.tabba@linux.dev> References: <20261116192933.3266502-1-fuad.tabba@linux.dev> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261116_112945_494958_60FF09B2 X-CRM114-Status: GOOD ( 10.20 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Commit e36d4165f0796 ("irqchip/gic-v3-its: Rely on genpool alignment") dropped the ALIGN() of the ITT address in MAPD, on the premise that the ITT pool returns 256-byte aligned blocks. However, the pool's minimum allocation order is get_order(ITS_ITT_ALIGN), which is 0, so its granule is a single byte. An ITT whose size is not a multiple of 256 leaves the next device's ITT misaligned. MAPD drops the low bits of its address, so that device's ITEs land on the previous device's ITT. QEMU's emulated ITS has 12-byte ITEs, so two devices with 32 vectors each are enough to hit it. Create the pool with a granule of ITS_ITT_ALIGN. Fixes: e36d4165f0796 ("irqchip/gic-v3-its: Rely on genpool alignment") Reviewed-by: Suzuki K Poulose Signed-off-by: Fuad Tabba --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 6932dd0a02c42..5756ffe4ec13e 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -5854,7 +5854,7 @@ int __init its_init(struct fwnode_handle *handle, struct rdists *rdists, bool has_v4_1 = false; int err; - itt_pool = gen_pool_create(get_order(ITS_ITT_ALIGN), -1); + itt_pool = gen_pool_create(ilog2(ITS_ITT_ALIGN), -1); if (!itt_pool) return -ENOMEM; -- 2.47.3