From: Florian Fainelli <florian.fainelli@broadcom.com>
To: bcm-kernel-feedback-list@broadcom.com,
Jai Luthra <jai.luthra@ideasonboard.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Stefan Wahren <wahrenst@gmx.net>,
Dom Cobley <popcornmix@gmail.com>,
Phil Elwell <phil@raspberrypi.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Juerg Haefliger <juerg.haefliger@canonical.com>,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/2] platform/raspberrypi: vc-sm-cma: Fix get_kernel_id check, pass NULL for pointer
Date: Mon, 16 Nov 2026 15:01:29 -0800 [thread overview]
Message-ID: <20261116230129.1469941-1-florian.fainelli@broadcom.com> (raw)
In-Reply-To: <20261116-vc-sm-cma-fix-v1-1-2b0f11aa96b9@ideasonboard.com>
From: Florian Fainelli <f.fainelli@gmail.com>
On Mon, 16 Nov 2026 19:02:53 +0530, Jai Luthra <jai.luthra@ideasonboard.com> wrote:
> Fix a couple of issues reported by sparse on the vc-sm-cma driver.
>
> The first is around the retval of get_kernel_id(), which we check for
> negative error codes after assigning it to a u32 value. Fix it by using
> a temporary signed integer for the check. While at it, also ensure
> during error handling that we call free_kernel_id() only if we got a
> valid one earlier.
>
> The second is a minor warning around passing 0 instead of NULL for a
> pointer argument.
>
> Fixes: 0d6409fd70af ("platform/raspberrypi: Add VideoCore shared memory support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202611141042.Rxt6cuNo-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202611141002.jCrJ06DU-lkp@intel.com/
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian
next prev parent reply other threads:[~2026-11-16 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 13:32 [PATCH 0/2] platform/raspberrypi: vc-sm-cma: Fix sparse and smatch warnings Jai Luthra
2026-11-16 13:32 ` [PATCH 1/2] platform/raspberrypi: vc-sm-cma: Fix get_kernel_id check, pass NULL for pointer Jai Luthra
2026-11-16 23:01 ` Florian Fainelli [this message]
2026-11-16 13:32 ` [PATCH 2/2] platform/raspberrypi: vchiq-mmal: Fix warnings in the zero-copy path Jai Luthra
2026-11-16 23:01 ` Florian Fainelli
2026-11-16 23:03 ` [PATCH 0/2] platform/raspberrypi: vc-sm-cma: Fix sparse and smatch warnings Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116230129.1469941-1-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=f.fainelli@gmail.com \
--cc=jai.luthra@ideasonboard.com \
--cc=juerg.haefliger@canonical.com \
--cc=kernel-list@raspberrypi.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkp@intel.com \
--cc=phil@raspberrypi.com \
--cc=popcornmix@gmail.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox