From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9159606A32C for ; Tue, 17 Nov 2026 23:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=PhHLXNac; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=X9C5zq4q DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=1L1rnpEa1FMQhHWjQ297g0CVeUw3DnJ6PRrNwvd4eCI=; b=PhHLXNacxVEZHd sklPE+Hh9oqUlojKkL+YGEF5uO0c/YLv57EKOq0K4xJFZHoZ/MJAGNxfBCRe11ELgSbsiawwyyWU3 GPRnwBGyMdemzh9VrYm1dbv3UAXwTR+FO96YtbozqNnWWrTx5bKdldMdaXVq50tFJTzZnz4ZY0um3 tI3hmsoCVnJ5jX9XiHGs/+aDpuVD318W1iRTjznarJOyNGTxJz17dYX0nr/eInMVqVjXhqOZQFLiP EkTwUdVVWw33Q47o+rGwz/Pozff9XUZpad3Okw+xPhBn7OJOXSFIQ0hTLKkxY6XRcgCot+c11pMSU 9AebkQi2Wl6OTBIcU5cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTSwr-00000007JOI-1yIO; Tue, 17 Nov 2026 23:50:49 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTSwp-00000007JMe-1wHG; Tue, 17 Nov 2026 23:50:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=1L1rnpEa1FMQhHWjQ297g0CVeUw3DnJ6PRrNwvd4eCI=; b=X9C5zq4qmzVZbAo9rnBmBh45mj J2chf+v2QllC3118joYKv2Hv6rxQFGdQPEnxw3/DdgIgGaDNFSBMDfZbpS4iE2Etcy64/sYhrnz/I vVmAnLh4p2KjJBZtd3j804B3HzhO9rfJsL3xmtcTB9e8JzqFMWOavGsWE0b2YDQLK6IAgljk3ZmhT FZJJdfooN7EkvfCPC6QKbayNxAMToxfNOOcxKY5ZoXlqH/OW+uGe2SeDOmqAop7Mre2KmLUbGUxTO 4ScypXDF1/FskYMOqiZYfidP4AD/Yar+q4l49O9yzN9/WXjfZvjzdBYM6oPPHt8srhJS3fE87thsx RETxkPjA==; From: Heiko Stuebner To: broonie@kernel.org Cc: Heiko Stuebner , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, quentin.schulz@cherry.de, Lee Jones , Sebastian Reichel , Heiko Stuebner Subject: [PATCH v3 2/7] spi: Allow spi_delay_exec() to be used from atomic contexts Date: Wed, 18 Nov 2026 00:50:16 +0100 Message-ID: <20261117235021.2013719-3-heiko@sntech.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117235021.2013719-1-heiko@sntech.de> References: <20261117235021.2013719-1-heiko@sntech.de> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261117_155047_532722_ED04174E X-CRM114-Status: GOOD ( 13.50 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 From: Heiko Stuebner When using spi_delay_exec() only the fsleep in the subsequent _spi_transfer_delay_ns() can actually sleep. As we might want to use spi_delay_exec() from atomic contexts in the future, move the might_sleep() up to the actual place that matters and fall back to the existing ndelay if called from an atomic context. Signed-off-by: Heiko Stuebner --- drivers/spi/spi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 3aeee3b11c0c..8a82d7f5b9fa 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1714,11 +1714,12 @@ static void _spi_transfer_delay_ns(u32 ns) { if (!ns) return; - if (ns <= NSEC_PER_USEC) { + if (ns <= NSEC_PER_USEC || spi_in_atomic()) { ndelay(ns); } else { u32 us = DIV_ROUND_UP(ns, NSEC_PER_USEC); + might_sleep(); fsleep(us); } } @@ -1766,8 +1767,6 @@ int spi_delay_exec(struct spi_delay *_delay, struct spi_transfer *xfer) { int delay; - might_sleep(); - if (!_delay) return -EINVAL; -- 2.53.0