From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78F05606A89F for ; Tue, 17 Nov 2026 23:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wrU6V7qb; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=gYERLiKS; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=g++5zmQW DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=3B38yKhNhlA5OZ7ETKheHjpFgCHfCqpoLU45qrtyMjg=; b=wrU6V7qb4lAwDU 5iHXivDkrgW7HIuNyJ5QLTdv++lWAEkNbn6edBOJ7kxpcsmYqvdS0so7XNlGd/ekbp4YvpeP0tKZr Jf0gZ6D0FkUOU4DuK9orgxC1VFv7TiZiS3wHxC7LVGtBtBbQ2wW/maEp4vFksX2oT9uDum+ehX/m5 pZxjheogxFv3Q8jKAekT0TPbz6B8Yvb+oo1iyjQYk4rSXnuBJmvN4H26SWuAXItuwtsCg9dttQuej THoPZqnBFMFNny81PPgygJWOPytfHiStPoWcn2AsE1tiOhCgL4Ve7ytNrbzvgHE51hb/rj8ijQ++a QheIpgMTByOZzqW6S4BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTSxN-00000007Jk7-12nS; Tue, 17 Nov 2026 23:51:21 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTSwu-00000007JOm-1hfE; Tue, 17 Nov 2026 23:50:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=3B38yKhNhlA5OZ7ETKheHjpFgCHfCqpoLU45qrtyMjg=; b=gYERLiKS7bY6QH4zMHGirZvKQy ZSNdXR+2h+80EGaA/+9YD7eGMkknE5hnFdcMBkXqBJesYj2XcjXReZARcjHmvqlMRgJaSXpBgrn9c ykCEeU3kVdGmoMQUjKYzFeSRBpMFZAUL/MsAJWL9xwSJXrUn68TFrglJC0FjQPcZz8x6yRlWunFG/ B6jEOcpaJs/mm+rOiXmxaxtr79zN9IWpdnWqa7aptUQRIJtVzA0CbUGkY9hvttBFrrJhYy1Sa5XWK G1dxSq647a3FjwlbkzLAmReBSgHbtGtovtaZZtjrIzW7/5vnzg1dy7SDxxQlQIgOrojacaHOv6CHg P9+4Eosw==; Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTSwp-0000000FVIg-1dJi; Tue, 17 Nov 2026 23:50:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=3B38yKhNhlA5OZ7ETKheHjpFgCHfCqpoLU45qrtyMjg=; b=g++5zmQWWOpyueZrWB/iZYrimj GqyGxlISVRLzmwZ6Gt/dQaP5zLD4undWM8PFgWPKcwT+tBPLfaWc/CXrzbhCNEtV4IuLidYoQ/lEn DjIVBgawvuH9f47BhgCGdl6WDotSul5WtmSrt5Dn80DHZqpbIPyxLFh1+ipf1EUCqP9dzOpPGRC3c nfCvvr9lLtB5duDT1okjDi9eBP4qcfmZbhEmGi00GGpiuypik2PcdQB4Jr6lZTfK98PW3CP8UMXaf x2Ag3ODQAZ8lgUBWtr6D+farrvpKf1C8Pup4jVeILmY8TZjt7jc813jZCX6DCI0tMUxCG54JYfmMN AHGTLAyA==; From: Heiko Stuebner To: broonie@kernel.org Cc: Heiko Stuebner , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, quentin.schulz@cherry.de, Lee Jones , Sebastian Reichel , Heiko Stuebner Subject: [PATCH v3 7/7] spi: rockchip: Add an atomic transfer function Date: Wed, 18 Nov 2026 00:50:21 +0100 Message-ID: <20261117235021.2013719-8-heiko@sntech.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117235021.2013719-1-heiko@sntech.de> References: <20261117235021.2013719-1-heiko@sntech.de> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261117_235047_884509_7A59BEC3 X-CRM114-Status: GOOD ( 20.89 ) X-Spam-Score: -0.2 (/) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 From: Heiko Stuebner Rockchip SPI controllers are often used to handle SPI connected PMICs that also handle system power-off events, like the RK806. When the kernel signals the power-off, all the interrupts are already disabled, so regular SPI with its mutexes and DMA transfers does not work anymore. Implement an atomic transfer function that does SPI transfers polling the controller in a loop without any DMA or IRQ. This can successfully handle the power-off command to RK806, but also read back the 2 chip-id registers just fine before that, as a test. Signed-off-by: Heiko Stuebner --- drivers/spi/spi-rockchip.c | 121 +++++++++++++++++++++++++++++++++++++ 1 file changed, 121 insertions(+) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index ce1629e5a513..c28a4ef6b55f 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -7,12 +7,14 @@ #include #include #include +#include #include #include #include #include #include #include +#include #include #define DRIVER_NAME "rockchip-spi" @@ -218,6 +220,19 @@ static inline void wait_for_tx_idle(struct rockchip_spi *rs, bool target_mode) dev_warn(rs->dev, "spi controller is in busy state!\n"); } +/* atomic transfers only in host-mode */ +static inline void wait_for_tx_idle_atomic(struct rockchip_spi *rs) +{ + u32 sr; + int ret; + + ret = readl_relaxed_poll_timeout_atomic(rs->regs + ROCKCHIP_SPI_SR, sr, + !(sr & SR_BUSY), + 10, 5 * USEC_PER_MSEC); + if (ret) + dev_warn(rs->dev, "spi controller still in busy state!\n"); +} + static u32 get_fifo_len(struct rockchip_spi *rs) { u32 ver; @@ -724,6 +739,74 @@ static bool rockchip_spi_can_dma(struct spi_controller *ctlr, return xfer->len / bytes_per_word >= rs->fifo_len; } +static int rockchip_spi_transfer_atomic(struct spi_device *spi, struct spi_message *msg) +{ + struct spi_controller *ctlr = spi->controller; + struct rockchip_spi *rs = spi_controller_get_devdata(ctlr); + struct spi_transfer *xfer; + int ret = 0; + + if (!pm_runtime_active(rs->dev)) { + dev_err(rs->dev, "Failed to do atomic SPI transfer due to runtime suspend\n"); + return -EIO; + } + + spi_set_cs(spi, true, false); + + /* make sure all interrupts are masked and status cleared */ + writel_relaxed(0, rs->regs + ROCKCHIP_SPI_IMR); + writel_relaxed(0xffffffff, rs->regs + ROCKCHIP_SPI_ICR); + + list_for_each_entry(xfer, &msg->transfers, transfer_list) { + WARN_ON(readl_relaxed(rs->regs + ROCKCHIP_SPI_SSIENR) && + (readl_relaxed(rs->regs + ROCKCHIP_SPI_SR) & SR_BUSY)); + + rs->n_bytes = xfer->bits_per_word <= 8 ? 1 : 2; + + ret = rockchip_spi_config(rs, spi, xfer, false, false); + if (ret < 0) + goto out_disable; + + writel_relaxed(0, rs->regs + ROCKCHIP_SPI_RXFTLR); + + rs->tx = xfer->tx_buf; + rs->rx = xfer->rx_buf; + rs->tx_left = rs->tx ? xfer->len / rs->n_bytes : 0; + rs->rx_left = xfer->len / rs->n_bytes; + + spi_enable_chip(rs, true); + + while (rs->tx_left || rs->rx_left) { + u32 status = readl_relaxed(rs->regs + ROCKCHIP_SPI_SR); + + if (rs->tx_left && !(status & SR_TF_FULL)) + rockchip_spi_pio_writer(rs); + + if (rs->rx_left && !(status & SR_RF_EMPTY)) + rockchip_spi_pio_reader(rs); + } + + wait_for_tx_idle_atomic(rs); + + spi_enable_chip(rs, false); + + if (xfer->cs_change && !list_is_last(&xfer->transfer_list, &msg->transfers)) { + spi_set_cs(spi, false, false); + spi_transfer_cs_change_delay_exec(msg, xfer); + spi_set_cs(spi, true, false); + } + } + +out_disable: + spi_set_cs(spi, false, false); + msg->status = ret; + + if (msg->complete) + msg->complete(msg->context); + + return ret; +} + static int rockchip_spi_setup(struct spi_device *spi) { struct rockchip_spi *rs = spi_controller_get_devdata(spi->controller); @@ -752,6 +835,19 @@ static int rockchip_spi_setup(struct spi_device *spi) return 0; } +static int rockchip_spi_power_off(struct sys_off_data *data) +{ + struct rockchip_spi *rs = data->cb_data; + int ret; + + /* enable controller for possible calls from shutdown handlers */ + ret = pm_runtime_resume_and_get(rs->dev); + if (ret) + dev_warn(rs->dev, "spi controller failed to runtime resume: %d\n", ret); + + return 0; +} + static int rockchip_spi_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; @@ -860,6 +956,31 @@ static int rockchip_spi_probe(struct platform_device *pdev) ctlr->max_transfer_size = rockchip_spi_max_transfer_size; ctlr->handle_err = rockchip_spi_handle_err; + /* Only register atomic transfer in host-mode */ + if (!target_mode) { + ctlr->transfer_atomic = rockchip_spi_transfer_atomic; + + ret = devm_register_sys_off_handler(&pdev->dev, + SYS_OFF_MODE_POWER_OFF_PREPARE, + SYS_OFF_PRIO_DEFAULT, + &rockchip_spi_power_off, rs); + if (ret) { + dev_err_probe(&pdev->dev, ret, + "failed to register poweroff handler\n"); + goto err_disable_pm_runtime; + } + + ret = devm_register_sys_off_handler(&pdev->dev, + SYS_OFF_MODE_RESTART_PREPARE, + SYS_OFF_PRIO_DEFAULT, + &rockchip_spi_power_off, rs); + if (ret) { + dev_err_probe(&pdev->dev, ret, + "failed to register restart handler\n"); + goto err_disable_pm_runtime; + } + } + ctlr->dma_tx = dma_request_chan(rs->dev, "tx"); if (IS_ERR(ctlr->dma_tx)) { /* Check tx to see if we need to defer driver probing */ -- 2.53.0