Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: Igor Velkov <iav@iav.lv>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: coresight: cpu-debug: PC sampling via PMPCSR (FEAT_PCSRv8p2)?
Date: Wed, 18 Nov 2026 10:49:17 +0000	[thread overview]
Message-ID: <20261118104917.GW9176@e132581.arm.com> (raw)
In-Reply-To: <20261117-coresight-pmpcsr-reply-leo-2@iav.lv>

On Tue, Nov 17, 2026 at 08:50:00PM +0200, Igor Velkov wrote:
> On Tue, Nov 17, 2026 at 06:32:41PM +0000, Leo Yan wrote:
> > Could we explore a hook in the CPU hard lockup detector? Seems this
> > module is more relevant to hard lockup rather than panic.
> 
> Yes, that fits better. The hard lockup detector reports a CPU that
> missed its watchdog hrtimer interrupts, so it runs with IRQs masked and
> is not in an idle powerdown. The backtrace request then names the CPUs
> that did not answer ("these CPUS still haven't responded"). I would
> sample PCSR only for those, from a hook at that point, and leave the
> panic notifier alone. Does that sound right?

Yes, sampling CPUs that do not respond to the backtrace request sounds
reasonable.

The hard lockup detector can also call panic(), so we should avoid a
second dump from the panic notifier. After hook with hard-lockup
diagnosis, then makes sense to remove that panic notifier.

For CPU power state, could we take a cautious approach in the driver?

 1) If idle_cpu(cpu) == 0, sample the CPU directly.
 2) If idle_cpu(cpu) == 1, follow the existing flow to request
    power-up before sampling.
 3) Consider adding a module parameter, such as skip_idle, for
    hardware that doesn't support or honour EDPRCR_COREPURQ. This
    would allow the driver to sample only active CPUs.

Thanks,
Leo


      reply	other threads:[~2026-11-18 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  5:46 coresight: cpu-debug: PC sampling via PMPCSR (FEAT_PCSRv8p2)? Igor Velkov
2026-11-13  9:25 ` Suzuki K Poulose
2026-11-13 14:46 ` Leo Yan
2026-11-14  0:08   ` Igor Velkov
2026-11-17 18:32     ` Leo Yan
2026-11-17 18:50       ` Igor Velkov
2026-11-18 10:49         ` Leo Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118104917.GW9176@e132581.arm.com \
    --to=leo.yan@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=iav@iav.lv \
    --cc=james.clark@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mike.leach@arm.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox