From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94CA6606A32C for ; Thu, 19 Nov 2026 12:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kaEXRrUF; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=leZm7fKL DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Unsubscribe-Post:List-Owner; bh=Jl9oyBMBlY4JXOrQAW23CuXlJczhQJcy241+h238qgg=; b=kaEXRrUF927Tg3S+zM5JfYzQxD QCyyT77vs8e7uZVMZ05nTUpR+oK2G2D/PbVDkl3twkJ+92+ZDbBeudokcrHENI2ldqtL3pLsXcWz+ KHxJW9LhbhWRNBMxNWKW6zfth9TY9M9yr5ONrijPDf1aylPeDkX1+nqmScOLtROVvGn2FyG7CMQDG euaW/NTBuUFPdUtiV7RdXu1IHo3jh6vYsjDfFWMNBVMdGcfvU6kd1OOOfA3iRZZgeuWzdVcPEE1yM ra09AyIqfuhgwSsSNEocGmP2fM2vRcXnpyJWNITPjmzSIhAdqGvB9Qr95GnhHf/0r+jXPDaEy9s5n uboe7/rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU1a5-0000000BvXq-1XDM; Thu, 19 Nov 2026 12:49:37 +0000 Received: from mail-dy1-x1335.google.com ([2607:f8b0:4864:20::1335]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU1a2-0000000BvVl-1Qiq for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2026 12:49:35 +0000 Received: by mail-dy1-x1335.google.com with SMTP id 5a478bee46e88-381d542bc29so4017053eec.1 for ; Thu, 19 Nov 2026 04:49:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795092573; x=1795697373; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Jl9oyBMBlY4JXOrQAW23CuXlJczhQJcy241+h238qgg=; b=leZm7fKLy7oSvjzRK6T/nuRxpmigtgZr8GTXo9YOHKO4SSdD5lY+MOgrUf8YbOIg0A t+jLtwX8kTsdKF7nCvJR5In72qLV7+uchCJV0nz/O4EFj3P7RyoWzwgIsZUwq0mjhWsk lnlKMYJNtUvQ3Ei71RU6KNCrVflUNbHORLhGQT/yE/20wMhwr3uM2R/+8+AmoQUhusJj sQxM/AjPVFWBKWFudpSVE1ypB8w510jxMTfl54rUasN28eMyVRHh709+r0UO92OBGv4r rrEmeFbDxnliWiIoXne70l3PWcrH+w1wjCpRxoUJfYGeP0XkoorflIZFz7V6fuUNmiao m/ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795092573; x=1795697373; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Jl9oyBMBlY4JXOrQAW23CuXlJczhQJcy241+h238qgg=; b=Aw0jQxNcC0QDR4/mP+fOc72KowsG+YvoUolS85eh2kIUZyidFeafsD5AJKzgYyKOVB 2DmipUqAyPkYeIHP9HLI0mHoA0f1cPvKuL5cknERHVVJ2NZRFLeaK+qZvGiVZW/lF8vM a7yqpeOLxKphkuciXpdEYJ2/6rIUQx9aTQZsDPyHdjI2mrPOUSiBwqkfK6pXE7BAUaZl lWy3Qs46VOoMQcHykivGqI1TbuWm/mO4yFgYq+FI678IgH0AN1sqirgeJWOIB0JhNIia +U5HWnJ1/nJefLoPIJSwLi8P7App6JA9pN34dv6RupkvKgRWPz10yUcbF0jUxUdHsZPE 3JbA== X-Forwarded-Encrypted: i=1; AL+hErGt6jORG3lz5lqNsTkdBvZyrzGyDHhJCb77z6ncZ9tfVCKuGG0T4MQMMHYOKOOyGR310gVCcwKpvxYZzFIDRN6Y@lists.infradead.org X-Gm-Message-State: APuU4Z+w1ArKqzl9/cCCr6C40sWosyODG5BolTYd8rmKq1Wrhk+OBDR0 399ro5I5ig+CD9zYh2WGewUEpxLrCiImhIMN//DkS9PSQcWcscdfuYI7 X-Gm-Gg: AZFdTZfvHuJ32KpvGStm1s3/lyUyedRK8LGB0GvQ47Ge7lfzcHFe07QWZkhZt9XI7g4 ucRaCMsc4lx4CG5kii1fJpwg08vhObI+eknup+FVROywSUxvYGB3B8zgoB4LufPlpw2NXENJRMQ nQ4vd9XMJo8O0PELzlDuK1EHFhfQwlsjuD9myTDtVNPmcGBkTb0kPcgXlT3qBGMvjMThdo5xGR8 hz1Z0pv1CC96YOapuXH/7TlS1cVW6SY3ktoYoEfI80giCAYFqQgIkpiS8W2l3mQ77bNkl9Yolc6 xuMxg0Yc5KJIoBtv5TCX6TlDgNE1YZ1PUa4uy/BUk4mHdgCfTlHVjN02dfy+iLnc0i1p8FmIlVV DtJysInV2qPSN2FM0Fx9swYjhmDPwU2C4ugtr7eRK62cqhVM6m7RFQsLbCO/YUzwbyr3rsFMirL 2XUfWfuXkWGYOgh7e4UOpR0sugx+nPlsS96bosescZohXQjLoVQMHQ8JHT34ihsOvmkJIwpFPFK Jz51eegoUymn1MGuysvBc9GBtv6K174D+Wtlfn4Ojr/CcvPGQYcnq9sxCWkQmYHiRtIb47ZXyQZ uLQuL3iYB8reMC47eBGQ6lV42Q5J6546qHzPY4Fcz11coknaWDjwtt21mfXU5DQyUSSfr2Vjirw = X-Received: by 2002:a05:7301:1a14:b0:382:5dd0:3bb2 with SMTP id 5a478bee46e88-3827fe7882bmr4750485eec.9.1795092573428; Thu, 19 Nov 2026 04:49:33 -0800 (PST) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-382a7bc05cfsm17909542eec.26.2026.11.19.04.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 04:49:32 -0800 (PST) From: Maoyi Xie To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH] wifi: mt76: sdio: check the RX packet length in mt76s_rx_run_queue() Date: Thu, 19 Nov 2026 20:49:28 +0800 Message-Id: <20261119124928.1398520-1-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261119_044934_396407_1545EE62 X-CRM114-Status: GOOD ( 13.23 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 mt76s_rx_run_queue() reads the packets that the chip announced in the interrupt status into one buffer. It then takes the length of each packet from the first word of the packet and does not compare it with the bytes read. A larger length can make the driver read TX status records past the end of the buffer and build an skb that extends past it. Stop at a packet that does not fit in the bytes read. Found with a CodeQL-based static analysis tool that we are developing. Reproduced in a userspace harness under ASan, which reports no such read with this patch. Not tested on hardware, only compile-tested with W=1 on next-20261116. Fixes: dacf0acfe2ce ("mt76: sdio: extend sdio module to support CONNAC2") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- I used an LLM to help write the harness and this patch. drivers/net/wireless/mediatek/mt76/sdio_txrx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/sdio_txrx.c b/drivers/net/wireless/mediatek/mt76/sdio_txrx.c index 3f314e8e1e69f92..86dd1165d2c7f1f 100644 --- a/drivers/net/wireless/mediatek/mt76/sdio_txrx.c +++ b/drivers/net/wireless/mediatek/mt76/sdio_txrx.c @@ -127,6 +127,8 @@ mt76s_rx_run_queue(struct mt76_dev *dev, enum mt76_rxq_id qid, /* parse rxd to get the actual packet length */ len = le32_get_bits(rxd[0], GENMASK(15, 0)); + if (len > end - buf) + break; /* Optimized path for TXS */ if (!dev->drv->rx_check || dev->drv->rx_check(dev, buf, len)) { base-commit: 7e1392a42ea288d70a266f6553fe06f57f8647ea -- 2.34.1