From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C3A7606A324 for ; Thu, 19 Nov 2026 13:58:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=C3G5wTxs; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=qp2kg4x9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=3lTaBCqZF5G8fjlGAlGQP3TalbwWa07a5DbQshXZTOk=; b=C3G5wTxs1M3PAl 0sbH6bZH0Ku/WAFZ1FCC7ijEjHFT7KEop1BnQht7Q0PrgqSKaAm6w3BSaEF3OOtBoJpHzzV2VlBD4 mmwDIu+5R1EB3ueg6WKWMGWYfmMvgAMFhudpiKblC/TRtdqlf1xNipz7e7J1fSszOqGVFLGNoSDEu IC90NMx9BvgFez9gOHysse5KU/ECTm9Y5ronjHzD5tTP23EhNfM9pP3zcs0CkbVo+6dyd8lIB3+HY hu39osmlgC+O58BmxCTkq/d3rC1LhoA6CPVG+rrVrBMQdteXE1qP2bryBnS46XELZhNNwiyjzb2w8 hvX//DX+V93AiwomwGxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU2eo-0000000C9Es-2bE1; Thu, 19 Nov 2026 13:58:34 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU2ef-0000000C9A9-2XGx; Thu, 19 Nov 2026 13:58:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=3lTaBCqZF5G8fjlGAlGQP3TalbwWa07a5DbQshXZTOk=; b=qp2kg4x9gfr3I3leGdIHl9EBeZ BcSiihxgJ6LOkQpNKSt1epwz76ydXVYZiqFJjmpVDbgCjw6jGSOTXdEsjW9ft2lJH3m8oRvtUxX9Q Y6d/ZqcL6fOZXpwFz0ITmEiCupBVxHqNZaxBdqAKFEYs/pBk5IxYBQdLTGyjhn63OjdIQT1Lrff0O 5Jydw6VCNNxHzcnIBUCUbLC8FJYgOgwuPQcSusgEI4J2iBqc9uX8MrEHRDJud6CbgBAgy5wiA/Eta FvpnB5a1s6buC7AXHvEj0KHcuDDKRIvcsfaN8/b3J73ioeRm4wae4hEpxAWiNIEcvQfsKop+CSPQ7 5PHQEufg==; From: Heiko Stuebner To: broonie@kernel.org Cc: Heiko Stuebner , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, quentin.schulz@cherry.de, Lee Jones , Sebastian Reichel , Heiko Stuebner Subject: [PATCH v4 2/6] spi: Allow spi_delay_exec() to be used from atomic contexts Date: Thu, 19 Nov 2026 14:58:04 +0100 Message-ID: <20261119135808.2377849-3-heiko@sntech.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261119135808.2377849-1-heiko@sntech.de> References: <20261119135808.2377849-1-heiko@sntech.de> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261119_055826_005403_AC02FADE X-CRM114-Status: GOOD ( 13.20 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 From: Heiko Stuebner When using spi_delay_exec() only the fsleep in the subsequent _spi_transfer_delay_ns() can actually sleep. As we might want to use spi_delay_exec() from atomic contexts in the future, move the might_sleep() up to the actual place that matters and fall back to the existing ndelay if called from an atomic context. Signed-off-by: Heiko Stuebner --- drivers/spi/spi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 5e05f2fef12e..ec2074126910 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1730,11 +1730,12 @@ static void _spi_transfer_delay_ns(u32 ns) { if (!ns) return; - if (ns <= NSEC_PER_USEC) { + if (ns <= NSEC_PER_USEC || spi_in_atomic()) { ndelay(ns); } else { u32 us = DIV_ROUND_UP(ns, NSEC_PER_USEC); + might_sleep(); fsleep(us); } } @@ -1782,8 +1783,6 @@ int spi_delay_exec(struct spi_delay *_delay, struct spi_transfer *xfer) { int delay; - might_sleep(); - if (!_delay) return -EINVAL; -- 2.53.0