From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C912606A337 for ; Thu, 19 Nov 2026 20:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=c7+XaPCO; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=k7n02MHz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=FDB56P32FDl6bNezdwAQqP1h7o3uxulTq1XdU+fw3Dc=; b=c7+XaPCO/WfqhB jr6n0ByApjxX29utfvEjFO5s6VQQTUKzqbnkFNC/rARu3RwUcAUUHf+SE6zPlrKP/vfLdKB8oGWy9 mQiV5b+FIOEtgm2fkJ2EYlsOwmQEK3TOmzT88qLsMg85SGYKp4M8H3mcXm9T3wBvTd1LUmqubjTs2 VRXx1w/y9aQiEwtjQTTO+y9LXBJKnr7svEMC/bohchd90iAWfpsjvBGlRtnURGEmPWQDg3dJOXCl9 ECbhe43PcKndxbpA8EFJ42ec7JP+V/CWohg2IsUAxh0bM9xxzu6vioKZ4YZrNuTf7E1/vZPC/YpId 3xUruRK2cLIU1Oeq0PFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU95m-0000000DQO4-2DPm; Thu, 19 Nov 2026 20:50:50 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU95h-0000000DQKX-1pCu for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2026 20:50:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 355C740D96; Thu, 19 Nov 2026 20:50:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACA301F000C4; Thu, 19 Nov 2026 20:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795121445; bh=FDB56P32FDl6bNezdwAQqP1h7o3uxulTq1XdU+fw3Dc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=k7n02MHztF0PvsBN+690dzA3kvbjK4CRb1fMM0D3f0cFAmO5F267CgygHQZ9Z0/AC jIDOp9koldOGaQcEwCo92stfsidMLOcD3n3w3Id07rWsw6q3fm2/gpeSHTR1wgastJ mY/1XbhhrF0xC4sudKcprrg7SVuGwklHHxSdhJe4Mpvc9e4gv1SLLXZF5lkvfMp1oO Zsyn/1p51f0X2s7/pAUjTSpjYshV0sC8SQ2zXJz7Ejg/JrfQp3b5+hVz38bzQwVzzV IPRScHZgjSYZ0u5V8ljPaFELbkHtoONu28JUxQJWlN2TYUlWjNfhGMjkZAqWLcfYT5 rfjdaF4pyYKPQ== From: Lee Jones To: lee@kernel.org, Jacky Huang , Shan-Chun Hung , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH v2 04/12] pinctrl: nuvoton: ma35: Assign fwnode to gpio_chip in ma35_gpiolib_register() Date: Thu, 19 Nov 2026 20:49:00 +0000 Message-ID: <20261119205013.2563811-5-lee@kernel.org> X-Mailer: git-send-email 2.56.1.750.gf70dc682cf-goog In-Reply-To: <20261119205013.2563811-1-lee@kernel.org> References: <20261119205013.2563811-1-lee@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 ma35_gpiolib_register() registers all 14 GPIO banks under the same parent platform device without setting bank->chip.fwnode to the child bank node. Consequently, all GPIO banks share the parent pinctrl node for OF/fwnode lookups, preventing consumer drivers from resolving phandles to individual GPIO bank child nodes (&gpiob, &gpioc, etc.). Set bank->chip.fwnode to bank->fwnode before registering each GPIO chip. Fixes: f805e356313b ("pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver") Closes: https://sashiko.dev/#/bug/linux-cbafd8f2-6541-4311-b97b-f7285d2e1992 Cc: stable@vger.kernel.org Signed-off-by: Lee Jones --- v1 => v2: No changes drivers/pinctrl/nuvoton/pinctrl-ma35.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/nuvoton/pinctrl-ma35.c b/drivers/pinctrl/nuvoton/pinctrl-ma35.c index c9e09c14a101..a92945b7821f 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-ma35.c +++ b/drivers/pinctrl/nuvoton/pinctrl-ma35.c @@ -519,6 +519,7 @@ static int ma35_gpiolib_register(struct platform_device *pdev, struct ma35_pinct bank->irqinten = 0; bank->chip.label = bank->name; bank->chip.parent = &pdev->dev; + bank->chip.fwnode = bank->fwnode; bank->chip.request = ma35_gpio_core_to_request; bank->chip.direction_input = ma35_gpio_core_direction_in; bank->chip.direction_output = ma35_gpio_core_direction_out; -- 2.56.1.750.gf70dc682cf-goog