From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E13C0606A6E0 for ; Fri, 20 Nov 2026 19:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=WZ3CwcMu; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=eZ4jKi1X DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=r1t6hXxpnEN8Y+0K+jURR9P4uCOXwlVnTuqlNkdIH4s=; b=WZ3CwcMuapaWnOcxAUwOMaMHPA RqhXXzVcdGnLO4PrYXHXDUfHiuq4tZZAl6LER810XNlteCeiNKLaC0MqOkkC+Ong4h2S0hlzk8MfK 2z4IKRwDGk+LLSG64tUQHXlPVaUjzJq8yTpF4i+eRcn/hS31g6Fzp2j/beIGjS7HhbjryJunWrvZl nP+/yN2jVXKxzGHb8mgUAmx1YmULyP8TLjWsIw0Cbsca/uAEjPMF2AoSLhWNop4J/qzeJxMsnAccg /ivNt6JkemUOgXLOMWu8XZ13hrxyTlqsOM/vy01wKR+5p6HUhmfJo24AKVDLNfSQ5+iOyaD7TkUex 4ZIbU5LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUUDq-0000000G4wu-2P7I; Fri, 20 Nov 2026 19:24:34 +0000 Received: from mail-dy1-x1345.google.com ([2607:f8b0:4864:20::1345]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUUDR-0000000G4mW-3Kzz for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2026 19:24:17 +0000 Received: by mail-dy1-x1345.google.com with SMTP id 5a478bee46e88-3821eb27024so2028188eec.1 for ; Fri, 20 Nov 2026 11:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795202648; x=1795807448; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r1t6hXxpnEN8Y+0K+jURR9P4uCOXwlVnTuqlNkdIH4s=; b=eZ4jKi1Xf9lU9gL1R4l4Qs6pBX6FyzxRhijb9ihdNKTB9LXK0hHWv+p+4qOxrXatRH gVvz44JaK0dbB/LI/mItdO8MUW65EmqRdlW/pAuF/lWpA4TFOPxNCgKOkLeUVaQsOafj 8G0QAcM8ixTXCzvnrnv0kokcCJDBaA7eSW7nhazBDnRz+kUMwkkI5Ct0dt9op/UQrN0z Hm5V45UKj5j2R5YLnN19xmfg2P87n7/1YUizxCyQ8ogj6TRDCM/Gp7g/hVCZZf8HWVgq vYzXccdPBeoQ8vnh0BXngonoYikCGV23LJc83jdH0SjD8owGvzTp0oDQ5ixfGuOjH3lx /2Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795202648; x=1795807448; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r1t6hXxpnEN8Y+0K+jURR9P4uCOXwlVnTuqlNkdIH4s=; b=ef+SF7BZ5iwmHLAyIv9crwwWPLYigkZI3jo5bh/Yk+Q10ozLgOgpc22O7Jjqgh3JEp b6YBz+CeNpaijikwoDIaSwOnTbltKmVnuD+Pmyv3pvJiFIaSGCdKQqrc5bkKnCNAFOv4 vOyJCtZUJyFhMyUH7qfttmJUFXgG4wNH1eEp1cVbcQMTbDhKVJSk3VoUxgHzojYlY5Xj uFKLE60CGUYTWA3WvtCw+x56a2S/PE+MFtH+v9qyqVn5M60CJb6tk0jxb81aLpJyPEQU QmYR8Uaogx8+0bpW/a6/xnSO+SIb6psy3ERSBhU6mkvkF/l1YguKly0VBfHB4qeCXjJY 4tPQ== X-Forwarded-Encrypted: i=1; AL+hErG53JTDW6peP88HYP6OqAHSoZ2vdk0vUV94iKBnkSvdY0rK4CfSN0IkObuTKhb9yjSjpLIFZgBch+lLw81Z3uzf@lists.infradead.org X-Gm-Message-State: APuU4Z+REFJB/7zo1ljf7WfYxubU7lt3/C5VLKMmN3KTUCBW51oylBn5 zsE2ameoXWoGAOdloJvolRxE3B0WWuMcjqcR+M0OHHW2Ikt5hUiHeMJrDWgw91O9IRdlskbPB5h KDQ== X-Received: from dybmf40.prod.google.com ([2002:a05:7301:928:b0:36c:9b55:8436]) (user=elkin job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:7188:b0:384:b800:2adf with SMTP id 5a478bee46e88-38571027b9dmr3890778eec.27.1795202647857; Fri, 20 Nov 2026 11:24:07 -0800 (PST) Date: Fri, 20 Nov 2026 19:22:37 +0000 In-Reply-To: <20261120192237.2870582-1-elkin@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261120192237.2870582-1-elkin@google.com> X-Mailer: git-send-email 2.56.1.750.gf70dc682cf-goog Message-ID: <20261120192237.2870582-3-elkin@google.com> Subject: [PATCH 2/2] ASoC: mediatek: mt8189: clear afe->regmap on devm_regmap_init_mmio() error From: Elkin Cruz To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev, irogers@google.com, Elkin Cruz Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261120_112409_895771_1E75616E X-CRM114-Status: GOOD ( 11.87 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-26.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 When devm_regmap_init_mmio() fails in mt8189_afe_pcm_dev_probe(), afe->regmap holds an ERR_PTR() while unwinding through err_pm_put -> pm_runtime_put_sync(), which invokes mt8189_afe_runtime_suspend(). Because mt8189_afe_runtime_suspend() only checks if (!afe->regmap), the ERR_PTR() value is passed to regmap_write() and regcache_cache_only(). Clear afe->regmap to NULL before jumping to err_pm_put. Fixes: 5404599c3292 ("ASoC: mediatek: mt8189: Fix probe resource cleanup") Signed-off-by: Elkin Cruz --- sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c index f39b01590f71..85b5be6d45ec 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2563,6 +2563,7 @@ static int mt8189_afe_pcm_dev_probe(struct platform_device *pdev) &mt8189_afe_regmap_config); if (IS_ERR(afe->regmap)) { ret = PTR_ERR(afe->regmap); + afe->regmap = NULL; goto err_pm_put; } -- 2.56.1.750.gf70dc682cf-goog