From: Jonas Karlman <jonas@kwiboo.se>
To: Heiko Stuebner <heiko@sntech.de>,
Linus Walleij <linusw@kernel.org>,
Ye Zhang <ye.zhang@rock-chips.com>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jonas Karlman <jonas@kwiboo.se>
Subject: [PATCH] pinctrl: rockchip: Fix pull configuration readback on RK3506
Date: Sat, 21 Nov 2026 15:58:09 +0000 [thread overview]
Message-ID: <20261121155810.706866-1-jonas@kwiboo.se> (raw)
rockchip_get_pull() is missing a RK3506 case and instead returns -EINVAL
for all pins. As a result, the pinconf-pins debugfs file omits the pull
configuration for all pins on RK3506:
pin 0 (gpio0-0): ..., pin output (1 level)
pin 1 (gpio0-1): ..., pin output (1 level)
pin 2 (gpio0-2): ..., pin output (1 level)
pin 3 (gpio0-3): ..., pin output (0 level)
Add RK3506 to the case that decodes the pull configuration from the
register value to fix pull configuration readback on RK3506.
After this the pinconf-pins debugfs file includes pull configuration:
pin 0 (gpio0-0): input bias pull up (1 ohms), ..., pin output (1 level)
pin 1 (gpio0-1): input bias pull down (1 ohms), ..., pin output (1 level)
pin 2 (gpio0-2): input bias pull up (1 ohms), ..., pin output (1 level)
pin 3 (gpio0-3): input bias pull down (1 ohms), ..., pin output (0 level)
Fixes: dbd2317d7b9f ("pinctrl: rockchip: Add rk3506 pinctrl support")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
Based-on: <20261120201540.672016-1-jonas@kwiboo.se>
---
drivers/pinctrl/pinctrl-rockchip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index 97a73f8c4f6e..cad602fa41ae 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -3910,6 +3910,7 @@ static int rockchip_get_pull(struct rockchip_pin_bank *bank, int pin_num)
case RK3328:
case RK3368:
case RK3399:
+ case RK3506:
case RK3528:
case RK3562:
case RK3568:
--
2.56.1
next reply other threads:[~2026-11-21 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 15:58 Jonas Karlman [this message]
2026-11-21 16:09 ` [PATCH] pinctrl: rockchip: Fix pull configuration readback on RK3506 Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121155810.706866-1-jonas@kwiboo.se \
--to=jonas@kwiboo.se \
--cc=heiko@sntech.de \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox