From: "Heiko Stübner" <heiko@sntech.de>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: David Airlie <airlied@linux.ie>, Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count
Date: Thu, 09 Jan 2020 01:15:40 +0100 [thread overview]
Message-ID: <2028959.b8b8FNkPgY@diego> (raw)
In-Reply-To: <20200108223949.355975-2-t.schramm@manjaro.org>
Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm:
> commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes
> the type of variables used to store the display port data rate and
> number of lanes to u8. However u8 is not sufficient to store the link
> data rate of the display port.
> This commit reverts the type of both the number of lanes and the data
> rate to unsigned int.
>
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
> ---
> drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h
> index 83c4586665b4..806cb0b08982 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h
> @@ -94,8 +94,8 @@ struct cdn_dp_device {
> struct video_info video_info;
> struct cdn_dp_port *port[MAX_PHY];
> u8 ports;
> - u8 max_lanes;
> - u8 max_rate;
> + unsigned int max_lanes;
although I would think u8 should be enough for max_lanes?
There shouldn't be be more than 255 dp lanes?
Heiko
> + unsigned int max_rate;
> u8 lanes;
> int active_port;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-09 0:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 22:39 [PATCH 0/1] Regression in rockchipdrm Tobias Schramm
2020-01-08 22:39 ` [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count Tobias Schramm
2020-01-09 0:15 ` Heiko Stübner [this message]
2020-01-09 6:56 ` Tobias Schramm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2028959.b8b8FNkPgY@diego \
--to=heiko@sntech.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).