From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D18C10F0E for ; Fri, 12 Apr 2019 09:40:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 836C92082E for ; Fri, 12 Apr 2019 09:40:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sjzEx+oK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="rqzKKL8I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 836C92082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wR3m2PkfOWRwleefW2atfyNWZx5de9KeCzrJAwCbgrk=; b=sjzEx+oK8x1H2A hl98x5XvyBWuXfWpcMV92PbVQHx8G1ObtyJkJButJg6vDNlMen/qoJ/vb89pno6q7swksXfTaJT55 K/W34d16vwwGvNMcF8MuUtW1QDeJhS0iPFunag9F7/uVmiq4kwCgzInlr7eljRONZCDHCI2vIyG/A nPt4EBWMIAXA0sJWzT6DRyYEg6e8V3LYCTAnf1WEcDALwxzsiIsnD6U4J/ZHdxHCtMl/woNgS0/ZA U5ektCfvna0llFOFrpr+eFGazcx1SI2fTdWQ1QH4ZwLplyZ1TE1h2nosKtjzjdF9CgLyFhuSqJb3P bRlhs9XS1wKM6tTnqMrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEsg3-0006C8-64; Fri, 12 Apr 2019 09:40:55 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEsg1-0006B3-Ni; Fri, 12 Apr 2019 09:40:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tkuEFPIlJsaMW+VpbideKFboq0EXchlFYtOb3qNXGs0=; b=rqzKKL8I8kHJ9ExPNLznYcpCH4 MIsqU45BH6T0GGTo0lE0FhnW3C55Zk5L7ZZnV5cU79c95rmT8Lm6D6YlJBF+Ve9ufUCTPLImbChmP eWGrcO0EXaNhaRFmWH2W6uQr9ssO57JgoU1QR3jdQ20CmGrRxC84ypTE5Aor0AOyy14sy74tkcoLV hjdeud98SLxVrWbrnmu2+y15A+NjK1t4miSL/f3nYM38BFf6L1b4QlrmgxcAz0b6D+cE3z0MigI8x JGF2TzOGKwb+cqTAO+8io9PPg1wj35oWUNEYWisRmdcBKl92wUJ98xdZLgKOGYywpAB22IJxJqHrz zqRrRrEg==; Received: from gloria.sntech.de ([185.11.138.130]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEsW8-0005Nn-Ps; Fri, 12 Apr 2019 09:30:44 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hEsW6-0004Ou-7u; Fri, 12 Apr 2019 11:30:38 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Matthias Kaehlcke Subject: Re: [PATCH] clk: rockchip: rk3288: Limit use of USB PHY clock to USB Date: Fri, 12 Apr 2019 11:30:37 +0200 Message-ID: <2029012.W0xZ3ly3fY@diego> In-Reply-To: <20190412001657.GV112750@google.com> References: <20190411175917.173566-1-mka@chromium.org> <3787637.WUkDPpUsF8@diego> <20190412001657.GV112750@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_103040_932518_09E69441 X-CRM114-Status: GOOD ( 31.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, Douglas Anderson , linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 12. April 2019, 02:16:57 CEST schrieb Matthias Kaehlcke: > Hi Heiko, > = > On Thu, Apr 11, 2019 at 09:03:07PM +0200, Heiko St=FCbner wrote: > > Hi Matthias, > > = > > Am Donnerstag, 11. April 2019, 19:59:17 CEST schrieb Matthias Kaehlcke: > > > The USB PHY clock can be configured as (grand) parent of uart0_sclk a= nd > > > sclk_gpu. It has been observed that UART0 doesn't work reliably in hi= gh > > > speed mode with the PHY clock as input when certain USB devices are > > > plugged to the USB HOST1 port (see https://crrev.com/c/320543). > > > = > > > Prefix the name of the PHY clock with a '.' in the non-USB muxes to > > > effectively remove the clock as input from these muxes. > > > = > > > Signed-off-by: Matthias Kaehlcke > > > --- > > > drivers/clk/rockchip/clk-rk3288.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > = > > > diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip= /clk-rk3288.c > > > index 5a67b7869960..677bc5485201 100644 > > > --- a/drivers/clk/rockchip/clk-rk3288.c > > > +++ b/drivers/clk/rockchip/clk-rk3288.c > > > @@ -200,8 +200,8 @@ PNAME(mux_aclk_cpu_src_p) =3D { "cpll_aclk_cpu", = "gpll_aclk_cpu" }; > > > PNAME(mux_pll_src_cpll_gpll_p) =3D { "cpll", "gpll" }; > > > PNAME(mux_pll_src_npll_cpll_gpll_p) =3D { "npll", "cpll", "gpll" }; > > > PNAME(mux_pll_src_cpll_gpll_npll_p) =3D { "cpll", "gpll", "npll" }; > > > -PNAME(mux_pll_src_cpll_gpll_usb480m_p) =3D { "cpll", "gpll", "usbphy= 480m_src" }; > > > -PNAME(mux_pll_src_cpll_gll_usb_npll_p) =3D { "cpll", "gpll", "usbphy= 480m_src", "npll" }; > > > +PNAME(mux_pll_src_cpll_gpll_usb480m_p) =3D { "cpll", "gpll", ".usbph= y480m_src" }; > > > +PNAME(mux_pll_src_cpll_gll_usb_npll_p) =3D { "cpll", "gpll", ".usbph= y480m_src", "npll" }; > > = > > In general I like to have things like the clock-tree described fully > > and let the kernel handle correct sourcing ... but: > > = > > As you write this seems like a systemic problem when just connecting > > random peripherals can create unstable clock source frequencies, > > so I tend to agree here ... but: > > = > > Can we please find a more "talking" name for this ... because as with t= he > > above someone will find the "." and submit a fix for it ;-) . > > = > > So just name it "unstable_dummy" or so? > = > I looked for some common pattern, but couldn't find one. I liked the > '.' since it leaves the name of the clock mostly intact, just hiding > it (similar to a leading '.' in a Linux file system). But I agree that > it might not be expressive enough. I still like the idea to keep the > clock name around for reference, maybe we could name it > "unstable:usbphy480m_src" or similar. If you don't object I'll send a > patch with this some time tomorrow. I've just adapted the patch to use the new parent-name you suggested and applied it for 5.2 So no need to resend :-) . Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel