public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/13] ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c
Date: Thu, 13 Feb 2014 12:50:15 +0100	[thread overview]
Message-ID: <2036226.egxWL7qC66@wuerfel> (raw)
In-Reply-To: <1392289475-8902-2-git-send-email-thomas.petazzoni@free-electrons.com>

On Thursday 13 February 2014 12:04:23 Thomas Petazzoni wrote:
> In preparation to the introduction of the support of Armada 375 and
> Armada 38x, this commit renames arch/arm/mach-mvebu/armada-370-xp.c to
> arch/arm/mach-mvebu/armada-mvebu.c. The armada-mvebu.c name was chosen
> because:
> 
>  * As we are going to merge the support for Kirkwood and Dove into
>    mach-mvebu, there will be other files with DT_MACHINE_START
>    structures, so a generic name such as board-dt.c or mvebu.c does
>    not work.
> 
>  * A simple armada.c does not work, because there are Marvell Armada
>    SOCs that are not part of the MVEBU family. For example, the
>    Marvell Armada 1500 are part of the mach-berlin family, which is a
>    completely separate line of SOCs.

Your reasoning for the new name makes a lot of sense, but my personal
opinion is that I'd rather leave the name as it is and deal with the
fact that it's not the best name. Renaming files often causes unexpected
problems, in particular if someone else wants to modify the same file.

	Arnd

  reply	other threads:[~2014-02-13 11:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 11:04 [PATCH v3 00/13] Core support for Marvell Armada 375 and 38x Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 01/13] ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c Thomas Petazzoni
2014-02-13 11:50   ` Arnd Bergmann [this message]
2014-02-13 11:55     ` Thomas Petazzoni
2014-02-13 12:52       ` Arnd Bergmann
2014-02-13 13:07       ` Jason Cooper
2014-02-13 13:13         ` Thomas Petazzoni
2014-02-13 13:24           ` Sebastian Hesselbarth
2014-02-13 13:29             ` Thomas Petazzoni
2014-02-17  2:49               ` Jason Cooper
2014-02-17 10:23                 ` Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 02/13] ARM: mvebu: rename DT machine structure for Armada 370/XP Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 03/13] ARM: mvebu: make CPU_PJ4B selection a per-SoC choice Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 04/13] ARM: mvebu: add Armada 375 support to the system-controller driver Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 05/13] ARM: mvebu: add initial support for the Armada 375 SOCs Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 06/13] ARM: mvebu: add workaround for data abort issue on Armada 375 Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 07/13] ARM: mvebu: add Device Tree description of the Armada 375 SoC Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 08/13] ARM: mvebu: add Device Tree for the Armada 375 DB board Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 09/13] ARM: mvebu: add initial support for the Armada 380/385 SOCs Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 10/13] ARM: mvebu: add Device Tree description of the Armada 380/385 SoCs Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 11/13] ARM: mvebu: add Device Tree for the Armada 385 DB board Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 12/13] ARM: mvebu: update defconfigs for Armada 375 and 38x Thomas Petazzoni
2014-02-13 11:04 ` [PATCH v3 13/13] Documentation: arm: update Marvell documentation about Armada 375/38x Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2036226.egxWL7qC66@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox