linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1
@ 2025-11-01 12:00 Chukun Pan
  2025-11-01 12:00 ` [PATCH 2/6] arm64: dts: rockchip: fixes regulator " Chukun Pan
                   ` (6 more replies)
  0 siblings, 7 replies; 11+ messages in thread
From: Chukun Pan @ 2025-11-01 12:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Chukun Pan, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

Add missing MMC aliases. Remove the max-frequency property
from the MMC node, which is already defined in rk3576.dtsi.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
index 59c172573cf8..9cbd3fae16ab 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
@@ -19,6 +19,8 @@ / {
 	aliases {
 		ethernet0 = &gmac0;
 		ethernet1 = &gmac1;
+		mmc0 = &sdhci;
+		mmc1 = &sdmmc;
 	};
 
 	chosen {
@@ -735,7 +737,6 @@ &sai6 {
 &sdhci {
 	bus-width = <8>;
 	full-pwr-cycle-in-suspend;
-	max-frequency = <200000000>;
 	mmc-hs400-1_8v;
 	mmc-hs400-enhanced-strobe;
 	no-sdio;
@@ -749,7 +750,6 @@ &sdmmc {
 	cap-mmc-highspeed;
 	cap-sd-highspeed;
 	disable-wp;
-	max-frequency = <200000000>;
 	sd-uhs-sdr104;
 	vmmc-supply = <&vcc_3v3_s3>;
 	vqmmc-supply = <&vccio_sd_s0>;
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/6] arm64: dts: rockchip: fixes regulator for 100ASK DshanPi A1
  2025-11-01 12:00 [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Chukun Pan
@ 2025-11-01 12:00 ` Chukun Pan
  2025-11-01 12:00 ` [PATCH 3/6] arm64: dts: rockchip: fixes ethernet " Chukun Pan
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Chukun Pan @ 2025-11-01 12:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Chukun Pan, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

Referencing the schematic [1], correct the names of the USB
regulator, remove these non-existent RTC and UFS regulators.

[1] https://dl.100ask.net/Hardware/MPU/RK3576-DshanPi-A1/DshanPi-A1-RK3576-SCH_V1.1.pdf

Fixes: d809417c5a40 ("arm64: dts: rockchip: add DTs for 100ASK DShanPi A1")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../dts/rockchip/rk3576-100ask-dshanpi-a1.dts | 46 ++-----------------
 1 file changed, 3 insertions(+), 43 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
index 9cbd3fae16ab..f8bc401e796f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
@@ -85,16 +85,6 @@ vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 {
 		vin-supply = <&vcc_5v0_sys>;
 	};
 
-	vcc_1v2_ufs_vccq_s0: regulator-vcc-1v2-ufs-vccq-s0 {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc_1v2_ufs_vccq_s0";
-		regulator-always-on;
-		regulator-boot-on;
-		regulator-min-microvolt = <1200000>;
-		regulator-max-microvolt = <1200000>;
-		vin-supply = <&vcc_5v0_sys>;
-	};
-
 	vcc_1v8_s0: regulator-vcc-1v8-s0 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_1v8_s0";
@@ -105,16 +95,6 @@ vcc_1v8_s0: regulator-vcc-1v8-s0 {
 		vin-supply = <&vcc_1v8_s3>;
 	};
 
-	vcc_1v8_ufs_vccq2_s0: regulator-vcc-1v8-ufs-vccq2-s0 {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc_1v8_ufs_vccq2_s0";
-		regulator-always-on;
-		regulator-boot-on;
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
-		vin-supply = <&vcc_1v8_s3>;
-	};
-
 	vcc_2v0_pldo_s3: regulator-vcc-2v0-pldo-s3 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_2v0_pldo_s3";
@@ -135,16 +115,6 @@ vcc_3v3_m2: regulator-vcc-3v3-m2 {
 		vin-supply = <&vcc_5v0_sys>;
 	};
 
-	vcc_3v3_rtc_s5: regulator-vcc-3v3-rtc-s5 {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc_3v3_rtc_s5";
-		regulator-always-on;
-		regulator-boot-on;
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-		vin-supply = <&vcc_5v0_sys>;
-	};
-
 	vcc_3v3_s0: regulator-vcc-3v3-s0 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_3v3_s0";
@@ -165,27 +135,17 @@ vcc_5v0_sys: regulator-vcc-5v0-sys {
 		vin-supply = <&vcc_in>;
 	};
 
-	vcc_5v0_typec0: regulator-vcc-5v0-typec0 {
+	vbus5v0_typec: regulator-vbus5v0-typec {
 		compatible = "regulator-fixed";
 		enable-active-high;
 		gpios = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&typec5v_pwren_h>;
-		regulator-name = "vcc_5v0_typec0";
+		regulator-name = "vbus5v0_typec";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 		vin-supply = <&vcc_5v0_sys>;
 	};
-
-	vcc_3v3_ufs_s0: regulator-vcc-ufs-s0 {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc_3v3_ufs_s0";
-		regulator-always-on;
-		regulator-boot-on;
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-		vin-supply = <&vcc_5v0_sys>;
-	};
 };
 
 &combphy0_ps {
@@ -761,7 +721,7 @@ &u2phy0 {
 };
 
 &u2phy0_otg {
-	phy-supply = <&vcc_5v0_typec0>;
+	phy-supply = <&vbus5v0_typec>;
 	status = "okay";
 };
 
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/6] arm64: dts: rockchip: fixes ethernet for 100ASK DshanPi A1
  2025-11-01 12:00 [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Chukun Pan
  2025-11-01 12:00 ` [PATCH 2/6] arm64: dts: rockchip: fixes regulator " Chukun Pan
@ 2025-11-01 12:00 ` Chukun Pan
  2025-11-01 12:00 ` [PATCH 4/6] arm64: dts: rockchip: fixes supply " Chukun Pan
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Chukun Pan @ 2025-11-01 12:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Chukun Pan, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

Currently, Ethernet is unusable due to an incorrect PHY address.
This commit fixes this, removes the incorrect 25M clock pinctrl,
and adds the missing PHY supply.

Fixes: d809417c5a40 ("arm64: dts: rockchip: add DTs for 100ASK DShanPi A1")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../dts/rockchip/rk3576-100ask-dshanpi-a1.dts     | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
index f8bc401e796f..425a78db9522 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
@@ -192,6 +192,7 @@ &gmac0 {
 	clock_in_out = "output";
 	phy-mode = "rgmii-id";
 	phy-handle = <&rgmii_phy0>;
+	phy-supply = <&vcc_3v3_s0>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&eth0m0_miim
 		     &eth0m0_tx_bus2
@@ -205,13 +206,13 @@ &gmac1 {
 	clock_in_out = "output";
 	phy-mode = "rgmii-id";
 	phy-handle = <&rgmii_phy1>;
+	phy-supply = <&vcc_3v3_s0>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&eth1m0_miim
 		     &eth1m0_tx_bus2
 		     &eth1m0_rx_bus2
 		     &eth1m0_rgmii_clk
-		     &eth1m0_rgmii_bus
-		     &ethm0_clk1_25m_out>;
+		     &eth1m0_rgmii_bus>;
 	status = "okay";
 };
 
@@ -618,10 +619,9 @@ es8388: audio-codec@10 {
 };
 
 &mdio0 {
-	rgmii_phy0: phy@1 {
+	rgmii_phy0: phy@0 {
 		compatible = "ethernet-phy-ieee802.3-c22";
-		reg = <0x1>;
-		clocks = <&cru REFCLKO25M_GMAC0_OUT>;
+		reg = <0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&gmac0_rst>;
 		reset-assert-us = <20000>;
@@ -631,10 +631,9 @@ rgmii_phy0: phy@1 {
 };
 
 &mdio1 {
-	rgmii_phy1: phy@1 {
+	rgmii_phy1: phy@0 {
 		compatible = "ethernet-phy-ieee802.3-c22";
-		reg = <0x1>;
-		clocks = <&cru REFCLKO25M_GMAC1_OUT>;
+		reg = <0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&gmac1_rst>;
 		reset-assert-us = <20000>;
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 4/6] arm64: dts: rockchip: fixes supply for 100ASK DshanPi A1
  2025-11-01 12:00 [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Chukun Pan
  2025-11-01 12:00 ` [PATCH 2/6] arm64: dts: rockchip: fixes regulator " Chukun Pan
  2025-11-01 12:00 ` [PATCH 3/6] arm64: dts: rockchip: fixes ethernet " Chukun Pan
@ 2025-11-01 12:00 ` Chukun Pan
  2025-11-01 12:00 ` [PATCH 5/6] arm64: dts: rockchip: fixes audio " Chukun Pan
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Chukun Pan @ 2025-11-01 12:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Chukun Pan, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

From the schematic, the supply of ES8388 chip and the vmmc-supply
of SD card both originate from the VCC3V3_S0 regulator, fix it.

Fixes: d809417c5a40 ("arm64: dts: rockchip: add DTs for 100ASK DShanPi A1")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
index 425a78db9522..7c961cb27032 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
@@ -606,9 +606,9 @@ es8388: audio-codec@10 {
 		compatible = "everest,es8388", "everest,es8328";
 		reg = <0x10>;
 		clocks = <&cru CLK_SAI1_MCLKOUT_TO_IO>;
-		AVDD-supply = <&vcca_3v3_s0>;
+		AVDD-supply = <&vcc_3v3_s0>;
 		DVDD-supply = <&vcc_3v3_s0>;
-		HPVDD-supply = <&vcca_3v3_s0>;
+		HPVDD-supply = <&vcc_3v3_s0>;
 		PVDD-supply = <&vcc_3v3_s0>;
 		assigned-clocks = <&cru CLK_SAI1_MCLKOUT_TO_IO>;
 		assigned-clock-rates = <12288000>;
@@ -710,7 +710,7 @@ &sdmmc {
 	cap-sd-highspeed;
 	disable-wp;
 	sd-uhs-sdr104;
-	vmmc-supply = <&vcc_3v3_s3>;
+	vmmc-supply = <&vcc_3v3_s0>;
 	vqmmc-supply = <&vccio_sd_s0>;
 	status = "okay";
 };
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 5/6] arm64: dts: rockchip: fixes audio for 100ASK DshanPi A1
  2025-11-01 12:00 [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Chukun Pan
                   ` (2 preceding siblings ...)
  2025-11-01 12:00 ` [PATCH 4/6] arm64: dts: rockchip: fixes supply " Chukun Pan
@ 2025-11-01 12:00 ` Chukun Pan
  2025-11-01 12:00 ` [PATCH 6/6] arm64: dts: rockchip: update 100ASK DshanPi A1 support Chukun Pan
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Chukun Pan @ 2025-11-01 12:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Chukun Pan, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

Correct the i2c address of the ES8388 chip and the gpio of hp_det pin.
According to the schematic, the ES8388 chip is connected to the SoC's
sai2 controller instead of sai1, fix it.

Fixes: d809417c5a40 ("arm64: dts: rockchip: add DTs for 100ASK DShanPi A1")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../dts/rockchip/rk3576-100ask-dshanpi-a1.dts | 23 ++++++++-----------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
index 7c961cb27032..815f75e7cd70 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
@@ -46,7 +46,7 @@ es8388_sound: es8388-sound {
 		simple-audio-card,pin-switches = "Headphone", "Line Out";
 
 		simple-audio-card,cpu {
-			sound-dai = <&sai1>;
+			sound-dai = <&sai2>;
 		};
 
 		simple-audio-card,codec {
@@ -602,18 +602,18 @@ regulator-state-mem {
 &i2c4 {
 	status = "okay";
 
-	es8388: audio-codec@10 {
+	es8388: audio-codec@11 {
 		compatible = "everest,es8388", "everest,es8328";
-		reg = <0x10>;
-		clocks = <&cru CLK_SAI1_MCLKOUT_TO_IO>;
+		reg = <0x11>;
+		clocks = <&cru CLK_SAI2_MCLKOUT_TO_IO>;
+		assigned-clocks = <&cru CLK_SAI2_MCLKOUT_TO_IO>;
+		assigned-clock-rates = <12288000>;
 		AVDD-supply = <&vcc_3v3_s0>;
 		DVDD-supply = <&vcc_3v3_s0>;
 		HPVDD-supply = <&vcc_3v3_s0>;
 		PVDD-supply = <&vcc_3v3_s0>;
-		assigned-clocks = <&cru CLK_SAI1_MCLKOUT_TO_IO>;
-		assigned-clock-rates = <12288000>;
 		pinctrl-names = "default";
-		pinctrl-0 = <&sai1m0_mclk>;
+		pinctrl-0 = <&sai2m0_mclk>;
 		#sound-dai-cells = <0>;
 	};
 };
@@ -663,7 +663,7 @@ gmac1_rst: gmac1-rst {
 
 	headphone {
 		hp_det: hp-det {
-			rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>;
+			rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
 
@@ -680,12 +680,7 @@ typec5v_pwren_h: typec5v-pwren-h {
 	};
 };
 
-&sai1 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&sai1m0_lrck
-		     &sai1m0_sclk
-		     &sai1m0_sdi0
-		     &sai1m0_sdo0>;
+&sai2 {
 	status = "okay";
 };
 
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 6/6] arm64: dts: rockchip: update 100ASK DshanPi A1 support
  2025-11-01 12:00 [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Chukun Pan
                   ` (3 preceding siblings ...)
  2025-11-01 12:00 ` [PATCH 5/6] arm64: dts: rockchip: fixes audio " Chukun Pan
@ 2025-11-01 12:00 ` Chukun Pan
  2025-11-13 23:05   ` Heiko Stübner
  2025-11-13 23:00 ` [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Heiko Stübner
  2025-11-13 23:04 ` (subset) " Heiko Stuebner
  6 siblings, 1 reply; 11+ messages in thread
From: Chukun Pan @ 2025-11-01 12:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Chukun Pan, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

Enable button, RTC and USB support for the 100ASK DshanPi A1 board.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../dts/rockchip/rk3576-100ask-dshanpi-a1.dts | 94 +++++++++++++++++++
 1 file changed, 94 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
index 815f75e7cd70..f325adf348ce 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
@@ -7,6 +7,7 @@
 /dts-v1/;
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 #include <dt-bindings/leds/common.h>
 #include <dt-bindings/pinctrl/rockchip.h>
 #include <dt-bindings/soc/rockchip,vop2.h>
@@ -66,6 +67,61 @@ hdmi_con_in: endpoint {
 		};
 	};
 
+	keys-0 {
+		compatible = "adc-keys";
+		io-channels = <&saradc 0>;
+		io-channel-names = "buttons";
+		keyup-threshold-microvolt = <1800000>;
+		poll-interval = <100>;
+
+		button-maskrom {
+			label = "MASKROM";
+			linux,code = <KEY_SETUP>;
+			press-threshold-microvolt = <0>;
+		};
+	};
+
+	keys-1 {
+		compatible = "adc-keys";
+		io-channels = <&saradc 1>;
+		io-channel-names = "buttons";
+		keyup-threshold-microvolt = <1800000>;
+		poll-interval = <100>;
+
+		button-recovery {
+			label = "RECOVERY";
+			linux,code = <KEY_VENDOR>;
+			press-threshold-microvolt = <0>;
+		};
+	};
+
+	keys-2 {
+		compatible = "adc-keys";
+		io-channels = <&saradc 4>;
+		io-channel-names = "buttons";
+		keyup-threshold-microvolt = <1800000>;
+		poll-interval = <100>;
+
+		button-user2 {
+			label = "USER2";
+			linux,code = <BTN_2>;
+			press-threshold-microvolt = <0>;
+		};
+	};
+
+	keys-3 {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&gpio0_a0_d>;
+
+		button-user1 {
+			gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_LOW>;
+			label = "USER1";
+			linux,code = <BTN_1>;
+			wakeup-source;
+		};
+	};
+
 	vcc_in: regulator-vcc-12v0-dcin {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_in";
@@ -599,6 +655,15 @@ regulator-state-mem {
 	};
 };
 
+&i2c2 {
+	status = "okay";
+
+	rtc@68 {
+		compatible = "dallas,ds1338";
+		reg = <0x68>;
+	};
+};
+
 &i2c4 {
 	status = "okay";
 
@@ -618,6 +683,11 @@ es8388: audio-codec@11 {
 	};
 };
 
+&i2c9 {
+	pinctrl-0 = <&i2c9m1_xfer>;
+	status = "okay";
+};
+
 &mdio0 {
 	rgmii_phy0: phy@0 {
 		compatible = "ethernet-phy-ieee802.3-c22";
@@ -661,6 +731,12 @@ gmac1_rst: gmac1-rst {
 		};
 	};
 
+	gpio-keys {
+		gpio0_a0_d: gpio0-a0-d {
+			rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	headphone {
 		hp_det: hp-det {
 			rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -688,6 +764,11 @@ &sai6 {
 	status = "okay";
 };
 
+&saradc {
+	vref-supply = <&vcca1v8_pldo2_s0>;
+	status = "okay";
+};
+
 &sdhci {
 	bus-width = <8>;
 	full-pwr-cycle-in-suspend;
@@ -733,6 +814,19 @@ &uart0 {
 	status = "okay";
 };
 
+&usbdp_phy {
+	status = "okay";
+};
+
+&usb_drd0_dwc3 {
+	status = "okay";
+};
+
+&usb_drd1_dwc3 {
+	dr_mode = "host";
+	status = "okay";
+};
+
 &vop {
 	status = "okay";
 };
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1
  2025-11-01 12:00 [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Chukun Pan
                   ` (4 preceding siblings ...)
  2025-11-01 12:00 ` [PATCH 6/6] arm64: dts: rockchip: update 100ASK DshanPi A1 support Chukun Pan
@ 2025-11-13 23:00 ` Heiko Stübner
  2025-11-13 23:04 ` (subset) " Heiko Stuebner
  6 siblings, 0 replies; 11+ messages in thread
From: Heiko Stübner @ 2025-11-13 23:00 UTC (permalink / raw)
  To: Chukun Pan
  Cc: Chukun Pan, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

Hi,

Am Samstag, 1. November 2025, 13:00:05 Mitteleuropäische Normalzeit schrieb Chukun Pan:
> Add missing MMC aliases. Remove the max-frequency property
> from the MMC node, which is already defined in rk3576.dtsi.

please split this into 2 patches, one for the aliases, one for the
max-frequency removal.

Thanks
Heiko

> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
> index 59c172573cf8..9cbd3fae16ab 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
> @@ -19,6 +19,8 @@ / {
>  	aliases {
>  		ethernet0 = &gmac0;
>  		ethernet1 = &gmac1;
> +		mmc0 = &sdhci;
> +		mmc1 = &sdmmc;
>  	};
>  
>  	chosen {
> @@ -735,7 +737,6 @@ &sai6 {
>  &sdhci {
>  	bus-width = <8>;
>  	full-pwr-cycle-in-suspend;
> -	max-frequency = <200000000>;
>  	mmc-hs400-1_8v;
>  	mmc-hs400-enhanced-strobe;
>  	no-sdio;
> @@ -749,7 +750,6 @@ &sdmmc {
>  	cap-mmc-highspeed;
>  	cap-sd-highspeed;
>  	disable-wp;
> -	max-frequency = <200000000>;
>  	sd-uhs-sdr104;
>  	vmmc-supply = <&vcc_3v3_s3>;
>  	vqmmc-supply = <&vccio_sd_s0>;
> 






^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: (subset) [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1
  2025-11-01 12:00 [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Chukun Pan
                   ` (5 preceding siblings ...)
  2025-11-13 23:00 ` [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Heiko Stübner
@ 2025-11-13 23:04 ` Heiko Stuebner
  2025-11-15 15:00   ` Chukun Pan
  6 siblings, 1 reply; 11+ messages in thread
From: Heiko Stuebner @ 2025-11-13 23:04 UTC (permalink / raw)
  To: Chukun Pan
  Cc: Heiko Stuebner, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree


On Sat, 01 Nov 2025 20:00:05 +0800, Chukun Pan wrote:
> Add missing MMC aliases. Remove the max-frequency property
> from the MMC node, which is already defined in rk3576.dtsi.
> 
> 

Applied, thanks!

[2/6] arm64: dts: rockchip: fixes regulator for 100ASK DshanPi A1
      commit: 0b822c59c826f47dc63d9470b4710bd251266cae
[3/6] arm64: dts: rockchip: fixes ethernet for 100ASK DshanPi A1
      commit: 9c79c9e03547068404cca5139dfea281d655ff90
[4/6] arm64: dts: rockchip: fixes supply for 100ASK DshanPi A1
      commit: 621bb09a76fa12a9e61c9d745ae524db86abf781
[5/6] arm64: dts: rockchip: fixes audio for 100ASK DshanPi A1
      commit: e99d922d37351ddcd6e1d3f4623340db547c8398

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 6/6] arm64: dts: rockchip: update 100ASK DshanPi A1 support
  2025-11-01 12:00 ` [PATCH 6/6] arm64: dts: rockchip: update 100ASK DshanPi A1 support Chukun Pan
@ 2025-11-13 23:05   ` Heiko Stübner
  0 siblings, 0 replies; 11+ messages in thread
From: Heiko Stübner @ 2025-11-13 23:05 UTC (permalink / raw)
  To: Chukun Pan
  Cc: Chukun Pan, Hsun Lai, Rob Herring, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

Am Samstag, 1. November 2025, 13:00:10 Mitteleuropäische Normalzeit schrieb Chukun Pan:
> Enable button, RTC and USB support for the 100ASK DshanPi A1 board.

please split this into 3 patches :-) .

The list above already describes the points to split on.

Thanks
Heiko






^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: (subset) [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1
  2025-11-13 23:04 ` (subset) " Heiko Stuebner
@ 2025-11-15 15:00   ` Chukun Pan
  2025-11-15 19:53     ` Heiko Stübner
  0 siblings, 1 reply; 11+ messages in thread
From: Chukun Pan @ 2025-11-15 15:00 UTC (permalink / raw)
  To: heiko
  Cc: amadeus, conor+dt, devicetree, krzk+dt, linux-arm-kernel,
	linux-kernel, linux-rockchip, robh

Hi,

> Applied, thanks!

> [4/6] arm64: dts: rockchip: fixes supply for 100ASK DshanPi A1
>       commit: 621bb09a76fa12a9e61c9d745ae524db86abf781

Sorry, I don't know if this is a problem:

The commit message started with an extra ">".

>From the schematic, the supply of ES8388 chip and the vmmc-supply
of SD card both originate from the VCC3V3_S0 regulator, fix it.

https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=621bb09a76fa12a9e61c9d745ae524db86abf781

Thanks,
Chukun


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: (subset) [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1
  2025-11-15 15:00   ` Chukun Pan
@ 2025-11-15 19:53     ` Heiko Stübner
  0 siblings, 0 replies; 11+ messages in thread
From: Heiko Stübner @ 2025-11-15 19:53 UTC (permalink / raw)
  To: Chukun Pan
  Cc: amadeus, conor+dt, devicetree, krzk+dt, linux-arm-kernel,
	linux-kernel, linux-rockchip, robh

Hi,

Am Samstag, 15. November 2025, 16:00:10 Mitteleuropäische Normalzeit schrieb Chukun Pan:
> > Applied, thanks!
> 
> > [4/6] arm64: dts: rockchip: fixes supply for 100ASK DshanPi A1
> >       commit: 621bb09a76fa12a9e61c9d745ae524db86abf781
> 
> Sorry, I don't know if this is a problem:
> 
> The commit message started with an extra ">".
> 
> >From the schematic, the supply of ES8388 chip and the vmmc-supply
> of SD card both originate from the VCC3V3_S0 regulator, fix it.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=621bb09a76fa12a9e61c9d745ae524db86abf781

thanks for noticing this. I've now edited the commit message in place
to fix that.

Heiko




^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2025-11-15 19:53 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-01 12:00 [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Chukun Pan
2025-11-01 12:00 ` [PATCH 2/6] arm64: dts: rockchip: fixes regulator " Chukun Pan
2025-11-01 12:00 ` [PATCH 3/6] arm64: dts: rockchip: fixes ethernet " Chukun Pan
2025-11-01 12:00 ` [PATCH 4/6] arm64: dts: rockchip: fixes supply " Chukun Pan
2025-11-01 12:00 ` [PATCH 5/6] arm64: dts: rockchip: fixes audio " Chukun Pan
2025-11-01 12:00 ` [PATCH 6/6] arm64: dts: rockchip: update 100ASK DshanPi A1 support Chukun Pan
2025-11-13 23:05   ` Heiko Stübner
2025-11-13 23:00 ` [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1 Heiko Stübner
2025-11-13 23:04 ` (subset) " Heiko Stuebner
2025-11-15 15:00   ` Chukun Pan
2025-11-15 19:53     ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).