From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC42C282DD for ; Tue, 23 Apr 2019 09:31:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D1D320811 for ; Tue, 23 Apr 2019 09:31:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VyJBa3HM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D1D320811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aK64imD3cJY6HIabU8mjVS/X12jzPhi0sdkcS0bNVg8=; b=VyJBa3HMEHsDq8k1RnT5o/hIA plzkNZ4AFiRr3K15Yeeaj5UT8qM1CNd54VGIUQNl/rOLc28DMbdbppsMC7MdUSb58gH9WLPeIWTd/ H6abYC7jfmWp2wVdGXsvoCfGF92qivSwn9X2O2Nt+ovWHJSFkAFh6d8wDT+GsP1IozAJua2SxrvOg QZlOeHtUwEtQ9sPwgUPnwbbROAUXv/PljXNfktsnqvm6mrA1ArOvuQxDCrVby4Pw6DyuVRw1kCS/Q eu876aaxX5+55k0TIkpVYUf4wzK0TDa7IrrcEG/bIJ4Y8mNQT8L8p0iJ706gzJIz6wvW/S2hsdG3B VdO48Hr9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIrlp-0001IR-DW; Tue, 23 Apr 2019 09:31:21 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIrlm-0001Hk-Dd for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 09:31:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D0BE374; Tue, 23 Apr 2019 02:31:16 -0700 (PDT) Received: from [10.37.12.155] (unknown [10.37.12.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C071F3F557; Tue, 23 Apr 2019 02:31:14 -0700 (PDT) Subject: Re: [PATCH v2 05/36] coresight: tmc: Cleanup power management To: mathieu.poirier@linaro.org References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-6-git-send-email-suzuki.poulose@arm.com> From: Suzuki K Poulose Message-ID: <204642c0-e83e-9a46-12f2-8b17e6ff8467@arm.com> Date: Tue, 23 Apr 2019 10:33:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_023118_467194_5651985B X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/17/2019 09:03 PM, Mathieu Poirier wrote: > On Mon, 15 Apr 2019 at 10:05, Suzuki K Poulose wrote: >> >> Drop the power only if we were successful in probing the device. >> >> Cc: Mathieu Poirier >> Signed-off-by: Suzuki K Poulose >> --- >> drivers/hwtracing/coresight/coresight-tmc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c >> index 647b6aa..c6a5462 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc.c >> @@ -432,8 +432,6 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id) >> drvdata->size = readl_relaxed(drvdata->base + TMC_RSZ) * 4; >> } >> >> - pm_runtime_put(&adev->dev); >> - >> desc.pdata = pdata; >> desc.dev = dev; >> desc.groups = coresight_tmc_groups; >> @@ -476,6 +474,8 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id) >> ret = misc_register(&drvdata->miscdev); >> if (ret) >> coresight_unregister(drvdata->csdev); >> + else >> + pm_runtime_put(&adev->dev); >> out: >> return ret; >> } > > I have applied patches 1 to 5. Thanks Mathieu ! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel