From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: shmobile: uImage load address rework
Date: Tue, 11 Jun 2013 23:50:28 +0200 [thread overview]
Message-ID: <2051721.a0060yLKKU@avalon> (raw)
In-Reply-To: <20130610092857.19175.25629.sendpatchset@w520>
Hi Magnus,
Thanks for the patch.
On Monday 10 June 2013 18:28:57 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> This is V2 of the mach-shmobile uImage load address rework patch.
>
> Rework the mach-shmobile uImage load address calculation by storing
> the per-board load addresses in Makefile.boot. This removes the
> CONFIG_MEMORY_START dependency from Makefile.boot, and it also makes
> it possible to create safe kernel images that boot on multiple boards.
>
> This is one of several series of code that reworks code not to rely on
> CONFIG_MEMORY_START/SIZE which in turn is needed for ARCH_MULTIPLATFORM.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
I've noticed today that KZM9G doesn't boot v3.10-rc2 with
CONFIG_AUTO_ZRELADDR=y. While not caused by this patch, that's something that
will need to be fixed to support multi-arch kernels. I'm not too familiar with
early boot code, would you be able to have a look at this ?
> ---
>
> Changes since V1:
> - On popular request, merged patch 5 and 14 and all other.
> - Updated the __ZRELADDR calculation, thanks Arnd!
> - Added Reviewed-by from Laurent and Morimoto-san, thanks!
>
> arch/arm/mach-shmobile/Makefile.boot | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> --- 0001/arch/arm/mach-shmobile/Makefile.boot
> +++ work/arch/arm/mach-shmobile/Makefile.boot 2013-06-10
16:15:22.000000000
> +0900 @@ -1,6 +1,22 @@
> -__ZRELADDR := $(shell /bin/bash -c 'printf "0x%08x" \
> - $$[$(CONFIG_MEMORY_START) + 0x8000]')
> +# per-board load address for uImage
> +loadaddr-y :=
> +loadaddr-$(CONFIG_MACH_AG5EVM) += 0x40008000
> +loadaddr-$(CONFIG_MACH_AP4EVB) += 0x40008000
> +loadaddr-$(CONFIG_MACH_APE6EVM) += 0x40008000
> +loadaddr-$(CONFIG_MACH_ARMADILLO800EVA) += 0x40008000
> +loadaddr-$(CONFIG_MACH_ARMADILLO800EVA_REFERENCE) += 0x40008000
> +loadaddr-$(CONFIG_MACH_BOCKW) += 0x60008000
> +loadaddr-$(CONFIG_MACH_BONITO) += 0x40008000
> +loadaddr-$(CONFIG_MACH_KOTA2) += 0x41008000
> +loadaddr-$(CONFIG_MACH_KZM9D) += 0x40008000
> +loadaddr-$(CONFIG_MACH_KZM9G) += 0x41008000
> +loadaddr-$(CONFIG_MACH_KZM9G_REFERENCE) += 0x41008000
> +loadaddr-$(CONFIG_MACH_LAGER) += 0x40008000
> +loadaddr-$(CONFIG_MACH_MACKEREL) += 0x40008000
> +loadaddr-$(CONFIG_MACH_MARZEN) += 0x60008000
> +loadaddr-$(CONFIG_MACH_MARZEN_REFERENCE) += 0x60008000
>
> +__ZRELADDR := $(sort $(loadaddr-y))
> zreladdr-y += $(__ZRELADDR)
>
> # Unsupported legacy stuff
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-06-11 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 9:28 [PATCH v2] ARM: shmobile: uImage load address rework Magnus Damm
2013-06-11 7:47 ` Simon Horman
2013-06-11 9:33 ` Magnus Damm
2013-06-11 13:54 ` Guennadi Liakhovetski
2013-06-12 2:20 ` Magnus Damm
2013-06-12 6:22 ` Guennadi Liakhovetski
2013-06-11 21:50 ` Laurent Pinchart [this message]
2013-06-12 2:21 ` Magnus Damm
2013-06-12 2:31 ` Laurent Pinchart
2013-06-19 13:16 ` Laurent Pinchart
2013-06-25 14:00 ` Magnus Damm
2013-07-03 23:53 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2051721.a0060yLKKU@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).