From mboxrd@z Thu Jan 1 00:00:00 1970 From: LW@KARO-electronics.de (=?utf-8?Q?Lothar_Wa=C3=9Fmann?=) Date: Sat, 18 Aug 2012 15:14:04 +0200 Subject: [PATCH] rtc: snvs: improve timeout handling in snvs_rtc_enable() In-Reply-To: <20120818124652.GH24242@S2101-09.ap.freescale.net> References: <1345277408-30044-1-git-send-email-LW@KARO-electronics.de> <20120818124652.GH24242@S2101-09.ap.freescale.net> Message-ID: <20527.38172.621130.368019@ipc1.ka-ro> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Shawn Guo writes: > On Sat, Aug 18, 2012 at 10:10:08AM +0200, Lothar Wa?mann wrote: > > If snvs_rtc_enable() happens to be descheduled for a period longer > > than the timout period, a timeout may be indicated even if the RTC > > status has changed meanwhile. Force a status read at the end of the > > timeout period to prevent bogus timeout errors. > > > > > > Signed-off-by: Lothar Wa?mann > > --- > > drivers/rtc/rtc-snvs.c | 22 +++++++++++++--------- > > 1 files changed, 13 insertions(+), 9 deletions(-) > > > > Compile tested only due to lack of HW. > > Tested-by: Shawn Guo > > A small nitpick below. > > > > > diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c > > index 912f116..dc921b2 100644 > > --- a/drivers/rtc/rtc-snvs.c > > +++ b/drivers/rtc/rtc-snvs.c > > @@ -81,6 +81,13 @@ static void rtc_write_sync_lp(void __iomem *ioaddr) > > } > > } > > > > +static int snvs_rtc_enable_done(int enable, void __iomem *addr) > > Can we rename parameter "addr" to "ioaddr" and put it before "enable", > also change "enable" to bool? > OK. The resulting assembler code of the patch below is identical to the previous version of this patch. Signed-off-by: Lothar Wa?mann Tested-by: Shawn Guo --- drivers/rtc/rtc-snvs.c | 22 +++++++++++++--------- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c index 912f116..a757cb9 100644 --- a/drivers/rtc/rtc-snvs.c +++ b/drivers/rtc/rtc-snvs.c @@ -81,6 +81,13 @@ static void rtc_write_sync_lp(void __iomem *ioaddr) } } +static int snvs_rtc_enable_done(void __iomem *ioaddr, bool enable) +{ + u32 lpcr = readl(ioaddr + SNVS_LPCR); + + return enable ^ !(lpcr & SNVS_LPCR_SRTC_ENV); +} + static int snvs_rtc_enable(struct snvs_rtc_data *data, bool enable) { unsigned long timeout = jiffies + msecs_to_jiffies(1); @@ -99,18 +106,15 @@ static int snvs_rtc_enable(struct snvs_rtc_data *data, bool enable) spin_unlock_irqrestore(&data->lock, flags); while (1) { - lpcr = readl(data->ioaddr + SNVS_LPCR); + if (snvs_rtc_enable_done(data->ioaddr, enable)) + break; - if (enable) { - if (lpcr & SNVS_LPCR_SRTC_ENV) - break; - } else { - if (!(lpcr & SNVS_LPCR_SRTC_ENV)) + if (time_after(jiffies, timeout)) { + if (snvs_rtc_enable_done(data->ioaddr, enable)) break; + else + return -ETIMEDOUT; } - - if (time_after(jiffies, timeout)) - return -ETIMEDOUT; } return 0; -- 1.7.2.5 Lothar Wa?mann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________