From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: orion: convert the irq_reg_{readl, writel} calls to the new API
Date: Wed, 26 Nov 2014 09:58:34 +0100 [thread overview]
Message-ID: <2056471.vW2IU3anAt@wuerfel> (raw)
In-Reply-To: <20141126023853.GG22670@titan.lakedaemon.net>
On Tuesday 25 November 2014 21:38:53 Jason Cooper wrote:
> On Tue, Nov 25, 2014 at 09:59:11PM +0100, Arnd Bergmann wrote:
> > On Tuesday 25 November 2014 12:24:16 Olof Johansson wrote:
> > > On Tue, Nov 25, 2014 at 7:19 AM, Gregory CLEMENT
> > > <gregory.clement@free-electrons.com> wrote:
> > > > The commit "genirq: Generic chip: Change irq_reg_{readl,writel}
> > > > arguments" modified the API. In the same tome the
> > > > arch/arm/plat-orion/gpio.c file received a fix with the use of the old
> > > > API: "ARM: orion: Fix for certain sequence of request_irq can cause
> > > > irq storm". This commit fixes the use of the API.
> > > >
> > > > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> > > > ---
> > > > Hi Jason,
> > > >
> > > > This patch fix a build error in linux-next:
> > > >
> > > > arch/arm/plat-orion/gpio.c:509:12: error: too few arguments to function 'irq_reg_readl'
> > > > arch/arm/plat-orion/gpio.c:511:2: error: too few arguments to function 'irq_reg_writel'
> > > > arch/arm/plat-orion/gpio.c:523:12: error: too few arguments to function 'irq_reg_readl'
> > > > arch/arm/plat-orion/gpio.c:525:2: error: too few arguments to function 'irq_reg_writel'
> > > >
> > > > But if we want to apply it on the mvebu branch we need to add a
> > > > dependecy to "332fd7c4fef5 genirq: Generic chip: Change
> > > > irq_reg_{readl,writel} arguments"
> > >
> > > Please take this through the same repo as the change in the prototype:
> > >
> > > Acked-by: Olof Johansson <olof@lixom.net>
> > >
> >
> > As mentioned before, the problem here is that the prototype gets changed
> > in the irqchip repo, while the gpio driver only starts using this interface
> > in the mvebu repo. Both trees are owned by Jason, so he should be able
> > to find a solution though.
>
> I made myself promise not rebase mvebu/fixes. :-)
Ah, I hadn't realized that the gpio change is already in 3.18-rc, that actually
simplifies it.
Arnd
next prev parent reply other threads:[~2014-11-26 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 15:19 [PATCH] ARM: orion: convert the irq_reg_{readl, writel} calls to the new API Gregory CLEMENT
2014-11-25 20:24 ` Olof Johansson
2014-11-25 20:59 ` Arnd Bergmann
2014-11-26 2:38 ` Jason Cooper
2014-11-26 8:58 ` Arnd Bergmann [this message]
2014-11-26 2:37 ` [PATCH] ARM: orion: convert the irq_reg_{readl,writel} " Jason Cooper
2014-11-26 3:31 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2056471.vW2IU3anAt@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox